Arch Linux User Repository

1.6.0 stable has been released
https://sourceforge.net/projects/scribus/files/scribus/1.6.0/

Hi again,

I realized I should look at the 1.5 codebase and found the fix was obvious and simpler than my original patch. A new release has been uploaded.

If there are any other problems please let me know :) TIA

EDIT: For reference, gcc ver. 11 changed its behavior, triggering this previous build error. Please see this gcc bug report -- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87699

Clemmitt

Hi, Ben,

The patch was a one-liner. I am amazed that's all that was needed. Even though I'm not a big time C++ programmer it wasn't difficult. My first patch failed but it pointed the way to something that worked.

I will try to patch this AUR package soon, in a couple of days. If I don't find time soon, please send me a message to remind me. There's no use in you duplicating my work :)

Thanks again.

Clemmitt

Hello, You have definitely better skills than me. You can maintain the package and post your fix if you have time. Even I will try to fix it later with your patches. Ben

OK, now I get why you're not supposed to post patches in the AUR comments.

Patch for gtdialogs.cpp -- https://pastebin.com/uX8txkMt

Patch for PKGBUILD -- https://pastebin.com/PUDzVfiV

Again, HTH :)

Clemmitt

Hi,

I've fixed the build error. This occurred for me under "gcc (GCC) 11.1.0".

Patch:

--- cut here ---

--- scribus-1.4.8/scribus/gtdialogs.cpp.orig 2019-03-05 17:44:41.000000000 -0500 +++ scribus-1.4.8/scribus/gtdialogs.cpp 2021-12-14 12:09:30.731362735 -0500 @@ -160,7 +160,7 @@ if (imp != "false") { res = imp; - if (importers.contains(res) > 0) + if (static_cast<bool>(importers.contains(res)) > static_cast<bool>(0)) ok = true; }

--- cut here ---

Patch for PKGBUILD:

--- cut here ---

--- ./PKGBUILD.orig 2021-11-18 16:00:15.096606674 -0500 +++ ./PKGBUILD 2021-12-14 12:31:45.150239569 -0500 @@ -19,11 +19,18 @@ makedepends=('cmake') optdepends=('lib2geom: for mesh distortion') conflicts=('scribus') -provides=('scribus-stable') -source=("https://netix.dl.sourceforge.net/project/scribus/scribus/1.4.8/scribus-1.4.8.tar.gz") -md5sums=('6246cadc3d0a6dfc0119926eb7e7dcda') +provides=('scribus') +source=("https://netix.dl.sourceforge.net/project/scribus/scribus/1.4.8/scribus-1.4.8.tar.gz" + 'gtdialogs.cpp_pointer.patch') +md5sums=('6246cadc3d0a6dfc0119926eb7e7dcda' + 'd73d51ca7b946f8a4a10d0c6c547388e') options=('!emptydirs')

+prepare() { + cd "${pkgname%-stable}-$pkgver" + patch -Np1 -i "${srcdir}/gtdialogs.cpp_pointer.patch" +} + build() { cd "${pkgname%-stable}-$pkgver" cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr \

--- cut here ---

HTH :D

Clemmitt

Hi,

Unfortunately, this pkg doesn't build for me --

/home/blah/AUR/graphics/scribus-stable/scribus-stable-1.4.8-1/src/scribus-1.4.8/scribus/gtdialogs.cpp: In member function ‘bool gtDialogs::runImporterDialog (const QStringList&)’: /home/blah/AUR/graphics/scribus-stable/scribus-stable-1.4.8-1/src/scribus-1.4.8/scribus/gtdialogs.cpp:163:45: error: ordered comparison of pointer with integer zero (‘const void’ and ‘int’) 163 | if (importers.contains(res) > 0) | ~~~~~~~~~~~~~~~~~~~~~~~~^~~ make[2]: [scribus/CMakeFiles/scribus.dir/build.make:5566: scribus/CMakeFiles/scribus.dir/gtdialogs.cpp.o] Error 1 make[2]: Waiting for unfinished jobs.... make[1]: [CMakeFiles/Makefile2:1478: scribus/CMakeFiles/scribus.dir/all] Error 2 make: * [Makefile:156: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting...

A new compiler-thrown error??? gcc pkg is gcc 11.1.0-1 --

$ gcc --version gcc (GCC) 11.1.0

HTH.

Clemmitt Sigler