Package Details: session-desktop 1.12.4-1

Git Clone URL: https://aur.archlinux.org/session-desktop.git (read-only, click to copy)
Package Base: session-desktop
Description: Onion routing based messenger
Upstream URL: https://getsession.org
Keywords: loki messenger session signal
Licenses: GPL-3.0-only
Submitter: xXR01I1Xx
Maintainer: mhdi
Last Packager: mhdi
Votes: 12
Popularity: 0.22
First Submitted: 2020-03-23 07:39 (UTC)
Last Updated: 2024-06-26 21:05 (UTC)

Latest Comments

1 2 3 4 Next › Last »

antony.ho commented on 2023-10-09 23:47 (UTC) (edited on 2023-10-09 23:47 (UTC) by antony.ho)

I have taken over this orphan. Build script and package version have been updated.

sperg512 commented on 2022-10-04 03:26 (UTC)

Tried fixing this again, and it still is failing to build. I've about given up on this.

Neko-san commented on 2022-10-03 19:35 (UTC)

I just use the flatpak at this point; I don't expect this to build anymore

Kimble commented on 2022-10-03 14:32 (UTC) (edited on 2022-10-03 14:33 (UTC) by Kimble)

The same error didn't fixed for 6 months now.

==> Sources are ready.
session-desktop-1.10.1-1: parsing pkg list...
==> Making package: session-desktop 1.10.1-1 (Mon 03 Oct 2022 04:26:33 PM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting build()...
yarn install v1.22.19
[1/6] Validating package.json...
error session-desktop@1.10.1: The engine "node" is incompatible with this module. Expected version "16.13.0". Got "14.16.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'session-desktop-1.10.1-1': 
error: packages failed to build: session-desktop-1.10.1-1

ardency commented on 2022-05-21 13:55 (UTC)

Getting this error during build of the package:

==> Starting build()...
yarn install v1.22.19
[1/6] Validating package.json...
error session-desktop@1.8.6: The engine "node" is incompatible with this module. Expected version "16.13.0". Got "14.16.0"
error Found incompatible module.

Seems like the PKGBUILD manually selects node v14.16.0 through nvm. This ought to be bumped to v16.

Doing so results in a build error for better-sqlite3, that I'm not sure how to fix though:

npm ERR! > better-sqlite3@7.5.0 install
npm ERR! > npm run build-release
npm ERR! 
npm ERR! > better-sqlite3@7.5.0 build-release
npm ERR! > node-gyp rebuild --release
npm ERR! Error: TAR_BAD_ARCHIVE: Unrecognized archive format
npm ERR!     at Unpack.warn (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/warn-mixin.js:19:40)
npm ERR!     at Unpack.warn (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/unpack.js:220:18)
npm ERR!     at Unpack.<anonymous> (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/parse.js:81:14)
npm ERR!     at Unpack.emit (node:events:402:35)
npm ERR!     at Unpack.[emit] (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/parse.js:285:12)
npm ERR!     at Unpack.[maybeEnd] (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/parse.js:401:17)
npm ERR!     at Unpack.[consumeChunk] (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/parse.js:432:21)
npm ERR!     at Unpack.write (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/parse.js:364:25)
npm ERR!     at Unpack.end (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/tar/lib/parse.js:477:14)
npm ERR!     at Yallist.<anonymous> (/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/node_modules/minipass/index.js:409:18) {
npm ERR!   recoverable: false,
npm ERR!   file: '/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/deps/sqlcipher.tar.gz',
npm ERR!   cwd: '/home/erin/.npm/_cacache/tmp/git-clonel3q3cq/build/Release/obj/gen/sqlite3',
npm ERR!   code: 'TAR_BAD_ARCHIVE',
npm ERR!   tarCode: 'TAR_BAD_ARCHIVE'
npm ERR! }
npm ERR! make: *** [deps/locate_sqlite3.target.mk:17: b857c92884e9598d609f6be182a2595df7a8e00f.intermediate] Error 1

sperg512 commented on 2022-05-02 18:10 (UTC)

Alright, after a month of SSH being really sussy, I've got this working again. Please let me know if there is need of a node.js version change again.

sperg512 commented on 2022-04-10 13:24 (UTC)

Thank you, I'll apply this when I'm able, and also get auto-updating working while I'm at it

antony.ho commented on 2022-04-10 02:59 (UTC)

Here is a patch to fix all the build problems.

From fe8ded9b7906bb2781ac5277486e4cb2b21e23ef Mon Sep 17 00:00:00 2001
From: Antony Ho <ntonyworkshop@gmail.com>
Date: Sun, 10 Apr 2022 04:35:56 +0200
Subject: [PATCH] Fix build failures

- Use correct nodejs version for building the package
- Update package build dependency
- Apply git lfs as it is needed according to official docs
- Fix the way checking out corresponding version from tag
- Use the new merged branch of better-sqlite3 from SignalApp to solve NodeJS
  dependency issue during build time
- Fix icon file paths on copying from src
- Remove 24x24 icon copying as the file doesn't exist
- Update build commands to update and install dependency with proper workflow
  on building package for NodeJS
- Bump version to 1.7.9
---
 PKGBUILD           | 38 +++++++++++++++++++++-----------------
 patch.diff.example | 13 -------------
 2 files changed, 21 insertions(+), 30 deletions(-)
 delete mode 100644 patch.diff.example

diff --git a/PKGBUILD b/PKGBUILD
index 0e055aa..6cd0218 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,13 +1,13 @@
 # Maintainer: xXR01I1Xx <xxr01i1xx@tuta.io>
 pkgname=session-desktop
-pkgver=1.7.6
+pkgver=1.7.9
 pkgrel=1
 pkgdesc="Private messaging from your desktop"
 arch=(x86_64)
 url="https://getsession.org"
 license=('GPL-3.0')
 depends=(libxtst nss alsa-lib libxss libnotify xdg-utils)
-makedepends=('git' 'nvm' 'yarn')
+makedepends=('git' 'git-lfs' 'nvm' 'yarn' 'nodejs>=14.16.0')
 optdepends=('libappindicator-gtk3: for tray support')
 provides=(session-messenger-desktop)
 conflicts=(session-desktop-bin session-desktop-git session-desktop-appimage)
@@ -20,17 +20,23 @@ sha256sums=('SKIP'

 prepare() {
   cd $srcdir/session-desktop
-  git checkout $(git describe --tags)
-  source /usr/share/nvm/init-nvm.sh && nvm install 10.19.0
+  git checkout v$pkgver
+  source /usr/share/nvm/init-nvm.sh && nvm install 14.16.0
+  git lfs install
+  nvm install
+  nvm use
+  yarn remove better-sqlite3
+  yarn add https://github.com/signalapp/better-sqlite3.git#better-sqlcipher
 }

 build() {
   cd "$srcdir/session-desktop"
-  source /usr/share/nvm/init-nvm.sh && nvm use --delete-prefix v10.13.0 --silent
+  source /usr/share/nvm/init-nvm.sh && nvm use --delete-prefix v14.16.0 --silent
   export SIGNAL_ENV=production
-  yarn install --frozen-lockfile
+  yarn install
   yarn generate
-  yarn lint-full
+  npm install
+  yarn grunt
   $(yarn bin)/electron-builder --config.extraMetadata.environment=$SIGNAL_ENV --publish=never --config.directories.output=release --linux tar.xz
 }

@@ -38,7 +44,6 @@ package() {
   mkdir -p $pkgdir/usr/share/applications
   mkdir -p $pkgdir/opt/
   mkdir -p $pkgdir/usr/share/icons/hicolor/16x16/apps/
-  mkdir -p $pkgdir/usr/share/icons/hicolor/24x24/apps/
   mkdir -p $pkgdir/usr/share/icons/hicolor/32x32/apps/
   mkdir -p $pkgdir/usr/share/icons/hicolor/48x48/apps/
   mkdir -p $pkgdir/usr/share/icons/hicolor/64x64/apps/
@@ -47,15 +52,14 @@ package() {
   mkdir -p $pkgdir/usr/share/icons/hicolor/512x512/apps/
   mkdir -p $pkgdir/usr/share/icons/hicolor/1024x1024/apps/

-  cp $srcdir/session-desktop/build/icons/png/16x16.png $pkgdir/usr/share/icons/hicolor/16x16/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/24x24.png $pkgdir/usr/share/icons/hicolor/24x24/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/32x32.png $pkgdir/usr/share/icons/hicolor/32x32/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/48x48.png $pkgdir/usr/share/icons/hicolor/48x48/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/64x64.png $pkgdir/usr/share/icons/hicolor/64x64/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/128x128.png $pkgdir/usr/share/icons/hicolor/128x128/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/256x256.png $pkgdir/usr/share/icons/hicolor/256x256/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/512x512.png $pkgdir/usr/share/icons/hicolor/512x512/apps/session-messenger-desktop.png
-  cp $srcdir/session-desktop/build/icons/png/1024x1024.png $pkgdir/usr/share/icons/hicolor/1024x1024/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_16x16.png $pkgdir/usr/share/icons/hicolor/16x16/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_32x32.png $pkgdir/usr/share/icons/hicolor/32x32/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_48x48.png $pkgdir/usr/share/icons/hicolor/48x48/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_64x64.png $pkgdir/usr/share/icons/hicolor/64x64/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_128x128.png $pkgdir/usr/share/icons/hicolor/128x128/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_256x256.png $pkgdir/usr/share/icons/hicolor/256x256/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_512x512.png $pkgdir/usr/share/icons/hicolor/512x512/apps/session-messenger-desktop.png
+  cp $srcdir/session-desktop/build/icons/icon_1024x1024.png $pkgdir/usr/share/icons/hicolor/1024x1024/apps/session-messenger-desktop.png

   tar xf $srcdir/session-desktop/release/session-desktop-linux-x64-$pkgver.tar.xz -C $pkgdir/opt/
   mv $pkgdir/opt/session-desktop-linux-x64-$pkgver $pkgdir/opt/Session
diff --git a/patch.diff.example b/patch.diff.example
deleted file mode 100644
index e58f169..0000000
--- a/patch.diff.example
+++ /dev/null
@@ -1,13 +0,0 @@
-diff --git a/package.json b/package.json
-index d05625c7..128028f8 100644
---- a/package.json
-+++ b/package.json
-@@ -2,7 +2,7 @@
-   "name": "session-messenger-desktop",
-   "productName": "Session",
-   "description": "Private messaging from your desktop",
--  "version": "1.0.5",
-+  "version": "ver_placeholder",
-   "license": "GPL-3.0",
-   "author": {
-     "name": "Loki Project",
-- 
2.35.1

antony.ho commented on 2022-04-08 20:38 (UTC) (edited on 2022-04-08 20:52 (UTC) by antony.ho)

Getting the node version error as previous discussions. Even with manual modification on the PKGBUILD and switching to v10.19.0.

error session-desktop@1.7.6: The engine "node" is incompatible with this module. Expected version "^14.16.0". Got "10.19.0"
error Found incompatible module.

I edited the PKGBUILD and bumped node version to 14.16.0 as mentioned in the error log. I got the build process passed through the node version error.

But now there is error on the yarn.lock.

[3/6] Fetching packages...
error Couldn't find match for "ad0db5dd09c0ea4007b1c46bd4f7273827803347" in "refs/heads/better-sqlcipher,refs/heads/feature/log-corruption,refs/heads/no-openssl,refs/heads/tmp" for "https://github.com/signalapp/better-sqlite3".

How could the official Linux CI build pipeline pass?

All the reported errors above could be found at issue ticket: https://github.com/oxen-io/session-desktop/issues/1635