Arch Linux User Repository

Hello, this package currently does not build, does not have the right depends, and is using a build.sh script that will try to call apt. I have rewritten the majority of the PKGBUILD to have: proper submodule handling, SPDX compliant license, a proper name (as this is not just a vst plugin, so it needs to be sid-git and replaces sid-vst-git), accurate makedepends and depends, uses cmake directly, and installs everything the project builds.

If you wanna apply this patch yourself, go ahead. Remember, in the future, use the tool namcap to check the basics of a package.

diff --git a/PKGBUILD b/PKGBUILD
index 58818ce..77dd6dc 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,19 +2,30 @@
 # Contributor: Milk Brewster < milk on freenode >
 # Contributer: Lukas Sabota <lukas _at_ lwsabota _dot_ com>

-pkgname=sid-vst-git
+pkgname=sid-git
 _gitbase=SID
-pkgver=r110.845782d
+pkgver=r124.fe0647d
 pkgrel=1
-pkgdesc="Emulates MOS Technology SID audio chip (used in Commodore 64) as a VST"
+pkgdesc="Emulates MOS Technology SID audio chip (used in Commodore 64) as a VST, VST3, and LV2"
 arch=('i686' 'x86_64')
 url="http://socalabs.com/"
-license=('LGPL')
+license=('GPL-3.0-only')
 groups=('socalabs-vst-suite')
-depends=('mesa' 'ttf-ms-fonts')
-makedepends=('git')
-source=('SID::git+https://github.com/FigBug/SID.git' )
-md5sums=('SKIP' )
+depends=('webkit2gtk' 'alsa-lib' 'glibc' 'curl' 'gcc-libs' 'freetype2')
+makedepends=('git' 'cmake' 'ninja')
+options=('!lto' '!buildflags')
+replaces=(sid-vst-git)
+conflicts=(sid-vst-git)
+source=('SID::git+https://github.com/FigBug/SID.git'
+   'dRowAudio::git+https://github.com/FigBug/drowaudio.git'
+   'juce::git+https://github.com/WeAreROLI/JUCE.git'
+   'gin::git+https://github.com/FigBug/Gin.git'
+   'plugin_sdk::git+https://github.com/TurnipHat/plugin_sdk.git')
+md5sums=('SKIP'
+         'SKIP'
+         'SKIP'
+         'SKIP'
+         'SKIP')

 pkgver() {
   cd "$srcdir/$_gitbase"
@@ -23,21 +34,37 @@ pkgver() {

 prepare() {
   cd "$srcdir/$_gitbase"
-   sed "s/git@github.com:/https:\/\/github.com\//" -i .gitmodules
-   git submodule init
-   git submodule update
-  cd "$srcdir/$_gitbase/ci"
-   sed "/OS = \"linux\"/s/linux/lynix/" -i build.sh
+  git submodule init
+  for submodule in {dRowAudio,juce,gin,plugin_sdk};
+  do
+   git config submodule.modules/$submodule.url "$srcdir/$submodule"
+  done
+  git -c protocol.file.allow=always submodule update
 }

 build() {
-  cd "$srcdir/$_gitbase/ci"
-   OS=linux ./build.sh
+  cd "$srcdir"
+  cmake -B build \
+  -GNinja \
+  -S "$_gitbase" \
+  -DCMAKE_BUILD_TYPE=None \
+  -DCMAKE_INSTALL_PREFIX=/usr
+
+  cmake --build build
 }

 package() {
-  install -D -m644 "$srcdir/$_gitbase/ci/bin/SID.vst3/Contents/x86_64-linux/$_gitbase.so" "$pkgdir/usr/lib/vst/$_gitbase.so"
-   for file in $srcdir/$_gitbase/ci/bin/SID.lv2/*; do
-     install -D -m644 -t "$pkgdir/usr/lib/lv2/$_gitbase/" "$file"
-   done
+  cd "$srcdir/build/SID_artefacts/None/VST3"
+  install -Dm755 SID.vst3/Contents/x86_64-linux/SID.so "$pkgdir/usr/lib/vst3/SID.vst3/Contents/x86_64-linux/SID.so"
+  install -Dm644 SID.vst3/Contents/Resources/moduleinfo.json "$pkgdir/usr/lib/vst3/SID.vst3/Contents/Resources/moduleinfo.json"
+  cd "$srcdir/build/SID_artefacts/None/VST"
+  install -Dm755 libSID.so "$pkgdir/usr/lib/vst/libSID.so"
+  cd "$srcdir/build/SID_artefacts/None/LV2/SID.lv2"
+  for file in {dsp.ttl,manifest.ttl,ui.ttl};
+  do
+   install -Dm644 "$file" "$pkgdir/usr/lib/lv2/SID.lv2/$file"
+  done
+  install -Dm755 libSID.so "$pkgdir/usr/lib/lv2/SID.lv2/libSID.so"
+  cd "$srcdir/build/SID_artefacts/None/Standalone"
+  install -Dm755 SID "$pkgdir/usr/bin/sid"
 }

added lv2 accidently :D

i just tried it - it is broken - the packager needs to fix it. plugin_sdk repo is empty

[code] Switched to a new branch 'makepkg' -> Creating working copy of plugin_sdk git repo... Cloning into 'plugin_sdk'... done. Switched to a new branch 'makepkg' ==> Starting prepare()... mv: target 'plugin/JuceLibraryCode/.' is not a directory ==> ERROR: A failure occurred in prepare(). Aborting... :: failed to verify integrity or prepare sid-vst-git package [/code]

partial fix pushed. to tired atm to fix the include paths though.

https://github.com/FigBug/SID/issues/1#issuecomment-503336851 - if anyone wants to roll a fix, please stick it in a comment here or ping me on irc

danboid; dep. added, thanks :)

Maybe ttf-ms-fonts should be added to the dependencies for this because unless you have the Verdana font installed (which is part of ttf-ms-fonts), the plugin UI text doesn't get displayed.

All good, I don't know if you still use it but I'll add you as a co-maintainer anyway cos you're around n it's not gonna cause any harm :)

Hi milkmiruku! Feel free to adopt this package. Sorry I didn't see this comment earlier!