Arch Linux User Repository

The gcc-libs depend is already required by the base package so isn't it safe to assume that people using AUR already have it installed?

You are right.

The gcc-libs depend is already required by the base package so isn't it safe to assume that people using AUR already have it installed? Similar to base-devel.

@dreieck Thank you.

↗ Here is a PKGBUILD that solves some issues with the package (there were also other spurious installation directories present) and simplifies some stuff, and also installs documentation:

# Maintainer:  begin-theadventure <begin-thecontact.ncncb at dralias dot com>
# Contributor: drieck (https://aur.archlinux.org/account/dreieck)
# Contributor: frousties

_pkgname=tacentview
pkgname="${_pkgname}"
pkgver=1.0.43
pkgrel=2
pkgdesc="An image and texture viewer for tga, png, apng, exr, dds, ktx, ktx2, astc, pkm, qoi, gif, hdr, jpg, tif, ico, webp, and bmp files. Uses Dear ImGui, OpenGL and Tacent"
arch=('x86_64')
url="https://github.com/bluescan/tacentview"
license=('ISC')
depends=('gcc-libs' 'glibc' 'hicolor-icon-theme' 'libx11' 'libxcb')
# dpkg is needed since only building a debian package creates a installation-ready directory structure :-(.
makedepends=('cmake' 'dpkg' 'git' 'ninja')
source=(
  "${_pkgname}::git+${url}.git#tag=v${pkgver}"
)
sha256sums=(
  'SKIP'  # `tacentview` git
)

prepare() {
  cd "${srcdir}"

  mkdir -p build

  ## `cmake` call in `prepare()` since it will download stuff.
  cmake -S "${_pkgname}" -B build \
    -DCMAKE_BUILD_TYPE=Release \
    -DFETCHCONTENT_QUIET=OFF \
    -DPACKAGE_DEB=ON \
    -GNinja
}

build() {
  cd "${srcdir}"

  ninja -C build
  ninja -C build install # This is in `build()` and not in `package()` to workaround otherwise nested fakeroot error: `ninja -C build install` also calls fakeroot implicitly because it builds a .deb package, and this is needed to get the correct installation directories.
}

package() {
  cd "${srcdir}"

  cp -rv "build/ViewerInstall/Package/${_pkgname}_$(sed -E 's|\.([^\.]*)$|-\1|' <<<"${pkgver}")"/usr "${pkgdir}"/
  find "${pkgdir}" -name .gitignore -exec rm -v {} \;

  install -Dvm644 -t "${pkgdir}/usr/share/doc/${_pkgname}" "${_pkgname}/README.md"
  cp -rv "${_pkgname}/docs" "${pkgdir}/usr/share/doc/${_pkgname}"/

  install -Dvm644 -t "${pkgdir}/usr/share/licenses/${pkgname}" "${_pkgname}/LICENSE"
  ln -svr "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE" "${pkgdir}/usr/share/doc/${_pkgname}/LICENSE"
}

Regards!

libxcb and hicolor-icon-theme are needed as dependencies.

And you must install the License file.

For me, now build works well with up to date GCC 13.2.1.

You can remove gcc12 from makedepends, and from the cmake options.

Regards!

In package(), you use ${_pkgname}, but this variable is not defined.

Also, you use $INPUT, but user defined variables in PKGBUILDs must start with an underscore (_).

Regards and thanks for maintaining!

package() fails for me:

==> Starting package()...
mv: cannot move '.' to '/tmp/makepkg/build/tacentview/pkg/tacentview/.': Device or resource busy

Regards!

build() seems to download a lot of stuff -- build output stalls and I see maxed out network throughput.

Since download seems to be big, please make it a bit more verbose (-DFETCHCONTENT_QUIET=OFF), telling what it does and maybe even showing progress.

Please move the download into the source array and tell cmake where to find the downloaded stuff (-DFETCHCONTENT_FULLY_DISCONNECTED=ON, -DFETCHCONTENT_UPDATES_DISCONNECTED=ON and -DFETCHCONTENT_UPDATES_DISCONNECTED_TACENT=ON and set -DFETCHCONTENT_SOURCE_DIR_TACENT), or if not possible, let the download be carried out during prepare(), so that build() can run offline.

Download takes place after:

==> Starting build()...
-- Viewer -- Default to Release build.
-- Viewer -- Build type set to: Release
-- The C compiler identification is GNU 12.3.0
-- The CXX compiler identification is GNU 12.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/gcc-12 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/gcc-12 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Viewer -- Name tacentview Version 1.0.43
-- Viewer -- Major:1 Minor:0 Revision:43
-- Found Git: /usr/bin/git (found version "2.43.0") 
-- Viewer -- Git found: /usr/bin/git

Regards and thanks for maintaining!

Build fails for me:

==> Starting build()...
CMake Error: No source directory specified for -S
CMake Error: Run 'cmake --help' for all supported options.

You say $_pkgname but have it nowhere defined.

Regards!