Arch Linux User Repository

Arch linux upgraded its cmake to 4.0, and it introduced some incompatibilities. For example when building this aur package:

==> Starting build()...
CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: termistor-git-exit status 4

In addition to cmake-4 problem, upstream project has other bugs. I added two pull requests to it (1 and 2). For now, after first try and seeing the error message, you can apply this diff to project source code and use makepkg -e --noprepare -i to build and install it:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 39cd7ef..6029243 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,5 +1,5 @@

-cmake_minimum_required(VERSION 2.8)
+cmake_minimum_required(VERSION 3.5)
 project(termistor)

 set(CMAKE_INCLUDE_CURRENT_DIR ON)
diff --git a/libtsm/src/shared/shl-pty.c b/libtsm/src/shared/shl-pty.c
index 5dfe977..96c769c 100644
--- a/libtsm/src/shared/shl-pty.c
+++ b/libtsm/src/shared/shl-pty.c
@@ -9,6 +9,8 @@
  * PTY Helpers
  */

+#define _GNU_SOURCE
+
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
@@ -146,7 +148,7 @@ static int pty_init_child(int fd)
    if (r < 0)
        return -errno;

-   for (i = 1; i < SIGUNUSED; ++i)
+   for (i = 1; i < SIGSYS; ++i)
        signal(i, SIG_DFL);

    r = grantpt(fd);

@dreieck

Please consider adding cmake to makedepends as cmake is run withing the PKGBUILD itself.

Fails to build for me:

[ 43%] Building C object CMakeFiles/tsm.dir/libtsm/src/shared/shl-pty.c.o
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c: In function ‘pty_init_child’:
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:149:25: error: ‘SIGUNUSED’ undeclared (first use in this function)
  149 |         for (i = 1; i < SIGUNUSED; ++i)
      |                         ^~~~~~~~~
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:149:25: note: each undeclared identifier is reported only once for each function it appears in
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:152:13: warning: implicit declaration of function ‘grantpt’ [-Wimplicit-function-declaration]
  152 |         r = grantpt(fd);
      |             ^~~~~~~
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:156:13: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
  156 |         r = unlockpt(fd);
      |             ^~~~~~~~
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:160:22: warning: implicit declaration of function ‘ptsname’; did you mean ‘ttyname’? [-Wimplicit-function-declaration]
  160 |         slave_name = ptsname(fd);
      |                      ^~~~~~~
      |                      ttyname
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:160:20: warning: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  160 |         slave_name = ptsname(fd);
      |                    ^
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c: In function ‘shl_pty_open’:
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:210:14: warning: implicit declaration of function ‘posix_openpt’ [-Wimplicit-function-declaration]
  210 |         fd = posix_openpt(O_RDWR | O_NOCTTY | O_CLOEXEC | O_NONBLOCK);
      |              ^~~~~~~~~~~~
/[...]/termistor-git/src/termistor/libtsm/src/shared/shl-pty.c:214:13: warning: implicit declaration of function ‘pipe2’; did you mean ‘pipe’? [-Wimplicit-function-declaration]
  214 |         r = pipe2(comm, O_CLOEXEC);
      |             ^~~~~
      |             pipe
make[2]: *** [CMakeFiles/tsm.dir/build.make:188: CMakeFiles/tsm.dir/libtsm/src/shared/shl-pty.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:114: CMakeFiles/tsm.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Please add termistor to the provides and conflicts arrays.

Thanks for maintaining!