@Paragoumba It still appears that version 2.0.9-1
doesn't have my fix for pamac
users yet.
Let me know if you need another rebase.
Git Clone URL: | https://aur.archlinux.org/vdhcoapp-bin.git (read-only, click to copy) |
---|---|
Package Base: | vdhcoapp-bin |
Description: | Companion application for Video DownloadHelper browser add-on, precompiled binary version |
Upstream URL: | https://github.com/aclap-dev/vdhcoapp |
Licenses: | GPL2 |
Conflicts: | vdhcoapp |
Provides: | vdhcoapp |
Submitter: | leledumbo |
Maintainer: | Paragoumba |
Last Packager: | Paragoumba |
Votes: | 46 |
Popularity: | 1.38 |
First Submitted: | 2018-06-28 06:41 (UTC) |
Last Updated: | 2023-12-01 19:33 (UTC) |
@Paragoumba It still appears that version 2.0.9-1
doesn't have my fix for pamac
users yet.
Let me know if you need another rebase.
@korimitsu: The following error indicates that my latest fixes for pamac
users were not yet applied to the released package:
sudo: unknown user /usr/bin/vdhcoapp
To fix this manually, run the following as your desktop user:
/opt/vdhcoapp/vdhcoapp install --user
@Paragoumba : I have rebased the previous fix for this user post-install hook issue with pamac
:
After rebasing that bugfix branch on top of latest master
branch, I force pushed it back up to my GitLab fork. As such, if you had previously checked out the fix-pamac-user-hook
branch, the history has diverged since the last snapshot (2023-10-12). In that case, just delete the local branch before checking out the new version of this branch. (e.g.: git branch -D fix-pamac-user-hook
)
Until ArchLinux allows for Merge-Requests officially on their GitLab, the manual instructions otherwise remain the same:
# If remote not already added
git remote add trinitronx https://gitlab.archlinux.org/trinitronx/vdhcoapp-bin.git
git fetch trinitronx fix-pamac-user-hook
git checkout -b fix-pamac-user-hook trinitronx/fix-pamac-user-hook
git checkout master
git merge fix-pamac-user-hook
Error (maybe pamac?):
==> Cleaning up...
Checking keyring... [3/3]
Checking integrity... [3/3]
Loading packages files... [3/3]
Checking file conflicts... [3/3]
Checking available disk space... [3/3]
Upgrading google-chrome (118.0.5993.70-1 -> 118.0.5993.88-1)... [1/3]
Upgrading vdhcoapp-bin (2.0.2-1 -> 2.0.3-2)... [2/3]
Upgrading brave-beta-bin (1.60.89-1 -> 1.60.95-1)... [3/3]
ldconfig: File /usr/lib/libxfconf-0.so is empty, not checked.
ldconfig: File /usr/lib/libxfconf-0.so.3.0.0 is empty, not checked.
ldconfig: file /usr/lib/libnode.so is truncated
ldconfig: File /usr/lib/libxfconf-0.so.3 is empty, not checked.
ldconfig: file /usr/lib/libnode.so.115 is truncated
Running post-transaction hooks...
Arming ConditionNeedsUpdate... [1/5]
Updating icon theme caches... [2/5]
Updating the desktop file MIME type cache... [3/5]
Installing JSON configuration file ... [4/5]
VdhCoApp : VdhCoApp is ready to be used
Installing JSON configuration file for current user ... [5/5]
sudo: unknown user /usr/bin/vdhcoapp
sudo: error initializing audit plugin sudoers_audit
Error: command failed to execute correctly
Transaction successfully finishe
Until maintainer fix the pkgrel, you should clean the cache before installing the package yay -Scc
@Paragoumba I believe you should increment the pkgrel variable in PKGBUILD to force an update
It still fails to pass the validity check for me
I updated the sum, the issue should be fixed
PKGBUILD has
+sha256sums=('89444b3672573a64cb748774164474226bbc25c342f1324720d5cf8f2b4e5fdc'
deb (https://github.com/aclap-dev/vdhcoapp/releases/download/v2.0.3/vdhcoapp-2.0.3-linux-x86_64.deb) has
$ sha256sum vdhcoapp-2.0.3-linux-x86_64.deb
bd288efbd562aa450b3b142b9ad1221b83a4ea510eb840ef3f5a3c499bbb6471 vdhcoapp-2.0.3-linux-x86_64.deb
Work-around until maintainer resolves this issue:
$ makepkg -g
==> Retrieving sources...
-> Found vdhcoapp-2.0.3-linux-x86_64.deb
-> Found vdhcoapp-install.hook
-> Found vdhcoapp-remove.hook
-> Found vdhcoapp-user-install.hook
-> Found vdhcoapp-user-remove.hook
==> Generating checksums for source files...
sha256sums=('bd288efbd562aa450b3b142b9ad1221b83a4ea510eb840ef3f5a3c499bbb6471'
'a2b56e6ae3f7f8933e20762baa90e69f63f0802b2e6d213b51e0bc68843e5d27'
'3287859986d67e15e269965676bf9c75d1e853ea0ec97695811072fb8f10a7a8'
'a74a57aac6b2e76ded9524599d3047486f9f2d8f820c5114ad41209c8117ab35'
'fddf971ed2d6d976cd6ce34f9f04c9c2d18c03112eccda44ccf887cda0344b7c')
vdhcoapp-2.0.3-linux-x86_64.deb is failing sha256 check:
==> Validating source files with sha256sums... vdhcoapp-2.0.3-linux-x86_64.deb ... FAILED vdhcoapp-install.hook ... Passed vdhcoapp-remove.hook ... Passed vdhcoapp-user-install.hook ... Passed vdhcoapp-user-remove.hook ... Passed ==> ERROR: One or more files did not pass the validity check!
Thank you @trinitronx for looking into these issues, I have merged your commits!
@Paragoumba: Happy this helped to get things into a better working state. I just noticed and fixed one other small issue due to an oversight on my part for users who run pacman
frontends such as pamac
.
A few users of Manjaro reported that the post-install hook didn't seem to run for them when using pamac
. It turns out that SUDO_USER
is not set in this case because pamac
uses PolicyKit via pkttyagent
to authenticate & escalate privileges. Symptoms of this can be seen in /var/log/pacman.log
and looks like:
[2023-10-12T13:06:11-0600] [ALPM-SCRIPTLET] sudo: unknown user /usr/bin/vdhcoapp
[2023-10-12T13:06:11-0600] [ALPM-SCRIPTLET] sudo: error initializing audit plugin sudoers_audit
Unfortunately in this case, there is no equivalent polkit
environment variable for determining the user installing the package. (If anyone knows more, let me know if I'm missing some hidden method for finding this in a libalpm
hook. env
did not print any useful variables in the hook's runtime environment when I tested it.)
So, in this case, perhaps the sane default would be to fallback on uid 1000
given that most people using vdhcoapp-bin
are going to be single-user desktop users rather than one of many multi-user seats.
I pushed a bugfix branch up here: trinitronx/vdhcoapp-bin#3 Feel free to review the changes
To pull & merge:
# If remote not already added
git remote add trinitronx https://gitlab.archlinux.org/trinitronx/vdhcoapp-bin.git
git fetch trinitronx fix-pamac-user-hook
git checkout -b fix-pamac-user-hook trinitronx/fix-pamac-user-hook
git checkout master
git merge fix-pamac-user-hook
Pinned Comments
Paragoumba commented on 2021-12-27 23:19 (UTC) (edited on 2023-09-28 21:07 (UTC) by Paragoumba)
@dreieck I have updated the package to not bundle ffmpeg anymore following this upstream issue. Vdhcoapp can only use the local ffmpeg because its path is hardcoded. The package uses symlinks for now and I am waiting for Vdhcoapp to properly support using the system's ffmpeg.
I also added the
provides
andconflicts
variables.Thanks for your suggestions