Was the issue already reported to upstream? That isn't a packaging issue.
Search Criteria
Package Details: vesktop 1.5.4-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/vesktop.git (read-only, click to copy) |
---|---|
Package Base: | vesktop |
Description: | A standalone Electron-based Discord app with Vencord & improved Linux support |
Upstream URL: | https://github.com/Vencord/Vesktop |
Keywords: | discord vencord vesktop |
Licenses: | GPL-3.0-only |
Conflicts: | vesktop |
Provides: | vesktop |
Submitter: | picokan |
Maintainer: | Edu4rdSHL (Covkie, zt64) |
Last Packager: | Covkie |
Votes: | 44 |
Popularity: | 8.22 |
First Submitted: | 2024-01-16 08:05 (UTC) |
Last Updated: | 2024-12-06 03:32 (UTC) |
Dependencies (6)
- alsa-lib
- gtk3 (gtk3-no_deadkeys_underlineAUR, gtk3-classic-xfceAUR, gtk3-patched-filechooser-icon-viewAUR, gtk3-classicAUR)
- nss (nss-hgAUR)
- nodejs (nodejs-gitAUR, python-nodejs-wheelAUR, nodejs-lts-hydrogen, nodejs-lts-iron, nodejs-lts-jod) (make)
- libnotify (libnotify-gitAUR) (optional) – Notifications
- xdg-utils (busking-gitAUR, xdg-utils-slockAUR, mimiAUR, mimi-gitAUR, xdg-utils-handlrAUR, openerAUR, xdg-utils-mimeoAUR, mimejs-gitAUR) (optional) – Open links, files, etc
Required by (3)
Sources (4)
Latest Comments
« First ‹ Previous 1 2 3 4 5 6 7 .. 10 Next › Last »
Edu4rdSHL commented on 2024-06-26 18:29 (UTC)
JavAngle commented on 2024-06-21 07:36 (UTC)
I have been having the exact same issue as XcroatoanX
XcroatoanX commented on 2024-06-20 20:40 (UTC) (edited on 2024-06-20 20:43 (UTC) by XcroatoanX)
Hey! Unfortunately, Screen Sharing stopped working, and started giving me this error
(node:20896) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag
--unhandled-rejections=strict
(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 11)
ISSOtm commented on 2024-06-19 16:09 (UTC)
code
depends on electron29
, for example. I am quite sure that discord
depends on its bundled Electron because of a distribution agreement between Discord and Arch, since they are quite anal about "do not modify our app". (Also I heard something about them using a customised Electron, but I don't have a source for that :P)
So I would argue that in the official repos, discord
is an exception, not the rule.
I understand if you are fed up with the issues caused by using a non-bundled Electron, and I respect the time and effort that you put as a maintainer into servicing this package. Nevertheless, I think that it is a reasonable option to ask for help, such as passing control of the package, or more reasonably I think, adding a co-maintainer who is willing to go through that hassle. Splitting the pain, if you will. (I have set up my PKGBUILDs in a GitHub repo to simplify such cooperation. It's worked nicely for me thus far.)
(Side note: the AUR isn't great for announcing (co-)maintainership requests? Short of a pinned comment with an email address, I'm not sure much can be done?)
Edu4rdSHL commented on 2024-06-19 15:04 (UTC) (edited on 2024-06-19 15:07 (UTC) by Edu4rdSHL)
You seem not to understand, it isn't about "someone who won't have those issues" because the issues were just there, regardless of who package it, these issues were going to be there. And yes, you discuss the "guidelines" except that every package on official repos just packages electron apps the same way that this package does to avoid these problems, and I don't see anything wrong with it: it basically uses whatever upstream wants to use, no matter if that version is on the repos or not.
If the excuse is "but we will have a copy of electron...", then it's a nonsense.
So, good luck using vesktop_electron
, let's move on.
Edit: I just checked vesktop_electron
and it's experiencing the same issues that I experienced months ago (because it isn't about who packaged it) right now, while we haven't had any issues since the new packaging format, so even less reasons to even reconsider that.
picokan commented on 2024-06-19 14:41 (UTC) (edited on 2024-06-19 14:42 (UTC) by picokan)
I saw these issues with using the system's electron and that, along with my previous experience with trying to you have you understand the arch packaging guidelines for electron apps, has me hoping you'll yield the maintainer role to someone who won't have those issues, or at least will handle them more gracefuly. But again, for now the vesktop_electron package is what I wanted this package to be.
Edu4rdSHL commented on 2024-06-19 01:47 (UTC)
I'm not going to revert it, feel free to use something else.
I have had sufficient issues when I tried to maintain the package using the system's electron.
ISSOtm commented on 2024-06-18 17:36 (UTC)
Clearly, there's significant disagreement about "properly". (In summary: using bundled Electron goes against much of the spirit and benefits of the AUR outside of explicit -bin
packages, and causes some breakage if only minor.)
I'd like to point out that vesktop_electron
upgraded to Electron 31, which caused some breakage, and soon after reverted to Electron 30.
I wish this package had done the same during the original breakage, much digital ink would not have been spilled. I don't think it's too late to revert the change, either. I think everyone would be happy, and quickly move on.
Edu4rdSHL commented on 2024-06-17 20:55 (UTC)
picokan, it's just being packaged properly, like any of the packages on the official repos are. There's no need to apologize for something that was done right. Cheers
picokan commented on 2024-06-17 20:46 (UTC) (edited on 2024-06-17 20:47 (UTC) by picokan)
I want to apologise to all the people that have had problems with the handling of this package. I should've known better than to give away the maintainer role to the first person that asked. If it's any consolation, I haven't had any problems with the vesktop_electron package.
Pinned Comments
Edu4rdSHL commented on 2024-09-17 03:25 (UTC) (edited on 2024-10-27 20:33 (UTC) by Edu4rdSHL)
As of 2024-09-16, this package is being co-maintained by official vesktop developers, and any packaging decisions they make will not be questioned on my part unless it's something harmful for the users, which is very unlikely to happen. As I see it coming, they will not use the system's electron on this package purposely, if you don't like it, use
vesktop-electron
, which is also maintained by the same devs.Thanks!