You all complain-bombed the maintainer and got what you asked for – electron downgrade. Accept the consequences.
Search Criteria
Package Details: vesktop 1.5.2-3
Package Actions
Git Clone URL: | https://aur.archlinux.org/vesktop.git (read-only, click to copy) |
---|---|
Package Base: | vesktop |
Description: | Vesktop gives you the performance of web Discord and the comfort of Discord Desktop |
Upstream URL: | https://github.com/Vencord/Vesktop |
Keywords: | discord vencord vesktop |
Licenses: | GPL3 |
Conflicts: | vesktop-bin |
Submitter: | picokan |
Maintainer: | Edu4rdSHL |
Last Packager: | Edu4rdSHL |
Votes: | 13 |
Popularity: | 7.87 |
First Submitted: | 2024-01-16 08:05 (UTC) |
Last Updated: | 2024-05-09 03:11 (UTC) |
Dependencies (5)
- pnpm (corepackerAUR, yarn-pnpm-corepackAUR) (make)
- arrpcAUR (arrpc-gitAUR) (optional) – Rich presence support
- libnotify (libnotify-gitAUR) (optional) – Notifications
- xdg-desktop-portal (xdg-desktop-portal-gitAUR) (optional) – Screensharing with Wayland
- xdg-utils (busking-gitAUR, xdg-utils-slockAUR, mimiAUR, mimi-gitAUR, xdg-utils-handlrAUR, openerAUR, xdg-utils-betterlockscreenAUR, mimejs-gitAUR, xdg-utils-mimeoAUR) (optional) – Open links, files, etc
Required by (0)
Sources (3)
xiota commented on 2024-05-03 09:01 (UTC)
chrrybmb commented on 2024-05-03 07:50 (UTC) (edited on 2024-05-03 08:08 (UTC) by chrrybmb)
I'm not going to use “system” electron anymore on this package as it's proven to create issues
But system provided electron was not the source of the issue though, the source of the issue was electron 30. Vesktop was working just fine with the electron29
package. That's my point.
Edu4rdSHL commented on 2024-05-02 19:46 (UTC)
As I mentioned, I'm not going to use the "system" electron anymore, that's it. Feel free to create a vesktop_electron
package for that.
Regarding pnpm
I don't see how it goes against the guidelines.
ISSOtm commented on 2024-05-02 17:42 (UTC) (edited on 2024-05-02 17:43 (UTC) by ISSOtm)
Hello! First of all, thank you for taking some time to fix the breakage. I have removed the workaround I mentioned in a previous post, and no crashing thus far. :D
However, I would like to suggest depending on an explicit version of Electron, i.e. electron30
instead of electron
(in a timeline where this Wayland issue didn't exist; so electron29
in this timeline). I have the following rationale:
- This avoids having an extra copy of Electron on the system. The usual arguments about minor+patch releases also apply there.
- This also keeps the Electron behaviour consistent with Arch tweaks (such as
electron-flags.conf
) - This is indeed some more work when upgrading this package, but I think that it's a reasonable amount
Additionally, the build()
step downloads some files (via pnpm
), which goes against the PKGBUILD guidelines; I personally don't care much, but someone might later, so it's still worth considering IMO?
I am willing to donate some of my own time to patch the PKGBUILD appropriately; LMK if you'd be interested, and if your PKGBUILD is hosted on a public repo (like mine) so I could send you PRs there instead.
Edu4rdSHL commented on 2024-04-29 18:32 (UTC)
I'm not going to use “system” electron anymore on this package as it's proven to create issues. As Vendicated mentioned, if anyone wants that, feel free to create a vesktop_electron
package or something.
This package holds the “base” package name and should be as close as possible to the official build process.
chrrybmb commented on 2024-04-29 15:05 (UTC) (edited on 2024-04-29 15:29 (UTC) by chrrybmb)
Using electron29 would still "force" people who had no problems with electron30 to install multiple versions of electron.
But that's already happening with the bundled electron, so nothing will change. At least if it uses electron29
people with that package installed will get to avoid it.
If you're suggesting that this package should revert back to electron 30, I think the people having issues with it should take priority, especially since one of the devs of vesktop came here and asked the maintainer to downgrade it.
xiota commented on 2024-04-29 15:00 (UTC)
Wouldn't it be better ... won't be forced to have a second redundant installation ...
Using electron29 would still "force" people who had no problems with electron30 to install multiple versions of electron.
chrrybmb commented on 2024-04-29 14:13 (UTC) (edited on 2024-04-29 14:17 (UTC) by chrrybmb)
Wouldn't it be better to use electron29
instead of bundled electron? That way, electron 30 will not be used and people who already have electron29
installed won't be forced to have a second redundant installation of it.
Edu4rdSHL commented on 2024-04-28 18:25 (UTC) (edited on 2024-04-28 18:26 (UTC) by Edu4rdSHL)
1.5.1-2
should fix all the issues with Wayland, as it uses the bundled app's electron.
Edu4rdSHL commented on 2024-04-28 15:07 (UTC)
Hi, Vendicated. As xiota mentioned, if there had been one open issue that we can track and see the impact it's having, I would have been able to address it sooner. But as I rely solely on the electron issue, and I haven't seen many interactions there I hold it.
Now, I have checked the electron issue again, and it has a bit of more activity, I'm going to use the vesktop bundled electron for the package from now on.
Cheers.
Pinned Comments
Edu4rdSHL commented on 2024-04-19 19:11 (UTC) (edited on 2024-04-29 18:33 (UTC) by Edu4rdSHL)
I don't want to be that guy, but:
makepkg -s
, I don't care if your AUR helper doesn't work, it's a problem with your AUR helper and needs to be fixed there. Here's the build log for the latest version: https://gist.github.com/Edu4rdSHL/929a7eba81165da5166c4d0974d0e96fI can't reproduce the current electron issue with v30, and seems that only a few users are having the issue. So I don't see any reason to downgrade the electron version for everyone. Plus, Athonathonathon put a workaround for it, which seems to be related to the current Chrome breakage on Wayland setups.The Wayland issue has been fixed from
1.5.1-2
onwards.