Arch Linux User Repository

@wuestengecko Ah, that's a new one for me. So then, since this could potentially affect anyone trying to build the package without having set up a git identity (Docker or no Docker), I should probably add '--no-commit' to that cherry-pick line by default, yeah?

@wuestengecko I understand, but .gitconfig is not created on installation of git package. I just tried it in virtual machine. EDIT- I also checked my other machines, it is not there. Git was installed and no user configuration is done. Therefore I believe this will also fail regardless of Docker. Maybe the "--no-commit" clause should be there.

@raqua The issue isn't that your build environment is too dirty, it's precisely the opposite: your environment is too clean. The issue is this line in the PKGBUILD:

git cherry-pick 2fa0fbe448058f2826dadc44572a822af2a177d5

Without --no-commit, git wants to record the cherry-pick in the commit history, and it wants to do so with you as the committer. If you're building in a chroot (or Docker container - same effect), it doesn't know who you are, because why would you set up git in an ephemeral environment.

@Nocifer I am not doing anything dirty. At least I am not aware of it. All I do is

yay -Syy && yay -S pod2man zoneminder cronie apache mariadb 

I am doing it inside Docker container so it is by principle fresh install. I was using the same Dockerfile for months now, there is no change and it was building before. After I added my git contact info it builds.

@raqua You shouldn't really, if git is asking you for an email it means you're trying to access a non-public or non-existent repo. If I had to guess, I'd say you're trying to do a "dirty" update of ZM and so the cherry-picked fix is not being applied. You should instead try to do a clean update, i.e. delete your previous sources and let makepkg download them all over again.

A proper install will look like this at the point where yours failed (this is from a build I did just now):

==> Extracting sources...
  -> Creating working copy of zoneminder-git git repo...
Cloning into 'zoneminder-git'...
done.
Switched to a new branch 'makepkg'
==> Starting prepare()...
Auto-merging web/api/app/Controller/AppController.php
[makepkg 704361813] Upgrade cakephp to 2.10.24
 Author: Isaac Connor <isaac@zoneminder.com>
 Date: Tue Feb 2 11:35:03 2021 -0500
 114 files changed, 2300 insertions(+), 878 deletions(-)
 rewrite web/api/composer.json (99%)
 create mode 100644 web/api/lib/Cake/Console/Templates/skel/.htaccess
 create mode 100644 web/api/lib/Cake/Console/Templates/skel/webroot/.htaccess
 create mode 100644 web/api/lib/Cake/Controller/RequestHandlerComponent.php
 create mode 100644 web/api/lib/Cake/Test/Case/Controller/ApplicationControllerTest.php

It is failing for me with this error:

==> Making package: zoneminder 1.34.23-2 (Fri 05 Mar 2021 09:17:18 AM UTC)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Updating zoneminder-git git repo...
Fetching origin
  -> Found zoneminder-nginx.conf
  -> Found zoneminder-httpd.conf
  -> Found zoneminder-php.ini
  -> Found zoneminder.service
  -> Found zoneminder-tmpfile.conf
  -> Found fcgiwrap-multiwatch.service
  -> Found zmsetup.sh
==> Validating source files with sha256sums...
    zoneminder-git ... Skipped
    zoneminder-nginx.conf ... Passed
    zoneminder-httpd.conf ... Passed
    zoneminder-php.ini ... Passed
    zoneminder.service ... Passed
    zoneminder-tmpfile.conf ... Passed
    fcgiwrap-multiwatch.service ... Passed
    zmsetup.sh ... Passed
==> Removing existing $srcdir/ directory...
==> Extracting sources...
  -> Creating working copy of zoneminder-git git repo...
Cloning into 'zoneminder-git'...
done.
Updating files: 100% (5631/5631), done.
Switched to a new branch 'makepkg'
==> Starting prepare()...
Auto-merging web/api/app/Controller/AppController.php
Committer identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "you@example.com"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'raqua@f4db960ea7ba.(none)')
==> ERROR: A failure occurred in prepare().
    Aborting...

Why should I need to provide email?

Just pushed a new release with @compgamer89's fix included, hopefully this will be the last of our woes with 1.34 until 1.35/1.36 is released.

@AlphaJack I just built the package, both with and without the cherry-pick, so your issue must be due to something else on your end.

I am unable to compile:

[...]

[ 60%] Linking CXX static library libzm.a
[ 60%] Built target zm
make: *** [Makefile:171: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

[...]

Line 171 of Makefile is this one:

 $(MAKE) $(MAKESILENT) -f CMakeFiles/Makefile2 all

@compgamer89 thanks mate, worked a charm.

@alanking Possibly easier fix, as an edit to PKGBUILD:

diff --git a/PKGBUILD b/PKGBUILD
index b993bc9..35898a8 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -97,6 +97,9 @@ sha256sums=('SKIP'

 prepare () {
     cd $pkgname-git
+
+    # Update cake
+    git cherry-pick 2fa0fbe448058f2826dadc44572a822af2a177d5

     # Download and move extra PHP plugins into place
     git submodule update --init --recursive

Relevant commit: https://github.com/ZoneMinder/zoneminder/commit/2fa0fbe448058f2826dadc44572a822af2a177d5