Package Details: arc-gtk-theme-git 20220405.r43.ga76102bb-1

Git Clone URL: https://aur.archlinux.org/arc-gtk-theme-git.git (read-only, click to copy)
Package Base: arc-gtk-theme-git
Description: A flat theme suite with transparent elements.
Upstream URL: https://github.com/jnsh/arc-theme
Licenses: GPL3
Conflicts: arc-gtk-theme
Submitter: NicoHood
Maintainer: Noeljunior (ooo)
Last Packager: ooo
Votes: 237
Popularity: 0.000000
First Submitted: 2018-03-25 19:17 (UTC)
Last Updated: 2024-03-02 03:50 (UTC)

Dependencies (6)

Required by (0)

Sources (1)

Latest Comments

« First ‹ Previous 1 .. 8 9 10 11 12 13

ebilgenius commented on 2015-05-29 23:46 (UTC)

@edh Thanks again! How does it look now?

edh commented on 2015-05-29 22:36 (UTC)

Makepkg produces an error concerning your build function, due to being unable to enter the directory of the source. This also is noticable when looking at the source at the AUR web interface. Your source should look something like this: source=($pkgname::'git+https://github.com/horst3180/Arc-theme.git') (notice the new placement of the quotation marks) Putting the ' infront of $pkgname means that everything in between is the source, however you intended the :: as seperators meaning that everything after :: should be cloned into $pkgname.

edh commented on 2015-05-21 19:10 (UTC)

@ebilgenius No problem! I hope I was not to intrusive and I wish you best of luck for you future roll as maintainer.

ebilgenius commented on 2015-05-21 17:58 (UTC)

@edh Thank you for your suggestions! As is probably very obvious I'm new to Arch and the AUR so some guidance is always welcome. I've implemented your suggestions into a new package and am waiting for this one to be merged: https://aur.archlinux.org/packages/gtk-theme-arc-git/ Let me know if you have any more suggestions or guidance!

edh commented on 2015-05-21 16:02 (UTC)

Dear ebilgenius, nice to see someone who adds a theme to the AUR, however you made some rookie mistakes: - bash can be assumed to be on the system since the AUR should only be used if base and base-devel package-group are both installed therefore it is bad practise to add them eitherway - you package has no source although git is supported by makepkg - the pkgver should be related to the repo, e.g. the number of commits to one branch plus the last shortened hash of the previous commit - do not simply use "cp -r" instead prefer "cp -dpr --no-preserve=ownership" - subjective, me nagging: avoid using find - subjective, me nagging: indicate what your package is in the package name: e.g. call the package gtk-theme-arc-git It was not my intention to insult you, therefore I tried to rewrite the PKGBUILD to show my esteem: # Maintainer: zach <zach {at} zach-adams {dot} com> # Contributor: Gordian Edenhofer <gordian.edenhofer[at]yahoo[dot]de pkgname=gtk-theme-arc-git _pkgname=Arc pkgver=22.f4c0094 pkgrel=1 pkgdesc="A flat theme with transparent elements for GTK 3, GTK 2 and Gnome-Shell." arch=('any') url="https://github.com/horst3180/Arc-theme" license=('GPL3') depends=('gtk3') makedepends=('git') source=(${_pkgname}::'git+https://github.com/horst3180/Arc-theme.git') sha256sums=('SKIP') pkgver() { cd "${srcdir}/${_pkgname}" echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD) } package() { cd "${srcdir}/${_pkgname}" install -dm755 "${pkgdir}/usr/share/themes/${_pkgname}" rm -rf {.git,COPYING,README.md} cp -dpr --no-preserve=ownership . "${pkgdir}/usr/share/themes/${_pkgname}/" }