Package Details: brave-bin 1:1.25.73-2

Git Clone URL: https://aur.archlinux.org/brave-bin.git (read-only, click to copy)
Package Base: brave-bin
Description: Web browser that blocks ads and trackers by default (binary release).
Upstream URL: https://brave.com/download
Keywords: brave browser
Licenses: BSD, MPL2, custom:chromium
Conflicts: brave
Provides: brave, brave-browser
Submitter: vorbote
Maintainer: mixedCase
Last Packager: mixedCase
Votes: 412
Popularity: 28.81
First Submitted: 2016-04-06 13:16
Last Updated: 2021-06-17 14:45

Dependencies (8)

Required by (2)

Sources (4)

Pinned Comments

mixedCase commented on 2019-03-11 13:52

=== PLEASE READ PLEASE READ BEFORE REPORTING OUT OF DATE ===

Before making your report, please note that the newer GitHub release you're looking at belongs to the "Release Channel" and --isn't marked as prerelease--.

I have a cron running that's checking every 30 minutes if there's a new release and sends me an email if so. If you see the release was tagged in the last couple of hours please give it some time before flagging.

Also please take into account a stable version may be "released" on GitHub but not marked as ready (read, NOT PRELEASE) for a long time.

Another handy tool to check latest OFFICIALLY MARKED AS STABLE version of Brave is to run:

curl https://brave-browser-downloads.s3.brave.com/latest/release.version

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 11 ... Next › Last »

rageltman commented on 2020-11-24 17:57

The sandbox binary doesn't have the correct permissions set. Need to chmod 4755 $pkgdir/usr/lib/brave-bin/chrome-sandbox in the package() call or the bug prevents launching the browser at all (at least under firejail):

[6:6:1124/122723.010065:FATAL:setuid_sandbox_host.cc(158)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /usr/lib/brave-bin/chrome-sandbox is owned by root and has mode 4755.

mixedCase commented on 2020-11-18 18:14

@kiankasad Applied. Thanks

kiankasad commented on 2020-11-18 18:06

@mixedCase I figured out why. makepkg doesn't put the extracted files in a subdirectory. Anyways, here's a patch to remove the useless cat:

diff --git a/PKGBUILD b/PKGBUILD
index 429d407..3f76b95 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -35,7 +35,7 @@ noextract=("$pkgname-$pkgver.zip")

 prepare() {
   mkdir -p brave
-  cat $pkgname-$pkgver.zip | bsdtar -xf- -C brave
+  bsdtar -xf $pkgname-$pkgver.zip -C brave
   chmod +x brave/brave
 }

mixedCase commented on 2020-11-18 17:42

@kiankasad original maintainer set it up that way and it works. Changing it means changing directory structure and me having to lookup manpages, but it isn't an issue so I don't care about it.

Patches welcome if it bothers you enough.

kiankasad commented on 2020-11-18 17:35

The prepare function is slightly confusing:

prepare() {
  mkdir -p brave
  cat $pkgname-$pkgver.zip | bsdtar -xf- -C brave
  chmod +x brave/brave
}

Why cat the archive into bsdtar instead of using bsdtar -xf $pkgname-$pkgver.zip -C brave? Why extract the archive this way at all? Can't makepkg do that automatically after downloading?

mixedCase commented on 2020-11-18 14:43

@eronis55 libnotify integration is working fine here. Just added it to optdepends to make it clear that you need to have libnotify.

Other than that, I don't use Brave rewards so I need feedback by users who do to see what kind of errors they're seeing in their terminal when running Brave from it.

eronis55 commented on 2020-11-18 13:17

Brave Rewards function has a problem with your package. It may be that you need to add some new dependencies or something like that.

https://community.brave.com/t/brave-does-not-show-any-notifications-on-arch-linux/177664/7

mixedCase commented on 2020-10-13 00:03

@kiankasad Pushed a fix for this and removing an obsolete workaround. Thanks for the report and collaboration! Please let me know if you have any issues.

kiankasad commented on 2020-10-12 23:51

@mixedCase I think that'll work. As far as I can tell, this pseudocode covers all use cases:

if CONFIG_USER_NS=y:
   if kernel.unprivileged_userns_clone=0:
      --no-sandbox
else:
   --no-sandbox

mixedCase commented on 2020-10-12 23:46

@kiankasad Well what I'm seeing is that user namespaces do seem to be enabled by default on Arch. But the kernel parameter is still a thing and it seems to be a way to disable them, which linux-hardened uses and I imagine some users do as well.

Can you confirm you're using a kernel without Arch patches? I can change the script to simply run --no-sandbox if the kernel param exists and is set to 0, I gather that should do it without breaking users of the kernel param.