Package Details: brave-bin 1:1.74.51-1

Git Clone URL: https://aur.archlinux.org/brave-bin.git (read-only, click to copy)
Package Base: brave-bin
Description: Web browser that blocks ads and trackers by default (binary release)
Upstream URL: https://brave.com
Keywords: brave browser
Licenses: BSD, MPL2, custom:chromium
Conflicts: brave
Provides: brave, brave-browser
Submitter: toropisco
Maintainer: alerque (alosarjos)
Last Packager: alosarjos
Votes: 840
Popularity: 19.45
First Submitted: 2016-04-06 13:16 (UTC)
Last Updated: 2025-01-29 17:53 (UTC)

Dependencies (8)

Required by (10)

Sources (4)

Pinned Comments

alerque commented on 2021-11-27 03:11 (UTC)

@ant0n et all, lets keep the comments here about packaging issues, general Brave usage issues should go in another forum to not clutter up this comment space. I'm deleting comments that have no relation to packaging. Grey areas like crashes that could be blamed on Arch can stay until proven otherwise, but things like how to configure Brave to handle popups or site X or whatever just don't belong here. Thanks for understanding.

Latest Comments

« First ‹ Previous 1 .. 10 11 12 13 14 15 16 17 18 19 20 .. 59 Next › Last »

Spixmaster commented on 2022-05-31 16:00 (UTC) (edited on 2022-05-31 16:00 (UTC) by Spixmaster)

@wknampik is right, @alosarjos. Shebangs exist exactly for this reason to specify the needed shell interpreter. Besides, Bash is a dependency of base. Everybody has Bash.

wknapik commented on 2022-05-30 18:08 (UTC)

@alosarjos bash is a dependency of multiple packages in base-devel, so it's guaranteed to be available. The shebang at the top of brave-bin.sh selects bash as the interpreter, so we're all set. I use zsh myself and this works fine for me.

alosarjos commented on 2022-05-30 14:21 (UTC)

@wknapik I see... The problem there is that bash is not mandatory as default shell, people may be using ZSH, so i tried there the mapfile, and doesn't recognize it, so I can't put that on the AUR script...

wknapik commented on 2022-05-30 10:45 (UTC)

@alosarjos mapfile is a bash builtin that reads lines into an indexed array (see: man bash).

Quotes around a regular variable prevent expansion, but also make the whole value a single commandline argument. Quotes around an array prevent expansion, but each element is quoted separately, which is what we want here.

Please run shellcheck against brave-bin.sh before and after applying the patch to see that this fixes a generic problem.

alosarjos commented on 2022-05-30 09:57 (UTC)

@PQCraft This is the pre-built binaries by Brave. If you think there is an issue with build options I suggest you ask them on their Github repository.

PQCraft commented on 2022-05-30 08:02 (UTC) (edited on 2022-05-30 08:03 (UTC) by PQCraft)

Hi, I have been experiencing a lot of issues where tabs randomly crash with SIGILL. I wonder if this has to do with the build options. Is this being built for generic x86_64?

alosarjos commented on 2022-05-30 06:52 (UTC)

@wknapik Thanks for the patch. But I'm not sure it's correct? What is this mapfile you are adding to it?

wknapik commented on 2022-05-28 00:35 (UTC)

The script that gets installed as /usr/bin/brave (https://aur.archlinux.org/cgit/aur.git/tree/brave-bin.sh?h=brave-bin) doesn't quote the extra arguments from brave-flags.conf, which means they get expanded by the shell. So, for instance, if you put "*" in your brave-flags.conf, it will cause all files from the working directory to be opened when brave is started.

Here's a patch to address this:

diff --git a/brave-bin.sh b/brave-bin.sh
index 293a314..0e657ed 100644
--- a/brave-bin.sh
+++ b/brave-bin.sh
@@ -3,10 +3,10 @@ XDG_CONFIG_HOME="${XDG_CONFIG_HOME:-$HOME/.config}"

 # Allow users to override command-line options
 USER_FLAGS_FILE="$XDG_CONFIG_HOME/brave-flags.conf"
-if [[ -f $USER_FLAGS_FILE ]]; then
-   USER_FLAGS="$(cat $USER_FLAGS_FILE | sed 's/#.*//')"
+if [[ -f "$USER_FLAGS_FILE" ]]; then
+   mapfile -t USER_FLAGS < <(sed 's/#.*//g' "$USER_FLAGS_FILE")
 fi

 export CHROME_VERSION_EXTRA="stable"

-exec /usr/lib/brave-bin/brave "$@" $USER_FLAGS
+exec /usr/lib/brave-bin/brave "$@" "${USER_FLAGS[@]}"

octopus4003 commented on 2022-05-13 16:17 (UTC) (edited on 2022-05-14 04:13 (UTC) by octopus4003)

Brave keeps freezing the whole system, it's random and I don't think its due to high cpu usage or RAM either. Sometimes I'm able to use terminal to end it or go to TTY, otherwise I need to do a full reboot because it's fully frozen.

Seems like it's happening due to having hardware-acceleration enabled. Disabling it fixed for me.

alosarjos commented on 2022-05-11 19:50 (UTC)

@itsKia2 No problem. I appreciate people notifying me about the package being outdated. But lately I've been getting multiple false reports.

You can try the Curl method, or check if they updated the CHANGELOG file. Or check the status on the release checklist: https://github.com/brave/brave-browser/issues/22786

« First ‹ Previous 1 .. 10 11 12 13 14 15 16 17 18 19 20 .. 59 Next › Last »