Package Details: corectrl-git 1.4.0.r47.g0bbf5ad-1

Git Clone URL: https://aur.archlinux.org/corectrl-git.git (read-only, click to copy)
Package Base: corectrl-git
Description: Application to control your hardware with ease using application profiles
Upstream URL: https://gitlab.com/corectrl/corectrl
Keywords: cpu gpu monitoring overclocking
Licenses: GPL-3.0-or-later
Conflicts: corectrl
Provides: corectrl
Submitter: murlakatamenka
Maintainer: guzzisti
Last Packager: guzzisti
Votes: 7
Popularity: 0.147878
First Submitted: 2019-07-15 22:13 (UTC)
Last Updated: 2025-02-05 18:22 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 Next › Last »

kogasa commented on 2023-10-23 04:23 (UTC)

Hi @HurricanePootis, thanks for the suggestions. I've added most of them. The -ffile-prefix-map was originally added to address an issue with referencing the $srcdir in the final binary, but it doesn't seem to be working anymore-- I've left it in for now, but I'll revisit it shortly.

HurricanePootis commented on 2023-10-23 03:28 (UTC)

Hey, I have some recommendations for this package.

First off, this package is installing stuff into /usr/libexec, which no other arch package on my system does. If you take a look at corectrl's PKGBUILD, they use a cmake flag to just set that to /usr/lib. While also there, there is no mention of a -ffile-prefix-maps, so I think that should be removed too.

Secondly, you are not using tags in your git describe command, which is giving a out-of-date pkgver function.

Here is a patch file of all my recommended changes. Use all of them or some of them.

diff --git a/PKGBUILD b/PKGBUILD
index d65bace..e45918c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,7 +4,7 @@

 _pkgname=corectrl
 pkgname=${_pkgname}-git
-pkgver=1.2.0.r174.gf2f6b8c
+pkgver=1.3.0.r73.gc768234
 pkgrel=1
 pkgdesc="Application to control your hardware with ease using application profiles"
 url="https://gitlab.com/corectrl/corectrl"
@@ -24,19 +24,26 @@ md5sums=('SKIP')

 pkgver() {
     cd "$srcdir/$_pkgname"
-    git describe --long | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
+    git describe --long --tags --abbrev=7 | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
 }

 build() {
-  cd "$srcdir/$_pkgname"
-  CXXFLAGS="${CXXFLAGS} -ffile-prefix-map=${srcdir}/=/"
-  export CXXFLAGS
-  cmake -B build -DCMAKE_INSTALL_PREFIX='/usr' -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF
+  cd "$srcdir/"
+
+
+  cmake -B build \
+  -S $_pkgname \
+  -DCMAKE_INSTALL_PREFIX='/usr' \
+  -DCMAKE_BUILD_TYPE=Release \
+  -DCMAKE_INSTALL_LIBDIR="lib" \
+  -DCMAKE_INSTALL_LIBEXECDIR="lib" \
+  -DBUILD_TESTING=OFF
+
   cmake --build build
 }

 package() {
-  cd "$srcdir/$_pkgname/build"
-  DESTDIR="$pkgdir" cmake --build . --target install
+  cd "$srcdir/"
+  DESTDIR="$pkgdir" cmake --install build
 }

jpalaciosdev commented on 2023-10-16 16:07 (UTC)

Hi,

Now you can also use Botan version 3 (botan package on arch repos) with corectrl. When both botan and botan2 packages are installed in the system, botan will take precedence over botan2.

saitoRS commented on 2023-09-10 19:06 (UTC)

@kogasa I apologize, I completely forgot to try a clean build before posting my previous comment. Works as intended now. Thanks for your work!

kogasa commented on 2023-09-06 02:53 (UTC)

@saitoRS could you please provide more info? I'm able to build locally and in a chroot with fmt 10.1.

saitoRS commented on 2023-09-05 15:27 (UTC)

Not working with current version of fmt. Had to manually downgrade it to fmt-9.1.0-4.

Patola commented on 2023-05-06 05:55 (UTC)

it's generating packages which include files in /tmp, e.g. [7:54] [5299] [patola@risadinha corectrl-git]% pacman -Qlp corectrl-git-1.2.0.r170.g6ce3a81-1-x86_64.pkg.tar.zst | grep tmp | grep helper corectrl-git /tmp/corectrl-git/pkg/corectrl-git/usr/libexec/corectrl/corectrl_helper corectrl-git /tmp/corectrl-git/pkg/corectrl-git/usr/libexec/corectrl/corectrl_helperkiller

jpalaciosdev commented on 2022-07-17 12:40 (UTC) (edited on 2022-07-24 08:46 (UTC) by jpalaciosdev)

Hi,

Dependencies have changed:

  • kauth and karchive are no longer needed.
  • quazip-qt5, polkit and dbus are now required.

Plus, qt5-xmlpatterns was never needed so I think it's safe to also remove it.

murlakatamenka commented on 2022-01-23 12:42 (UTC)

Sorry it took so long to update stuff :(

I'm not using CoreCtrl for a long time already, so I'm disowning the package and volunteers can adopt it and carry the flame.

« First ‹ Previous 1 2 3 Next › Last »