Arch Linux User Repository

Hi! It's been already one month and 10 days since version 0.68 released. Is there any intention on updating the package by the current maintainer (randomnobody)?

Since recently I am unable to build this due to "Error prone negation: negation is executed before relational operator" on line 313 in CorisxTH/Lua/world.lua during Lua check phase.

Here's the patch I made to fix the issue, hope it helps someone!

--- world.lua.orig      2023-06-19 14:45:48.891587391 +0200
+++ world.lua.mod       2023-06-19 14:46:18.244980721 +0200
@@ -310,7 +310,7 @@
       end
     end
   end
-  if #self.available_diseases == 0 and not self.map.level_number == "MAP EDITOR" then
+  if #self.available_diseases == 0 and self.map.level_number ~= "MAP EDITOR" then
     -- No diseases are needed if we're actually in the map editor!
     print("Warning: This level does not contain any diseases")
   end

@TheCycoONE I had a hunch it might be connected to the recent major release of FFmpeg, but wasn't certain. I also had the ffmpeg4.4 package installed but it would still error out.

This package still breaks upon build, as it is still pulling in 0.64 but I also just tested it with the corsix-th-git package and it compiled like a charm! Thanks for the quick fix :D

https://github.com/CorsixTH/CorsixTH/commit/95be4c96810818d05b668c373711cd8f38d4e8b4

The patch is now upstream ^

I see ffmpeg 5.0 was just released with API breaking changes. ArchLinux is carrying an ffmpeg 4.4 package (https://archlinux.org/packages/extra/x86_64/ffmpeg4.4/) which probably works better until we can incorporate the required changes.

@SebinNyshkim I haven't seen that yet, but if this is a problem with the latest ffmpeg I'll have it patched soon in git.

In the mean time you should be able to add -DWITH_MOVIES=off to the cmake line to get it to build - without cinematics of course.

The package doesn't build anymore (and FWIW neither does the corsix-th-git package)

It aborts at around this step:

/home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.cpp: In member function 'bool movie_player::load(const char*)':
/home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.cpp:434:52: error: invalid conversion from 'AVCodec**' to 'const AVCodec**' [-fpermissive]
  434 |                                            -1, -1, &m_pVideoCodec, 0);
      |                                                    ^~~~~~~~~~~~~~
      |                                                    |
      |                                                    AVCodec**
In file included from /home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.h:46,
                 from /home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.cpp:23:
/usr/include/libavformat/avformat.h:2165:41: note:   initializing argument 5 of 'int av_find_best_stream(AVFormatContext*, AVMediaType, int, int, const AVCodec**, int)'
 2165 |                         const AVCodec **decoder_ret,
      |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~
/home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.cpp:445:52: error: invalid conversion from 'AVCodec**' to 'const AVCodec**' [-fpermissive]
  445 |                                            -1, -1, &m_pAudioCodec, 0);
      |                                                    ^~~~~~~~~~~~~~
      |                                                    |
      |                                                    AVCodec**
In file included from /home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.h:46,
                 from /home/sebin/.cache/yay/corsix-th/src/CorsixTH-0.64/CorsixTH/Src/th_movie.cpp:23:
/usr/include/libavformat/avformat.h:2165:41: note:   initializing argument 5 of 'int av_find_best_stream(AVFormatContext*, AVMediaType, int, int, const AVCodec**, int)'
 2165 |                         const AVCodec **decoder_ret,
      |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~
[33/35] Building CXX object CorsixTH/CMakeFiles/CorsixTH_lib.dir/Src/th_map.cpp.o
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: corsix-th

I also tried using the updated 0.65.1 tarball, but that aborts for pretty much the same reasons. Not sure how to proceed here to get it to build...