Package Details: goldendict-webengine-pr-git 22.12.02.r79.5a87a715.59363bc9-1

Git Clone URL: https://aur.archlinux.org/goldendict-webengine-pr-git.git (read-only, click to copy)
Package Base: goldendict-webengine-pr-git
Description: Feature-rich dictionary lookup program supporting multiple dictionary formats
Upstream URL: https://github.com/goldendict/goldendict/pull/1542
Licenses: GPL3
Conflicts: goldendict
Provides: goldendict
Submitter: vedg
Maintainer: vedg
Last Packager: vedg
Votes: 8
Popularity: 0.063289
First Submitted: 2022-12-02 11:35 (UTC)
Last Updated: 2024-05-31 10:28 (UTC)

Pinned Comments

vedg commented on 2022-12-02 11:54 (UTC)

This package is based on my Qt WebEngine pull request (Upstream URL). The upstream master branch is pulled in by default. A comment in the PKGBUILD advises what to do if merging upstream master fails.

If you wish to include a fix or a feature from some of my other pull requests, uncomment and possibly modify one or more of the _pull_we lines in the PKGBUILD.

Latest Comments

« First ‹ Previous 1 2 3 4 5 Next › Last »

vedg commented on 2023-01-22 09:23 (UTC)

Doesn't start building:

Fixed by overriding git user.name and user.email in the git pull command.

maxkaspar commented on 2023-01-21 20:32 (UTC)

Doesn't start building:

[code]Committer identity unknown

*** Please tell me who you are.

Run

git config --global user.email "you@example.com" git config --global user.name "Your Name"

to set your account's default identity. Omit --global to set the identity only in this repository.

fatal: unable to auto-detect email address (got 'milan@oldamd.(none)') [/code]

vedg commented on 2023-01-17 19:16 (UTC)

Yes, I'll rebase the PR and merge upstream/master into we/webkit-or-webengine. It's fortunate that a temporary automatic build failure is not a big deal.

xiota commented on 2023-01-17 18:34 (UTC)

It looks like the package was added and successfully built. If there are build issues caused by upstream merging in the future, you would eventually update the PR to resolve it? If so, the auto-build could just be allowed to fail and users would continue using the previous build until it's updated.

vedg commented on 2023-01-17 17:54 (UTC)

Thank you for the detailed explanation. I've requested that this package be added to the Chaotic AUR repository. Perhaps that will increase user testing of your PR.

Thank you! A potential issue with automated building is that this PKGBUILD merges the upstream/master branch. If an upstream/master branch update conflicts with the we/webkit-or-webengine branch, the git merge command fails. A comment in the PKGBUILD recommends commenting out the merge line for the build to succeed in this case. I guess this recommendation won't be followed by the automated Chaotic AUR repository.

xiota commented on 2023-01-17 17:37 (UTC) (edited on 2023-01-17 17:51 (UTC) by xiota)

Thank you for the detailed explanation. I've requested that this package be added to the Chaotic AUR repository. Perhaps that will increase user adoption/testing of your PR.

vedg commented on 2023-01-17 05:38 (UTC) (edited on 2023-01-17 05:39 (UTC) by vedg)

@vedg Can you explain major diffs between this and goldendict-webengine-git ? Why might someone prefer one over the other? Thanks.

I don't follow the development of @xiaoyifang's fork closely, so cannot detail feature/bug disparity. This comment gives a developer's perspective.

Here is my best effort to explain general differences from a user's perspective:

1. @xiaoyifang's fork is undergoing rapid development. New features are being implemented. Dependencies are being replaced or eliminated. Refactoring, optimization, porting to Qt 6, etc. Changes are not thoroughly reviewed, not even self-reviewed. The developer doesn't appear to test the changes much before committing and releasing either. Regressions and reverting commits is common. Users play the role of beta testers. But the users can't possibly catch all regressions. I have spotted many bugs in this fork when I looked at the code and changes. Though I have never dared to build or run @xiaoyifang's version, so don't know how the bugs are manifested in practice.

My pull request ports to Qt WebEngine, fixes related bugs, makes related improvements, implements small related features and refactorings. The changes I make unrelated to Qt WebEngine are in separate pull requests, but can be optionally merged into the we/webkit-or-webengine branch (see instructions in comments in this PKGBUILD). I self-review and test changes thoroughly before releasing them. Not yet ported features and known issues are listed in the pull request's description. Some of these issues apply to @xiaoyifang's fork too, but he never bothered to investigate and document them. His approach is to focus on bugs and feature requests reported by users. I am trying not to deviate too much from the upstream version to facilitate merging the upstream branch and in the hope that one day the pull request is accepted. If the user demand/need to support Qt 6 grows but the upstream version is not ported, I'll add Qt 6 support to the pull request (possibly dropping Qt 4 support in the process).

2. @xiaoyifang's fork is much older and more established than mine. User involvement is much higher. One developer is a frequent contributor for a couple of months now. A few other developers occasionally contribute to his fork too. The fork appears to be usable on Windows, GNU/Linux and macOS.

I am the only contributor to my pull request. The number of users is much smaller. Only one user has reported his experience in comments to the pull request. I have never tested whether or how well my version works on the platforms I don't use - Windows or macOS. But someone went to trouble to build my fork on a new macOS version and architecture: https://github.com/vedgy/goldendict/pull/1. Supposedly it works tolerably well on macOS.

3. If you value stability and my pull request works well for you, then I recommend using it. Please report Qt WebEngine-related issues not already listed in the pull request description at https://github.com/vedgy/goldendict/issues. Comments to the issues listed in the pull request can be reported in new issues as well, or in comments under the pull request (if not expected to grow into discussions). General usage feedback can go either in pull request comments or in https://github.com/vedgy/goldendict/discussions to start a discussion. Bug reports, feature requests, discussions unrelated to Qt WebEngine or the pull request, if applicable to the upstream version, belong to the upstream repository: https://github.com/goldendict/goldendict.

If you experience many issues with my pull request, need unported or unrelated features, you can check whether @xiaoyifang's fork works better for you.

vedg commented on 2023-01-06 15:56 (UTC) (edited on 2023-01-06 15:56 (UTC) by vedg)

It looks like a recent update to libtiff broke the app.

This is a general issue. When a dependency's so version changes, an AUR package has to be rebuilt by each user. Quote from https://wiki.archlinux.org/title/Arch_User_Repository#Installing_and_upgrading_packages:

Note: The AUR is unsupported, so any packages you install are your responsibility to update, not pacman's. If packages in the official repositories are updated, you will need to rebuild any AUR packages that depend on those libraries.

« First ‹ Previous 1 2 3 4 5 Next › Last »