Package Details: implay 1.5.1-1

Git Clone URL: https://aur.archlinux.org/implay.git (read-only, click to copy)
Package Base: implay
Description: Desktop media player built on top of mpv and imgui
Upstream URL: https://github.com/tsl0922/ImPlay
Keywords: media mpv player video
Licenses: GPL3
Submitter: 135e2
Maintainer: 135e2
Last Packager: 135e2
Votes: 1
Popularity: 0.000003
First Submitted: 2023-02-20 17:32 (UTC)
Last Updated: 2023-11-30 13:16 (UTC)

Latest Comments

135e2 commented on 2023-11-22 00:01 (UTC) (edited on 2023-11-22 00:02 (UTC) by 135e2)

infinity777:

Roger. It seems that upstream force-pushed 1.5.0 tag. Sigh :(

Apologies for the inconvenience.

infinity777 commented on 2023-11-18 14:24 (UTC) (edited on 2023-11-18 14:27 (UTC) by infinity777)

==> ERROR: pkgver is not allowed to contain colons, forward slashes, hyphens or whitespace.
==> ERROR: pkgver() generated an invalid version: 1.4.0-65-g5568222
-> error making: implay-exit status 12
-> Failed to install the following packages. Manual intervention is required: implay - exit status 12

The tag for 1.5.0 is incorrect
_tag=5568222c25e6389b6c8948031c5893e5743b70c5 # git rev-parse "${pkgver}"

This should be
_tag=20b5c9b220d9e2a63b3d6b1fcdc83444859cb119

135e2 commented on 2023-10-11 04:48 (UTC)

Hi MarsSeed,

I fully understand your request and appreciate your feedback. However, as far as I know, ArchLinux does not enforce a strict splitting-shared-library policy like Debian does. The decision to bundle certain libraries (imgui, glad, etc.) was made by the upstream developers, and I prefer to align with their build policies. While debundling can be more space-efficient, it often leads to creating numerous new patches. Staying in sync with upstream, in my opinion, is a more proper approach.

Similiar AUR packages, like imhex also do not patch to depend on aur/imgui. The PKGBUILD maintainer simply enables cmake's USE_SYSTEM_XXX flags provided by upstream.

I believe there must be a reason for the upstream developer to bundle third_party code, whether for ease of use or for further custom modifications. As downstream packagers, it is generally better not to modify it unless security vulnerabilities are identified.

Thanks for your understanding.

MarsSeed commented on 2023-10-08 13:55 (UTC)

This should be patched to depend on aur/imgui instead of building its own version of it from the third_party/imgui directory.

Here's a FindImGui.cmake module file that you could use to that end.

Other libraries that would be better to depend on instead of building and bundling them:

  • extra/glad (instead of third_party/glad)
  • aur/fmt9 (instead of third_party/fmt)
  • extra/nlohmann-json (instead of third_party/json)

vagorafaelino commented on 2023-07-14 13:03 (UTC) (edited on 2023-07-14 13:04 (UTC) by vagorafaelino)

You need to add 'git' in the makedepends array in order to build this package in clean chroot environment. Thx in advance

135e2 commented on 2023-02-25 14:39 (UTC) (edited on 2023-03-23 11:27 (UTC) by 135e2)

Notice: If you encounter any error spams like the one below on Wayland, you can disable the 'Enable Viewports' option in the settings/interface section to fix it [1]:

GLFW [65544]: Wayland: Window position retrieval not supported

However, please note that the Wayland backend can still be unstable and may encounter other errors [2], such as:

GLFW [65544]: Wayland: Window position setting not supported
GLFW [65544]: Wayland: Focusing a window requires user interaction

If you are bothered by these issues, consider switching to the old good X11 backend by reinstalling GLFW, which replaces the Wayland backend and uses XWayland:

sudo pacman -S glfw-x11

[1]: Enabled by default
[2]: Related issue: https://github.com/glfw/glfw/issues/1121

Ref: https://github.com/tsl0922/ImPlay/issues/17