Arch Linux User Repository

Hi thanks for the package! Could you please update the java-runtime dependency so it isn't fixed to java 11? I tested it and the kotlin-lang-server builds and runs fine up to java 25.

# Maintainer: Ricardo Grim Cabrita <grim@kriegor.net>

pkgname=kotlin-language-server
pkgver=1.3.13
pkgrel=1
pkgdesc="Smart code completion, diagnostics and more for Kotlin using the Language Server Protocol"
arch=(any)
url="https://github.com/fwcd/kotlin-language-server"
license=('MIT')
conflicts=('kotlin-language-server-git')
provides=('kotlin-language-server')
depends=('java-runtime')
makedepends=('java-environment')
source=("${url}/archive/${pkgver}.tar.gz")
sha256sums=('4cb346f989ef114f6073cb9401968a7dd27eb5cd96993fa6856203610a13f96e')

build() {
    java_path=$(archlinux-java get 2>/dev/null)
    if [[ -z "$java_path" || ! -d "/usr/lib/jvm/$java_path" ]]; then
        echo "ERROR: No active Java version found. Please run:"
        echo "  sudo archlinux-java set <java-version>"
        exit 1
    fi

    export JAVA_HOME="/usr/lib/jvm/$java_path"

    java_ver=$("$JAVA_HOME/bin/java" -version 2>&1 | grep 'version' | cut -d'"' -f2)
    major_ver=$(echo "$java_ver" | cut -d'.' -f1)
    if [[ "$major_ver" -lt 11 ]]; then
        echo "ERROR: Java 11 or higher is required. Found: $java_ver"
        exit 1
    fi

    echo "Using JAVA_HOME=$JAVA_HOME"

    cd "${srcdir}/${pkgname}-${pkgver}"
    ./gradlew server:installDist
}

package() {
    install -d "${pkgdir}/usr/share/kotlin" "${pkgdir}/usr/bin"
    cp -r "${srcdir}/${pkgname}-${pkgver}/server/build/install/server" \
        "${pkgdir}/usr/share/kotlin/kotlin-language-server"
    ln -srf \
        "${pkgdir}/usr/share/kotlin/kotlin-language-server/bin/kotlin-language-server" \
        "${pkgdir}/usr/bin/kotlin-language-server"
}

After installing this and invoking kotlin-language-server, I got this:

/sbin/kotlin-language-server: line 87: cd: /sbin/../share/kotlin/kotlin-language-server/bin/..: No such file or directory

The kotlin-language-server executable is installed to /usr/bin. On Arch Linux, /sbin is a symlink to /usr/bin and is placed as the first one in PATH, so running the command by name finds it in /sbin. Invoking the language server directly by running /usr/bin/kotlin-language-server works.

The aforementioned problem happens because, /usr/bin/kotlin-language-server is a symlink that links to the actual executable's path that's relative to it. The same relative path, when resolved relative to /usr/bin/kotlin-language-server and /sbin/kotlin-language-server, results in different things, thus the problem happens. I've tried editing PKGBUILD, making the link's path not relative (by removing the r flag in the usage of ln in package()), and it worked. Not sure if there's any reason why we might want the link to be relative.

==> Starting build()...
Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file '/home/zarkli/.cache/paru/clone/kotlin-language-server/src/kotlin-language-server-1.3.9/buildSrc/build.gradle.kts' line: 4

* What went wrong:
Plugin [id: 'org.gradle.kotlin.kotlin-dsl', version: '4.2.1'] was not found in any of the following sources:

- Gradle Core Plugins (plugin is not in 'org.gradle' namespace)
- Plugin Repositories (could not resolve plugin artifact 'org.gradle.kotlin.kotlin-dsl:org.gradle.kotlin.kotlin-dsl.gradle.plugin:4.2.1')
  Searched in the following repositories:
    Gradle Central Plugin Repository

==> Quellen sind fertig.
kotlin-language-server-1.3.9-1: Lese pkg Liste…
==> FEHLER: Cannot find the debugedit binary required for including source files in debug packages.
Fehler: ‚kotlin-language-server-1.3.9-1‘ konnte nicht erstellt werden: 
Fehler: Pakete konnten nicht erstellt werden: kotlin-language-server-1.3.9-1

The upstream URL could be updated to https://github.com/fwcd/kotlin-language-server (same goes for the kotlin-language-server-git package).

The package doesn't install if you have the latest version of jdk (19) installed. Java 19 is not yet supported by upstream. I suggest changing build() so that, if jdk19 is installed, JAVA_HOME is set to an earlier version.

Thank you for the feedback, everyone!

Little amendment: need to change it to -name "*-1*jdk" to not catch openjfx ;)

btw I'd be open to co-maintain

I agree, the default jvm version should first be checked from java -version 2>&1 | grep version | cut -d'"' -f2

This will not work if you install a newer version of JDK, but use the old one as default, I guess we'd better change the code to find JVM to

    jdk="/usr/lib/jvm/default" &&
      test -n "$jdk" && export JAVA_HOME="$jdk"