Arch Linux User Repository

Thanks for looking into it! I appropriate it greatly!!

Done, just pushed out a new commit. No need to bump the pkgrel since the change is technically a no-op if you use makepkg. Any new build of this package will include the change, so yay users should get the benefits immediately.

@damentz:

Sure. We could drop pkgver() if you want.

@sir_lucjan, I separated the commit to change pkgver() from the update to the version updates, so we're still tracking the latest version of Liquorix despite your revert.

According to the wiki, if you define a pkgver() function, it'll be used to automatically update pkgver on execution of makepkg with the code you define. How about we just delete the function entirely then? I don't use that code myself, so all it does is interfere with the value I put into pkgver.

@Freso

Currently pkgver() generates the correct version number because regardless of the position in PKGBUILD it starts anyway after the prepare() function where these values are declared. If prepare() was following pkgver() then you would be absolutely right. pkgver() is before prepare() in PKGBUILD only for cosmetic reasons and it doesn't matter for the operation; anyway it is after prepare() and before build().

I don’t think $_minor and $_patchrel get carried over from prepare() to other functions (such as pkgver()). You may need to define them again inside pkgver().

@Freso

I've reverted https://aur.archlinux.org/cgit/aur.git/commit/?h=linux-lqx&id=962414a35862.

pkgver() dosen't work properly; I've downgrade lqxpatchset (-13 --> -11) and pkgver() doesn't set a proper pkgver.

@damentz

Please check your mailbox.

If all pkgver() does is return $pkgver, why not just remove the pkgver() function entirely? The pkgver() is a helper function to set $pkgver, so it makes no sense to have it set $pkgver to $pkgver…

Sure! Using makepkg, if you do your build in a separate command, it'll build using the wrong version. As an example, makepkg --cleanbuild --nobuild followed by makepkg --clean --force --noextract --noprepare will cause the second command to use the wrong version (because it "updates" it to 5.1._-1 from 5.1.9_4-1)

@Arzte

We don't support yay and aur-helpers.

Please use a makepkg.