Package Details: linux-lqx 5.1.18_1-1

Git Clone URL: https://aur.archlinux.org/linux-lqx.git (read-only)
Package Base: linux-lqx
Description: A desktop oriented kernel and modules with Liquorix patches
Upstream URL: http://liquorix.net/
Licenses: GPL2
Submitter: akurei
Maintainer: sir_lucjan (damentz)
Last Packager: damentz
Votes: 119
Popularity: 1.513125
First Submitted: 2011-08-08 16:08
Last Updated: 2019-07-14 18:07

Latest Comments

1 2 3 4 5 6 ... Next › Last »

Arzte commented on 2019-06-23 23:11

Thanks for looking into it! I appropriate it greatly!!

damentz commented on 2019-06-23 23:06

Done, just pushed out a new commit. No need to bump the pkgrel since the change is technically a no-op if you use makepkg. Any new build of this package will include the change, so yay users should get the benefits immediately.

sir_lucjan commented on 2019-06-23 22:46

@damentz:

Sure. We could drop pkgver() if you want.

damentz commented on 2019-06-23 22:44

@sir_lucjan, I separated the commit to change pkgver() from the update to the version updates, so we're still tracking the latest version of Liquorix despite your revert.

According to the wiki, if you define a pkgver() function, it'll be used to automatically update pkgver on execution of makepkg with the code you define. How about we just delete the function entirely then? I don't use that code myself, so all it does is interfere with the value I put into pkgver.

sir_lucjan commented on 2019-06-23 22:25

@Freso

Currently pkgver() generates the correct version number because regardless of the position in PKGBUILD it starts anyway after the prepare() function where these values are declared. If prepare() was following pkgver() then you would be absolutely right. pkgver() is before prepare() in PKGBUILD only for cosmetic reasons and it doesn't matter for the operation; anyway it is after prepare() and before build().

Freso commented on 2019-06-23 21:57

I don’t think $_minor and $_patchrel get carried over from prepare() to other functions (such as pkgver()). You may need to define them again inside pkgver().

sir_lucjan commented on 2019-06-23 20:46

@Freso

I've reverted https://aur.archlinux.org/cgit/aur.git/commit/?h=linux-lqx&id=962414a35862.

pkgver() dosen't work properly; I've downgrade lqxpatchset (-13 --> -11) and pkgver() doesn't set a proper pkgver.

@damentz

Please check your mailbox.

Freso commented on 2019-06-23 20:32

If all pkgver() does is return $pkgver, why not just remove the pkgver() function entirely? The pkgver() is a helper function to set $pkgver, so it makes no sense to have it set $pkgver to $pkgver

Arzte commented on 2019-06-13 21:41

Sure! Using makepkg, if you do your build in a separate command, it'll build using the wrong version. As an example, makepkg --cleanbuild --nobuild followed by makepkg --clean --force --noextract --noprepare will cause the second command to use the wrong version (because it "updates" it to 5.1._-1 from 5.1.9_4-1)

sir_lucjan commented on 2019-06-13 21:04

@Arzte

We don't support yay and aur-helpers.

Please use a makepkg.