Arch Linux User Repository

it has been fixed: https://github.com/criticic/llpp/compare/fix-2

hmmm, i cannot reproduce @urldog 's problem, it seems to be using basically as much as it did before.

as far as the other issue goes, i remember mupdf updated last week, so maybe something changed again...

EDIT: yeah the API changed again: https://github.com/ArtifexSoftware/mupdf/commit/8aca9504370b68836da4fdae4de299df71945774

I have updated it to my fork at: https://github.com/criticic/llpp

Good job @temhelk!

@stek: I created a patch for you to apply so this package builds again. It's co-authored by @temhelk and credited as such. You could also add me as co-maintainer, and I can take care of updating this package. I maintain a bunch at ankylosaurus.

From d19e0fa02e3c7500dc2bb9da8f13f01e7b1bf8bc Mon Sep 17 00:00:00 2001
From: txtsd <code@ihavea.quest>
Date: Fri, 10 Nov 2023 22:52:56 +0530
Subject: [PATCH] upgpkg: llpp 41-4

Add patch to allow building

Co-authored-by: temhelk <temhelk@gmail.com>
Signed-off-by: txtsd <code@ihavea.quest>
---
 .SRCINFO                            |  4 +++-
 0001-fix-Allow-building-again.patch | 30 +++++++++++++++++++++++++++++
 PKGBUILD                            | 14 +++++++++++---
 3 files changed, 44 insertions(+), 4 deletions(-)
 create mode 100644 0001-fix-Allow-building-again.patch

diff --git a/.SRCINFO b/.SRCINFO
index 81bebe3..a84e0ad 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = llpp
    pkgdesc = opengl accelerated pdf viewer based on mupdf
    pkgver = 41
-   pkgrel = 3
+   pkgrel = 4
    url = https://github.com/criticic/llpp
    arch = x86_64
    license = GPL3
@@ -24,6 +24,8 @@ pkgbase = llpp
    optdepends = unoconv: for llppac office conversion
    options = !strip
    source = git+https://github.com/criticic/llpp#branch=latest
+   source = 0001-fix-Allow-building-again.patch
    b2sums = SKIP
+   b2sums = 3d74eea6f6ac29ecae5a3055b70205b1e2601027f1f4473dadab595170d9f57a3d5948d6d6f9897ef5d60417998ef788d8242ea18612e8bd0e921520b2fc93df

 pkgname = llpp
diff --git a/0001-fix-Allow-building-again.patch b/0001-fix-Allow-building-again.patch
new file mode 100644
index 0000000..518126b
--- /dev/null
+++ b/0001-fix-Allow-building-again.patch
@@ -0,0 +1,30 @@
+From f12488495f8d562d63a745c036e9ae4c757f7bf1 Mon Sep 17 00:00:00 2001
+From: txtsd <code@ihavea.quest>
+Date: Fri, 10 Nov 2023 22:45:59 +0530
+Subject: [PATCH] fix: Allow building again
+
+Signed-off-by: txtsd <code@ihavea.quest>
+---
+ build.bash | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/build.bash b/build.bash
+index 0db5fbb..7830f6c 100755
+--- a/build.bash
++++ b/build.bash
+@@ -37,7 +37,11 @@ mudeps=('freetype2' 'gumbo' 'harfbuzz' 'libjpeg' 'libopenjp2' 'x11' 'zlib')
+ 
+ mkdir -p $outd/{$wsid,lablGL}
+ 
+-isfresh() { test "$(<$1.past)" = "$2"; } 2>/dev/null
++isfresh() {
++    test -f "$1.past" || return 1
++    test "$(<$1.past)" = "$2"
++} 2>/dev/null
++
+ 
+ mbt=${mbt:-release}
+ test -n "${gmk:-}" && gmk=false || gmk=true
+-- 
+2.42.1
+
diff --git a/PKGBUILD b/PKGBUILD
index bd28248..7d8fb1a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,4 +1,5 @@
 # Maintainer: Florian Stecker <oss@florianstecker.net>
+# Contributor: txtsd <aur.archlinux@ihavea.quest>
 # Contributor: Sagnik Mandal <criticic>
 # Contributor: Daniel M. Capella <polyzen@archlinux.org>
 # Contributor: Eli Schwartz <eschwartz@archlinux.org>
@@ -6,7 +7,7 @@

 pkgname=llpp
 pkgver=41
-pkgrel=3
+pkgrel=4
 pkgdesc='opengl accelerated pdf viewer based on mupdf'
 arch=('x86_64')
 url=https://github.com/criticic/llpp
@@ -21,8 +22,15 @@ optdepends=('djvulibre: for llppac djvu conversion'
             'librsvg: for llppac svg conversion'
             'unoconv: for llppac office conversion')
 options=('!strip')
-source=("git+$cloneurl#branch=latest")
-b2sums=('SKIP')
+source=("git+$cloneurl#branch=latest"
+        "0001-fix-Allow-building-again.patch")
+b2sums=('SKIP'
+        '3d74eea6f6ac29ecae5a3055b70205b1e2601027f1f4473dadab595170d9f57a3d5948d6d6f9897ef5d60417998ef788d8242ea18612e8bd0e921520b2fc93df')
+
+prepare() {
+    cd $pkgname
+    patch -Np1 -i "../0001-fix-Allow-building-again.patch"
+}

 build() {
   cd $pkgname
-- 
2.42.1

I also have this "build failed" problem. I tried to investigate this (even though I'm not that familiar with bash) and I think I found what causes that issue.

The call to this function makes the script exit:

isfresh() { test "$(<$1.past)" = "$2"; } 2>/dev/null

And if I understand correctly it happens because it tries to read the content of the file "$1.past" that doesn't exist when you build it the first time.

After changing the function to that:

isfresh() {
    test -f "$1.past" || return 1
    test "$(<$1.past)" = "$2"
} 2>/dev/null

it seems to work and builds the application.

Same error as @rvalles when building.

When trying to run the exiting installed version I get: cannot create context: incompatible header (1.23.4) and library (1.23.5) versions

build failed

Seems to be near the top of the build script. Quite the useless choice of error string.

It installs fine, but when running it I get:

$ llpp llpp: error while loading shared libraries: libmupdf.so: cannot open shared object file: No such file or directory

Any idea why?

The upstream patch https://github.com/criticic/llpp/pull/5 didn't work for me, so instead I made the minimal changes necessary to make it compile again (with ocaml 5.0.0-1 and libmupdf 1.23.3-4). It works for me now, but the fix did include ignoring some warnings, so your mileage may vary.

Build fails:

generating build/confstruct.ml keys.cmi wsi/x11/wsi.cmi File "_none_", line 1: Error (alert ocaml_deprecated_auto_include): OCaml's lib directory layout changed in 5.0. The unix subdirectory has been automatically added to the search path, but you should add -I +unix to the command-line to silence this alert (e.g. by adding unix to the list of libraries in your dune file, or adding use_unix to your _tags file for ocamlbuild, or using -package unix for ocamlfind). ocamlc -I build -I build/wsi/x11 -g -strict-sequence -strict-formats -alert @all -warn-error @A -c -o build/wsi/x11/wsi.cmi ./wsi/x11/wsi.mli failed build failed

The bug is fixed. Good job!

it has been fixed: https://github.com/criticic/llpp/compare/fix-2

hmmm, i cannot reproduce @urldog 's problem, it seems to be using basically as much as it did before.

as far as the other issue goes, i remember mupdf updated last week, so maybe something changed again...

EDIT: yeah the API changed again: https://github.com/ArtifexSoftware/mupdf/commit/8aca9504370b68836da4fdae4de299df71945774