Arch Linux User Repository

The next person who discusses keygens will have their account suspended indefinitely.

Add qt5-wayland as an optdep I’d say, that’s best practice. I’m surprised it’s not just part of the qt5-base packages, what if we modify it to add the actual base that qt5-wayland provides?

Ah, right, qt5-wayland provides helper functions, and doesn't provide the pkgbase of qt5 at all. In that case, an optdep of qt5-wayland would be good, I'd say.

@nursoda Wayland isn't a package, it's a protocol that Wayland compositors use. I'm not sure at the moment what the best way to deal with this is, since the X version should run under XWayland. X only people will likely be annoyed if we force them to install qt5-wayland. Let me think about this and am open to suggestions.

A bit off-topic, but it would solve such bad user experiences: Is there a way to handle conditional dependencies like "if wayland AND masterpdfeditor are installed, then qt5-wayland is installed as a dependency"?

It started coredumping due to a missing wayland plugin. Installing qt5-wayland fixed it.

@ninetailedtori I've removed nss and nspr from the dependency list. Thanks for pointing this out.

Regarding the checksums, I'm worried that this will create one more opportunity for things to go haywire if, for example, the checksum URL changes. Let me circle back to this later today, as it seems like a sensible improvement in the PKGBUILD.

OK, fixed location of desktop icon and added copying icons to /usr/share/icons.

@mithrial @hatred Thanks for doing the legwork on this.

Install icons too:

--- PKGBUILD.orig       2025-04-15 19:03:48.940581491 +1000
+++ PKGBUILD    2025-04-15 19:15:47.161799739 +1000
@@ -23,7 +23,8 @@

   cd "$pkgdir/opt/master-pdf-editor-${pkgver%%.*}"
   ln -sr masterpdfeditor${pkgver%%.*} -t "$pkgdir/usr/bin/"
-  install -Dm644 masterpdfeditor${pkgver%%.*}.desktop -t "$pkgdir/usr/share/applications/"
+  install -Dm644 usr/share/applications/net.code-industry.masterpdfeditor${pkgver%%.*}.desktop -t "$pkgdir/usr/share/applications/"
   install -Dm644 license_en.txt -t "$pkgdir/usr/share/licenses/$pkgname/"
+  find usr/share/icons -type f -exec install -Dm644 "{}" "$pkgdir/{}" \;
   patchelf --remove-rpath masterpdfeditor${pkgver%%.*}
 }

The file location and name has changed:

diff --git a/PKGBUILD b/PKGBUILD
index ee5a0e6..e0a17ec 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -23,7 +23,7 @@ package() {

   cd "$pkgdir/opt/master-pdf-editor-${pkgver%%.*}"
   ln -sr masterpdfeditor${pkgver%%.*} -t "$pkgdir/usr/bin/"
-  install -Dm644 masterpdfeditor${pkgver%%.*}.desktop -t "$pkgdir/usr/share/applications/"
+  install -Dm644 usr/share/applications/net.code-industry.masterpdfeditor${pkgver%%.*}.desktop -t "$pkgdir/usr/share/applications/"
   install -Dm644 license_en.txt -t "$pkgdir/usr/share/licenses/$pkgname/"
   patchelf --remove-rpath masterpdfeditor${pkgver%%.*}
 }

same issue as @nfs during installation via pacman:

cannot stat 'masterpdfeditor5.desktop'

im gonnna waiting the pkgbuild fix

I had to delete the line in the PKGBUILD that installed the .desktop file in /usr/share/applications. I compared the new .desktop file with the one already installed, and they were the same. So I figured there wouldn't be much harm in removing the line. Still the PKGBUILD should be fixed so it can find the new .desktop file.

The message I received when I tried to install it the first time was:

cannot stat 'masterpdfeditor5.desktop'

I deleted the line:

install -Dm644 masterpdfeditor${pkgver%%.*}.desktop -t "$pkgdir/usr/share/applications/"