Arch Linux User Repository

Please take notice that the name may have to be changed very soon. In order to keep all votes and comments on this package, submit a new one with the new project name and contact the mailing list or a Trusted User to have the packages merged. Discussion on new names & The issue causing this

The discussion linked by @lectrode shows that can safely assume the source for NoiseTorch itself, as well as the pulseaudio Go module dependency currently isn't compromised, and likely hasn't been at all. Considering the compromise was a relatively unsophisticated malware on a dev's computer that was scanning for cryptocurrency wallets, this isn't surprising.

progress of binary and code review of noisetorch can be found here:

 https://github.com/noisetorch/NoiseTorch/discussions/275

Thank you for sharing that. I contemplated sabotaging temporarily this package with regard to this message, but decided against it, as the author only spoke about binaries.

But as you pointed out; commits could have been tampered too, even if first analysis seem to have not surfaced issues : https://github.com/lawl/NoiseTorch/issues/254

If multiple people here do not trust the git history I'll sabotage this package for a few days/weeks.

You guys likely already know this, but I'll say it just in case.
Yesterday, the author of NoiseTorch announced that he believes his key was compromised, and urged users to not trust neither the binaries, nor the source code for this project:

Release 0.116:

POTENTIAL COMPROMISE  
I HAVE REASON TO BELIEVE AT LEAST ONE OF MY SYSTEMS HOLDING KEY MATERIAL HAS BEEN COMPROMISED.  
DO. NOT. TRUST. THE. BINARIES.  
I'm deeply sorry about this, but it's better to be safe than sorry.

Readme.md:

At least one of my sytems has probably been compromised, dont use the source either. One could hide things in a large diff.

https://github.com/lawl/NoiseTorch/releases/tag/0.11.6
https://github.com/lawl/NoiseTorch/blob/master/README.md

Hello, thanks for the comments. On my system it worked without a hitch, I think pkexec did not work on your system [1} :

Anyway, I setcaped the binary in post_install/post_upgrade as you suggested. It should work on your end now.

[1] https://github.com/lawl/NoiseTorch/blob/245455d508f21e888b18e168b0a930a32ab5a24d/capability.go#L67

You should add sudo setcap 'CAP_SYS_RESOURCE=+ep' /usr/bin/noisetorch in your install file probably like something similar in voidlinux. im not sure if arch has post_install() function for PKGBUILD's but pls do add that if there is.

EDIT:

There is one after all in another AUR package https://aur.archlinux.org/cgit/aur.git/tree/noisetorch.install?h=noisetorch

I had issue with setting the setcap permission through the GUI. It kept exiting with a non-zero value so I had to manually set the setcap permission:

sudo setcap 'CAP_SYS_RESOURCE=+ep' $(which noisetorch)

I assume this is because NoiseTorch is looking for the installation in the ~/.local/bin directory when trying to set the said permission while this package installs it in the /usr/bin directory.

This is working again. Now that they are using their own implementation of the ladspa plugin, I was able to remove the dependency on noise-suppression-for-voice, and we no longer need the patches.

With latest changes (https://github.com/lawl/NoiseTorch/commit/b747084bb0a033e10f55058b73b06238a666d8ae) the dependency of package noise-suppression-for-voice is no longer necessary as it is build-in the main package.

Thanks for the feedback. I'll be able to take a look at this tonight or tomorrow morning. Hopefully it's something I overlooked and we can get it working again.

Since the version 0.9.0.r5.ge7072b2 noisetorch doesn't work for me any more (But I am also a Manjaro [testing] user). If I load it on my microphone I always get a yellow warning Inconsistent state, please unload first. in the GUI. With downgrade I tested if previous installed versions (from 0.7.2.beta.r0.g02665f1 to 0.9.0.r3.g4f7ac32) did still work and all did. Is this a Manjaro specific bug (version of pulseaudio is 14.2) or does this also happen on Arch with the latest version 0.9.0.r5.ge7072b2?

I compared the logs (in the /tmp/ directory - https://gist.github.com/AnonymerNiklasistanonym/7a60bc422683cae61a5b6b32e18d4474) and in the latest version the biggest difference is after the line Loaded null sink as idx: 28 the next line says PulseAudio error: commandLoadModule -> Module initialization failed.

If it works on Arch you can see this issue as resolved for now - I'll just wait and check future versions while using the downgraded one that still works fine.

now depends on noise-suppression-for-voice (AUR) for the librnnoise_ladspa.so library. it was building the ladspa plugin from source previously, and embedding the .so file into the binary. should be more in line with packaging conventions/guidelines now.

new non-git release version coming soon!

take a look at my post

https://bbs.archlinux.org/viewtopic.php?pid=1942538

don't want to clutter this up with unrelated discussions. but any feedback in the forum is greatly appreciated!

Sure, what do you need feedback on?

I've been looking at a plain 'noisetorch' package, but I'm going to need a little feedback first.

Exactly. Such a package would also make a fine candidate for addition to [community].

So you'd like to see a 'noisetorch' package that builds from source, but builds from tagged releases instead of the master branch? Essentially the '-bin' version but built from source?

Since you manage the other two noisetorch packages, could you also create a non-git release version since noisetorch has some releases available?

Thanks for the info regarding the patch. It's no longer included and is building/installing/running fine for me as well.

I just built the whole project without the main.go patch because in the release notes to version 8 (https://github.com/lawl/NoiseTorch/releases/tag/0.8.0-beta) it is noted: "Regular builds with make will not contain an updater anymore". It seems to work fine on my end without the patch (looks exactly like with patch) and this patch can thus probably be removed.

To install version noisetorch-git-0.8.2.r0.g39c1e37-1 I also needed to update the patch file like @kageurufu because the patch that disables the self/auto updater is again broken.

I've gotten this building again, and uploaded a patch for the PKGBUILD and main.patch at https://gist.github.com/kageurufu/c3e5bba47c31eaf0154ed463ad7898b5

I updated the pkgbuild to include the changes suggested by @yochananmarqos.

The patch that disables the self/auto updater was broken, so I pushed a new patch as well.

@reztho:

Add this in prepare():

  export GOPATH="$srcdir/gopath"
  go clean -modcache

Add this after make in build():

  go clean -modcache

I think making a package from this PKGBUILD, it made a $HOME/go directory in my system. PKGBUILDs are not supposed to write in the users home. Please, check if it's the case and find a way to manage the depending GO packages installation inside src dir when making this package.

Thanks I made that change. I was pushing some changes to the build process anyway so this was an easy change to include.

The desktop file is broken:

Icon=noisetorch.png

Should be:

Icon=noisetorch

sed -i 's/noisetorch.png/noisetorch/g' "assets/noisetorch.desktop"
install -Dm644 "assets/noisetorch.desktop" -t \
  "$pkgdir/usr/share/applications"