Arch Linux User Repository

@Thaodan sorry about that, I misread the diff. If using a .so then you could do it like this, but it's preferred to require the package which provides the .so. From the makedepends section of PKGBUILD page on wiki: The packages in the depends array are implicitly required to build the package, they should not be duplicated here., so you still don't need to duplicate them.

@Technetium: hm which dependencies did I add to makedepend and depend?

Offtopic: but if using .so symbols rather than package names having the same package in both make- and depends makes sense.

Can someone merge Thaodan's changes? It'd be great for tools that automatically ingest AUR to be able to install/update this rather than to have to do it as a one-off.

@Thaodan packages cannot be in both depends and makedepends, it's one or the other: https://wiki.archlinux.org/title/PKGBUILD

This is my pkgbuild with all the fixes I just mentioned:

diff --git a/PKGBUILD b/PKGBUILD
index 4ec7047..874ce7b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,15 +1,16 @@
 # Maintainer: Graham Edgecombe <graham@grahamedgecombe.com>
 pkgname=openrct2-git
-pkgver=r21143.594b08c91
+pkgver=0.4.0.r236.gb0ffa9d28e
 pkgrel=1
 pkgdesc='Open source re-implementation of Roller Coaster Tycoon 2 (requires full
          copy of the game)'
 arch=('i686' 'x86_64' 'armv7h' 'aarch64')
 url='https://openrct2.io'
 license=('GPL3')
-depends=('hicolor-icon-theme' 'sdl2' 'curl' 'nlohmann-json' 'speexdsp'
-         'fontconfig' 'libpng' 'openssl' 'libzip' 'icu' 'duktape' 'benchmark')
-makedepends=('git' 'cmake' 'discord-rpc-api')
+depends=('hicolor-icon-theme' 'sdl2' 'curl' 'speexdsp'
+         'fontconfig' 'libpng' 'openssl' 'libzip' 'icu' 'benchmark'
+         'libogg' 'libvorbis' 'flac' 'discord-rpc')
+makedepends=('git' 'cmake' 'nlohmann-json')
 optdepends=('zenity: System dialog box support (GNOME/GTK)'
             'kdialog: System dialog box support (KDE)'
             'alsa-lib: ALSA audio driver'
@@ -21,24 +22,29 @@ source=("$pkgname"::'git+https://github.com/OpenRCT2/OpenRCT2.git#branch=develop
 sha256sums=('SKIP')

 pkgver() {
-  cd "$srcdir/$pkgname"
-  printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
+  cd "$pkgname"
+  git describe --long | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
 }

 build() {
-  cd "$srcdir/$pkgname"
+  # Required options to workaround GCC 12 issues
+  # https://github.com/OpenRCT2/OpenRCT2/issues/17371
+  CXXFLAGS+=" -Wno-error=maybe-uninitialized  -Wno-error=restrict  -Wno-error=null-dereference"

-  mkdir -p build
-  cd build
-  cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=/usr \
-    -DCMAKE_INSTALL_LIBDIR=/usr/lib ..
-  make all g2
+  # Needed to be able to build while LTO is enabled
+  # https://github.com/OpenRCT2/OpenRCT2/issues/6200
+  CXXFLAGS+="  -Wno-error=stringop-overflow"
+
+  cmake -B build -S "$pkgname" \
+        -DCMAKE_BUILD_TYPE=RelWithDebInfo \
+        -DCMAKE_INSTALL_PREFIX='/usr' \
+        -DSTATIC=OFF \
+        -Wno-dev
+  cmake --build build -v
 }

 package() {
-  cd "$srcdir/$pkgname/build"
-
-  make DESTDIR="$pkgdir" install
+  DESTDIR="$pkgdir" cmake --install build

   rm "$pkgdir/usr/lib/libopenrct2.a"
   rmdir "$pkgdir/usr/lib"

Add this to able to compile: export CXXFLAGS+=" -Wno-error=maybe-uninitialized -Wno-error=restrict -Wno-error=null-dereference"

See:

https://github.com/OpenRCT2/OpenRCT2/issues/17371

Benchmark is only optional dependency. The pkgbuild should be updated against cmake packaging guidelines.

I think the closest replacement is discord-rpc-git. In any case if build with discord-rpc enabled its a depend and not a make depend.

discord-rpc-api doesn't exist anymore.

duktape is no longer required

libflac, libogg, and libvorbis are now required (unless disabled via cmake option)

To fix the error, I just opened up PKGBUILD in a text editor and removed the 4 rm lines and 2 rmdir lines inside package() (unified diff below). These should probably be changed to conditional removals ala [[ -f FILE ]] && rm FILE.

--- PKGBUILD    2021-04-22 17:39:41.671454399 -0400
+++ PKGBUILD    2021-04-23 15:56:07.402117749 -0400
@@ -49,12 +49,4 @@
   cd "$srcdir/$pkgname/build"

   make DESTDIR="$pkgdir" install
-
-  rm "$pkgdir/usr/lib/libopenrct2.a"
-  rm "$pkgdir/usr/lib/libdiscord-rpc.a"
-  rmdir "$pkgdir/usr/lib"
-
-  rm "$pkgdir/usr/include/discord_rpc.h"
-  rm "$pkgdir/usr/include/discord_register.h"
-  rmdir "$pkgdir/usr/include"
 }

Since commit 818b2a5239 on Jan 11 for implementing https://github.com/OpenRCT2/OpenRCT2/pull/13658, openrct2 build will detect the system discord rpc library. > Now if discord-rpc-api is installed, this openrct2-git package will fail with

rm: cannot remove '/home/will/.cache/yay/openrct2-git/pkg/openrct2-git/usr/lib/libdiscord-rpc.a': No such file or directory
==> ERROR: A failure occurred in package().

because openrct2 won't build discord rpc if there is a system one present.

Using the system library or the local discord-rpc repo both produce the same file list, so requiring discord-rpc-api as a build dependency would work here.```

I am having this error and I cannot figure out how to get it to build. Do I need to remove Discord first? I tried added discord-rpc-api to both depends and/or makedepends before building, had no effect. Any tips would be greatly appreciated!

Since commit 818b2a5239 on Jan 11 for implementing https://github.com/OpenRCT2/OpenRCT2/pull/13658, openrct2 build will detect the system discord rpc library. Now if discord-rpc-api is installed, this openrct2-git package will fail with

rm: cannot remove '/home/will/.cache/yay/openrct2-git/pkg/openrct2-git/usr/lib/libdiscord-rpc.a': No such file or directory
==> ERROR: A failure occurred in package().

because openrct2 won't build discord rpc if there is a system one present.

Using the system library or the local discord-rpc repo both produce the same file list, so requiring discord-rpc-api as a build dependency would work here.

Please fill out the latest OpenRCT2 survey, you can find more info on Reddit: https://www.reddit.com/r/rct/comments/hr7dow/openrct2_user_survey/ and the survey itself: https://forms.gle/YiFKfLFXatDgwmSa7

Building OpenRCT2 now requires the duktape Community repo package.

https://github.com/OpenRCT2/OpenRCT2/wiki/Building-OpenRCT2-on-Linux/_compare/5deb31e4ff70d3a984368a47d9913cd88ecfa22c...b52bac71e819baa0bb85fb3a001bd2b5e9e6183d#diff-5f705bbc95ee85e0d8c0bc5a3a6766f7R44

I've noticed in some cases that the symlink to the system's rapidjson can sometimes not clean up correctly, causing the build to fail in the prepare step trying to make another symlink. I've added a guard around the ln so that it'll only create it if it doesn't exist. Thought it might help, let me know what you think!

diff --git a/PKGBUILD b/PKGBUILD
index 18bb5dc..ecb271f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -31,7 +31,9 @@ prepare() {
   cd "$srcdir/$pkgname"
   ln -sf "$srcdir/discord-rpc" discord-rpc
   mkdir -p discord-rpc/thirdparty
-  ln -sf "/usr/include/rapidjson" discord-rpc/thirdparty/rapidjson
+  if [[ ! -L "$srcdir/discord-rpc/thirdparty/rapidjson" ]]; then
+    ln -sf "/usr/include/rapidjson" discord-rpc/thirdparty/rapidjson
+  fi
 }

 build() {

Could you base the pkgver on latest tag + commits since then?

That would most likely need to be supported in our cmakelists.txt, I have only added support for building discord-rpc from source. Feel free to file an issue for that, or better yet, submit a PR.

thanks. Discord-rpc is also shared and maybe possible as an optdepend.

@JudgeManganese: I haven't managed to reproduce that, including when building inside a fresh chroot.

@Thaodan: sure, done.

Can we build with distro rapidjson instead of the shared one?

The objects/title sequences that CMake downloads as part of package() are now causing the PKGBUILD to fail with the below error. CMake is showing the hash for an empty file because the file wasn't downloaded. It seems makepkg is not allowing CMake to download because I can manually run the commands in package() and they get downloaded.

CMake Error at cmake_install.cmake:48 (file):
  file DOWNLOAD HASH mismatch

    for file: [<path-to-cache>/openrct2-git/pkg/openrct2-git/usr/share/openrct2/title/title-sequences.zip]
      expected hash: [1136ef92bfb05cd1cba9831ba6dc4a653d87a246]
        actual hash: [da39a3ee5e6b4b0d3255bfef95601890afd80709]
             status: [6;"Couldn't resolve host name"]

hmm, it's maybe not so simple - I think the tests might expect those files to be in /, rather than inside $DESTDIR...

maybe it's easiest just to disable the tests for now.

Ah, good catch!

I'll make it download the objects/title sequences in advance. I've never been very happy with the fact that cmake downloads them (and most distros don't allow this in their policy, as it breaks reproducibility of the build process if the files ever disappear from the net).

I guess another option is that the cmake config should be fixed such that the test target depends on the target that downloads the objects.

check() runs tests, but they need files that get download upon installation with install target, which only gets done in package() after successful check().

The options to address that that I can think of right now include: 1. perform install target in check(), before running tests 2. run tests in package() 3. pre-populate required files as part of PKGBUILD 4. use ctest to split running the some tests in check(), some in package()

Other suggestions welcome.

Yes I'm using yay, managed to learn how to do it manually :) (with "--nocheck", I installed devtools but couldn't find extra-x86_64-build). I can see many improvements in the game, but maybe a slower startup time.

It might also be worth trying to build it in a chroot so you know you have a clean environment. You can use extra-x86_64-build to do that (from the devtools package). Run it from the same directory you'd run makepkg from.

couldn't find where to pass "--nocheck"

It's one of makepkg's flags. I guess you're using an AUR helper?

Hey @janisozaur, tried it and got the same error as @wyre, and couldn't find where to pass "--nocheck".

@axiac can you check if adding -DPORTABLE=on addresses that? Otherwise can you provide more logs? The tests in question all require objects' json data, which should get obtained during cmake packaging, but either it doesn't or it is in improper path.

I still had this issue, as of yesterday.

Same issue here, 3 tests failed.

I've could package it using --nocheck parameter to makepkg, but I suspect the issue persist, may be related with make version, I guess.

I can't reproduce this - does it work now? I guess it could've been an upstream bug that has been fixed already.

You can pass --nocheck to makepkg to skip the tests if necessary.

Packaging process fails to check() stage

67% tests passed, 3 tests failed out of 9

Total Test time (real) =   0.85 sec

The following tests FAILED:
      7 - ride_ratings (Failed)
      8 - multilaunch (Failed)
      9 - tile_elements (Failed)
Errors while running CTest
make: *** [Makefile:106: test] Error 8
==> ERROR: Se produjo un fallo en check().
    Cancelando...

thanks, I've added a dependency on icu.

I've also switched to the forked version of rapidjson so the package builds on GCC 8.1.

We merged https://github.com/OpenRCT2/OpenRCT2/pull/7385 which adds dependency on ICU

@goddisignz this is not the full error. GCC by default ignores -Wno-* options and will only display them once encountered actual error, which you skipped. We do test with GCC 8.1 in our CI setup and you may have ran into https://github.com/Tencent/rapidjson/issues/1205 which the upstream maintainers have not bothered to address for the last few months (please do go nag them). If that's the case, either disable discord-rpc (in PKGBUILD) or switch to my hacked version of rapidjson at <https://github.com/janisozaur/rapidjson> patch-1

I currently have a problem compiling the pacakage. I get the following error(s):

cc1plus: error: unrecognized command line option ‘-Wno-global-constructors’ [-Werror]

cc1plus: error: unrecognized command line option ‘-Wno-exit-time-destructors’ [-Werror]

cc1plus: error: unrecognized command line option ‘-Wno-covered-switch-default’ [-Werror]

cc1plus: error: unrecognized command line option ‘-Wno-c++98-compat-pedantic’ [-Werror]

cc1plus: error: unrecognized command line option ‘-Wno-c++98-compat’ [-Werror]

Can this be a problem related to the gcc version? I use the current 8.1.0.

imho it's good practice to run the unit tests where available, especially in a project like this as C/C++ have a lot of system-dependent behaviour - and fwiw I think building the main OpenRCT2 executable outweighs the time spent running the tests.

That said, you should be able to pass --nocheck to makepkg to skip running the tests if you want to (although it'll still build them - idk if there's a way we can detect --nocheck in the PKGBUILD).

Is there any point in "WITH_TESTS=on"? Seems like it's just going to increase the build time and provide no real benefit for users. It's mainly for the devs to test with.

We are aware of this and will have a fix soonish.

Upstream discord-rpc changed file name in one of their latest commits (discord-rpc.h -> discord_rpc.h) and to fix it you simply need to rename the relevant include. We have not changed the file name upstream yet because we are updating Windows' libraries at the same time.

Note that you can also choose to not use discord-rpc at all if you don't want to or use slightly older commit of it.

I've got issues with discord_register.h after your fix:

[  8%] Building CXX object CMakeFiles/libopenrct2.dir/src/openrct2/network/DiscordService.cpp.o
/home/wyre/AUR/openrct2-git/src/openrct2-git/src/openrct2/network/DiscordService.cpp:19:10: fatal error: discord-rpc.h: No such file or directory
 #include <discord-rpc.h>
          ^~~~~~~~~~~~~~~

thanks, fixed

The PKGBUILD seems to be broken: rmdir: failed to remove '/home/janisozaur/.cache/pacaur/openrct2-git/pkg/openrct2-git/usr/include': Directory not empty

Indeed, there is a lone file discord_register.h.