Arch Linux User Repository

Just an FYI, Pix is a fork of GThumb, so just about anything that applies to the latter applies to the former. ;)

working again, thank you

Confirmed patch work is fine unmodified, it's been added for 3.2.2-2

Thanks yochananmarqos for saving me time looking for it :)

@ion203: The patch found here is needed to rebuild on libjxl 0.9.0: https://gitlab.gnome.org/GNOME/gthumb/-/issues/306

this is failing to compile as of today

[256/720] Compiling C object extension...ro_io.so.p/cairo-image-surface-jxl.c.o
FAILED: extensions/cairo_io/libcairo_io.so.p/cairo-image-surface-jxl.c.o 
cc -Iextensions/cairo_io/libcairo_io.so.p -Iextensions/cairo_io -I../extensions/cairo_io -I. -I.. -Ipix -I../pix -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/gio-unix-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/cloudproviders -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/fribidi -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gsettings-desktop-schemas -I/usr/include/xapp -I/usr/include/libxml2 -I/usr/include/librsvg-2.0 -I/usr/include/webp -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fPIC -DHWY_SHARED_DEFINE -pthread -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_54 -Wall -Wno-deprecated-declarations -MD -MQ extensions/cairo_io/libcairo_io.so.p/cairo-image-surface-jxl.c.o -MF extensions/cairo_io/libcairo_io.so.p/cairo-image-surface-jxl.c.o.d -o extensions/cairo_io/libcairo_io.so.p/cairo-image-surface-jxl.c.o -c ../extensions/cairo_io/cairo-image-surface-jxl.c
../extensions/cairo_io/cairo-image-surface-jxl.c: In function ‘_cairo_image_surface_create_from_jxl’:
../extensions/cairo_io/cairo-image-surface-jxl.c:237:69: error: incompatible type for argument 2 of ‘JxlDecoderGetColorAsEncodedProfile’
  237 |                         if (JxlDecoderGetColorAsEncodedProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, NULL) == JXL_DEC_SUCCESS)
      |                                                                     ^~~~~~~~~~~~~
      |                                                                     |
      |                                                                     JxlPixelFormat *
In file included from ../extensions/cairo_io/cairo-image-surface-jxl.c:24:
/usr/include/jxl/decode.h:750:50: note: expected ‘JxlColorProfileTarget’ but argument is of type ‘JxlPixelFormat *’
  750 |     const JxlDecoder* dec, JxlColorProfileTarget target,
      |                            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:237:84: warning: passing argument 3 of ‘JxlDecoderGetColorAsEncodedProfile’ makes pointer from integer without a cast [-Wint-conversion]
  237 |                         if (JxlDecoderGetColorAsEncodedProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, NULL) == JXL_DEC_SUCCESS)
      |                                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                    |
      |                                                                                    int
/usr/include/jxl/decode.h:751:23: note: expected ‘JxlColorEncoding *’ but argument is of type ‘int’
  751 |     JxlColorEncoding* color_encoding);
      |     ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:237:29: error: too many arguments to function ‘JxlDecoderGetColorAsEncodedProfile’
  237 |                         if (JxlDecoderGetColorAsEncodedProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, NULL) == JXL_DEC_SUCCESS)
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/jxl/decode.h:749:29: note: declared here
  749 | JXL_EXPORT JxlDecoderStatus JxlDecoderGetColorAsEncodedProfile(
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:242:70: error: incompatible type for argument 2 of ‘JxlDecoderGetICCProfileSize’
  242 |                                 if (JxlDecoderGetICCProfileSize(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, &profile_size) > 0) {
      |                                                                      ^~~~~~~~~~~~~
      |                                                                      |
      |                                                                      JxlPixelFormat *
/usr/include/jxl/decode.h:776:50: note: expected ‘JxlColorProfileTarget’ but argument is of type ‘JxlPixelFormat *’
  776 |     const JxlDecoder* dec, JxlColorProfileTarget target, size_t* size);
      |                            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:242:85: warning: passing argument 3 of ‘JxlDecoderGetICCProfileSize’ makes pointer from integer without a cast [-Wint-conversion]
  242 |                                 if (JxlDecoderGetICCProfileSize(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, &profile_size) > 0) {
      |                                                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                     |
      |                                                                                     int
/usr/include/jxl/decode.h:776:66: note: expected ‘size_t *’ {aka ‘long unsigned int *’} but argument is of type ‘int’
  776 |     const JxlDecoder* dec, JxlColorProfileTarget target, size_t* size);
      |                                                          ~~~~~~~~^~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:242:37: error: too many arguments to function ‘JxlDecoderGetICCProfileSize’
  242 |                                 if (JxlDecoderGetICCProfileSize(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, &profile_size) > 0) {
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/jxl/decode.h:775:29: note: declared here
  775 | JXL_EXPORT JxlDecoderStatus JxlDecoderGetICCProfileSize(
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:248:73: error: incompatible type for argument 2 of ‘JxlDecoderGetColorAsICCProfile’
  248 |                                 if (JxlDecoderGetColorAsICCProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, profile_data, profile_size) > 0) {
      |                                                                         ^~~~~~~~~~~~~
      |                                                                         |
      |                                                                         JxlPixelFormat *
/usr/include/jxl/decode.h:794:50: note: expected ‘JxlColorProfileTarget’ but argument is of type ‘JxlPixelFormat *’
  794 |     const JxlDecoder* dec, JxlColorProfileTarget target, uint8_t* icc_profile,
      |                            ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:248:88: warning: passing argument 3 of ‘JxlDecoderGetColorAsICCProfile’ makes pointer from integer without a cast [-Wint-conversion]
  248 |                                 if (JxlDecoderGetColorAsICCProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, profile_data, profile_size) > 0) {
      |                                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                        |
      |                                                                                        int
/usr/include/jxl/decode.h:794:67: note: expected ‘uint8_t *’ {aka ‘unsigned char *’} but argument is of type ‘int’
  794 |     const JxlDecoder* dec, JxlColorProfileTarget target, uint8_t* icc_profile,
      |                                                          ~~~~~~~~~^~~~~~~~~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:248:119: warning: passing argument 4 of ‘JxlDecoderGetColorAsICCProfile’ makes integer from pointer without a cast [-Wint-conversion]
  248 |                                 if (JxlDecoderGetColorAsICCProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, profile_data, profile_size) > 0) {
      |                                                                                                                       ^~~~~~~~~~~~
      |                                                                                                                       |
      |                                                                                                                       guchar * {aka unsigned char *}
/usr/include/jxl/decode.h:795:12: note: expected ‘size_t’ {aka ‘long unsigned int’} but argument is of type ‘guchar *’ {aka ‘unsigned char *’}
  795 |     size_t size);
      |     ~~~~~~~^~~~
../extensions/cairo_io/cairo-image-surface-jxl.c:248:37: error: too many arguments to function ‘JxlDecoderGetColorAsICCProfile’
  248 |                                 if (JxlDecoderGetColorAsICCProfile(dec, &pixel_format, JXL_COLOR_PROFILE_TARGET_DATA, profile_data, profile_size) > 0) {
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/jxl/decode.h:793:29: note: declared here
  793 | JXL_EXPORT JxlDecoderStatus JxlDecoderGetColorAsICCProfile(
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[269/720] Compiling C++ object extensi.../libexiv2_tools.so.p/exiv2-utils.cpp.o
../extensions/exiv2_tools/exiv2-utils.cpp: In function ‘void add_string_list_to_metadata(GthMetadata*, const Exiv2::Metadatum&)’:
../extensions/exiv2_tools/exiv2-utils.cpp:331:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  331 |         for (int i = 0; i < value.count(); i++)
      |                         ~~^~~~~~~~~~~~~~~
../extensions/exiv2_tools/exiv2-utils.cpp: In function ‘void exiv2_read_metadata(Exiv2::Image::UniquePtr, GFileInfo*, gboolean)’:
../extensions/exiv2_tools/exiv2-utils.cpp:835:37: warning: catching polymorphic type ‘class std::out_of_range’ by value [-Wcatch-value=]
  835 |                       } catch (std::out_of_range) {
      |                                     ^~~~~~~~~~~~
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: pix-exit status 4

I see, Thanks for maintaining pix, and for the quick response :) rellieberman

rellieberman, I pushed this patch upsteam a few months ago, but it wasn't picked up in a release until 3.2.0 a couple weeks ago. I backported the patch here in the meantime because it was required to build prior to that new release. Or if you're referring to the 3.2.0 to 3.2.1 diff, that's because I forgot to remove the patch in the 3.2.0 commit :)

Hi, When I view your package's diff from the previous version I get a .patch from pix's upstream repository (https://github.com/linuxmint/pix/commit/46e19703a973d51fa97e6a22121560f5ba200eea - the patch that appears) you can also see the diff by clicking 'View Changes' here in AUR.

How did this file end up in you PKGBUILD repository?

Can you please add yelp to optdepends? I need yelp to use the GUI help.

3.0.2 working perfectly! Thanks