Package Details: return-to-the-roots-git r4319.fbaa134b-1

Git Clone URL: https://aur.archlinux.org/return-to-the-roots-git.git (read-only)
Package Base: return-to-the-roots-git
Description: Free/libre implementation of The Settlers II game engine
Upstream URL: https://siedler25.org/
Licenses: GPL3
Conflicts: return-to-the-roots, s25rttr, s25rttr-nightly-bin
Provides: return-to-the-roots
Submitter: Peuc
Maintainer: Peuc
Last Packager: Peuc
Votes: 2
Popularity: 0.002296
First Submitted: 2018-02-15 15:48
Last Updated: 2019-05-02 21:04

Required by (3)

Sources (14)

Latest Comments

« First ‹ Previous 1 2

klemens commented on 2018-02-16 18:07

This needs a dependency on libgl (and a make-dependency on mesa), otherwise it does not compile for me:

Could NOT find OpenGL (missing: OPENGL_opengl_LIBRARY OPENGL_glx_LIBRARY OPENGL_INCLUDE_DIR)

Peuc commented on 2018-02-15 15:53

Sure, create a new -git package for me to merge this one into and I will merge the comments + votes.

Done. Thanks for your help!

but if the software itself is written to depend on the name of an sh file (weird!)

Not the software itself, their (english written) documentation.

eschwartz commented on 2018-02-15 11:58

Sure, create a new -git package for me to merge this one into and I will merge the comments + votes.

re: rttr.sh, people should be able to figure out that /usr/bin/rttr is the same thing, but if the software itself is written to depend on the name of an sh file (weird!) then maybe it isn't worth the effort to fix this properly, and similarly for tracking the cmake.sh args -- although for my own packages I would. ;) I guess that is your call, anyway. They were somewhat subjective comments.

Peuc commented on 2018-02-15 06:51

Please fix this package to use a static release rather than the latest git master.

I'm not interested in maintaining a package for static releases.

The package is currently in violation of AUR guidelines. If you wish, you or anyone else can additionally upload a "return-to-the-roots-git" package that pulls from the latest git master.

Since you're TU, can you please rename this current package to "return-to-the-roots-git", so we can also keep comments history?

As Lucki's proposed PKGBUILD pointed out, if you are using git to download the sources you need to download that in source=() and tell git to reference those downloaded versions

Fixed.

This cmake.sh file looks really ugly

Indeed.

you can probably just use cmake directly rather than first using sed on a really badly written script. Just change all the --FOO= to -DFOO=

As written in comment, this not less ugly sed is just a workaround for a recent upstream bug - which I must admit I've not reported yet. However I prefer to stick with documented build procedure instead of inventing my own.

You should remove rttr.sh, and create a symlink to s25client instead.

Having a .sh file linking to a binary doesn't exactly look like a brilliant idea… I agree this script file is completely useless, but game documentation refers to it, so I must provide it with the package. As it, it's bare minimum to launch the game.

eschwartz commented on 2018-02-14 22:02

Please fix this package to use a static release rather than the latest git master. Either download the release archive or checkout a specific tag as described by the "USING VCS SOURCES" section of the PKGBUILD(5) manpage. The package is currently in violation of AUR guidelines. If you wish, you or anyone else can additionally upload a "return-to-the-roots-git" package that pulls from the latest git master.

As Lucki's proposed PKGBUILD pointed out, if you are using git to download the sources you need to download that in source=() and tell git to reference those downloaded versions, see https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_Submodules

This cmake.sh file looks really ugly, you can probably just use cmake directly rather than first using sed on a really badly written script. Just change all the --FOO= to -DFOO=

You should remove rttr.sh, and create a symlink to s25client instead.

Lucki commented on 2018-01-22 14:25

Hi Peuc

here's a fully working PKGBUILD. Please update this package - it doesn't work in the current state.

Lucki commented on 2017-10-11 23:54

I'm not sure what you're doing here. This package is not a developement version (-git) so it shouldn't make use of pkgver().
I've made some changes to the PKGBUILD [1] but it fails with a CMake error:

CMake Error at libsiedler2/cmake/Modules/FindClangFormat.cmake:60 (add_ClangFormat_files):
add_ClangFormat_files Function invoked with incorrect arguments for
function named: add_ClangFormat_files

[1]: https://ptpb.pw/ABm3jfx7HfXVl54dFbAv9m7YVqjY

Edit: Looks like the build error got fixed in later commits.
Also:
- Shouldn't 'mv "${pkgdir}/usr/lib64" "${pkgdir}/usr/lib"' be 'mv "${pkgdir}/usr/lib64" "${pkgdir}/usr/lib/s25rttr/"'?
- Is the .sh file necessary? You're setting the path with --RTTR_LIBDIR="lib/s25rttr"
- The whole folder /usr/bin/RTTR doesn't look usefull