Arch Linux User Repository

@newsboost I can't figure out that too. Looks like at the time this package was updated smartgit-linux-21_1_2.tar.gz on the site had different hash. And some time later the archive was changed.

Somehow I have 21.1.2-1 installed, but I can't find it's smartgit-linux-21_1_2.tar.gz in my yay cache so I can't prove the case.

I think @alyst (as packager) could verify my assumption and ask Smartgit devs why the hash was changed. If they admit that they changed the archive - then the packager should just update the hash. If they didn't change it then something strange is going on and should be investigated.

All this based on my understanding of the process, I am not specialist, so correct me if I am wrong.

If you want to update before this question will be sorted out you can change the hash for smartgit-linux-21_1_2.tar.gz to actual one "b38b7ba2a7fe2e272f32d6f423d953890c6e7840" in PKGBUILD before installation.

@simonzack About the JRE. In my opinion it would be appropriate to have two packages of smartgit - bundled with JRE and without it.

I always take the SHA1 from Syntevo website, but sometimes they silently update the package (and SHA1) without updating the version number. I've just updated the PKGBUILD to use the most recent .tar.gz.

hmm, ok @SapmoC: A different SHA-1 value. But what is the solution? I get this (see below), when I tried to upgrade today?

:: (1/1) Parsing SRCINFO: smartgit
==> Making package: smartgit 21.1.2-1 (Wed 20 Oct 2021 06:05:03 PM CEST)
==> Retrieving sources...
  -> Downloading smartgit-linux-21_1_2.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 94.2M  100 94.2M    0     0  34.5M      0  0:00:02  0:00:02 --:--:-- 34.5M
  -> Found smartgit.desktop
==> Validating source files with sha1sums...
    smartgit-linux-21_1_2.tar.gz ... FAILED
    smartgit.desktop ... Passed
==> ERROR: One or more files did not pass the validity check!
 -> error downloading sources: smartgit
     context: exit status 1


==> Making package: smartgit 21.1.2-1 (Wed 20 Oct 2021 06:05:06 PM CEST)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found smartgit-linux-21_1_2.tar.gz
  -> Found smartgit.desktop
==> Validating source files with sha1sums...
    smartgit-linux-21_1_2.tar.gz ... FAILED
    smartgit.desktop ... Passed
==> ERROR: One or more files did not pass the validity check!
 -> error making: smartgit

I see people discussing a java-issue, but not an installation issue? Validity check failed, sounds like a SHA-1 problem, why does this check fail and what is the solution (sorry for asking if it's obvious to everyone but me, I'm not used to these failed upgrades)?

On the page https://www.syntevo.com/smartgit/download/#installation-instructions specifies a different SHA-1 when downloading the package: b38b7ba2a7fe2e272f32d6f423d953890c6e7840

This is why the build fails.

@alyst You're right about the refresh problem.

Although I don't think the JRE issue is as bad as you think, as I use quite a few packages that have no bundled JRE. These include the JetBrains tools, and AUR (en) - pdfstudio-bin, which I co-maintain.

@simonzack Thanks for the suggestion. It would be nice to reduce the package size, but repackaging and making sure that SmartGit correctly works with the current ArchLinux version of Java introduces a lot of overhead. I think for this package it we should keep relying on the embedded Java version. But maybe if you can write to SmartGit support about the refresh problem, they can fix it upstream.

Continuing the discussion below, SmartGit can be started using the system JRE by doing:

$ env SMARTGIT_JAVA_HOME=/usr/lib/jvm/default/ /opt/smartgit/bin/smartgit.sh

This appears to work fine for me. This environment variable can be set in the .desktop file. In fact, I'm not sure if using the latest JRE (16) for me fixed a refresh bug, where SmartGit didn't refresh when files changed in the repo.

I think most people hava Java installed on the system anyway, so you could consider removing the embedded JRE in the PKGBUILD?

It seems to work for me.

I've updated GTK requirement to gtk3 and dropped java-runtime dependency. Let me know if you have troubles with the package.