Arch Linux User Repository

Why did you fuck up the icons now?

@xiota the icon patch you made is NOT correct and changes the tray icon too. It also does not include the various sizes of the actual icon.

static/icon.png is the tray icon. (should not be touched!) build/icon.icns is the actual app icon that electron-builder uses to generate the various icon sizes. libicns/icns2png is outdated and does not support the latest .icns features resulting in various sizes not being correctly extracted. The provided patch (modified from the electron-builder dev) utilizes electron-builder to properly generate and extract the icons and place them at their correct paths.

imagemagick, libicns and optipng are entirely unneeded as build deps. Please revert the latest patch and use the one provided as that produces the correct behaviour

This package wrongly using the Vencord icon was bothering me so here's a patch to use the official Vesktop icon instead of the Vencord one:

diff --git a/PKGBUILD b/PKGBUILD
index 1316d03..a9b801f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -8,7 +8,7 @@
 _pkgname="vesktop"
 pkgname="$_pkgname-git"
 pkgdesc="Custom Discord desktop app with Vencord preinstalled"
-pkgver=1.5.2.r19.gabd1e8c
+pkgver=1.5.3.r6.ge045341
 pkgrel=1
 url="https://github.com/Vencord/Vesktop"
 license=('GPL-3.0-only')
@@ -50,8 +50,11 @@ conflicts=(
 )

 _pkgsrc="$_pkgname"
-source=("$_pkgsrc"::"git+$url.git")
-sha256sums=('SKIP')
+source=(
+  "$_pkgsrc"::"git+$url.git"
+  "afterPack.js"
+)
+sha256sums=('SKIP' 'SKIP')

 pkgver() {
   cd "$_pkgsrc"
@@ -68,6 +71,8 @@ build() {
     -e '/linux/s&^&"electronDist": "/usr/lib/electron'"${_electron_version:-}"'",\n&' \
     -i "$_pkgsrc/package.json"

+  sed -E '/"beforePack": "scripts\/build\/sandboxFix.js",/a\ \ \ \ \ \ \ \ "afterPack": "'$srcdir'/afterPack.js",' -i "$_pkgsrc/package.json"
+
   cd "$_pkgsrc"
   pnpm install
   pnpm package:dir
@@ -77,7 +82,10 @@ package() {
   install -d "$pkgdir/$_install_path/$_pkgname"
   cp --reflink=auto -r "$_pkgsrc/dist/linux-unpacked/resources/app.asar" "$pkgdir/$_install_path/$_pkgname/"

-  install -Dm644 "$_pkgsrc/static/icon.png" "$pkgdir/usr/share/pixmaps/$_pkgname.png"
+  for _icons in 1024 512 256 128 64 48 32 16; do
+    install -Dm644 "$_pkgsrc/dist/.icon-set/icon_${_icons}.png" "$pkgdir/usr/share/icons/hicolor/${_icons}x${_icons}/apps/$_pkgname.png"
+  done
+
   install -Dm644 "$_pkgsrc/LICENSE" -t "$pkgdir/usr/share/licenses/$pkgname/"

   install -Dm755 /dev/stdin "$pkgdir/usr/bin/$_pkgname" << END
diff --git a/afterPack.js b/afterPack.js
new file mode 100644
index 0000000..5a3342c
--- /dev/null
+++ b/afterPack.js
@@ -0,0 +1,39 @@
+// https://github.com/electron-userland/electron-builder/issues/8309#issuecomment-2240821509
+const { existsSync, renameSync } = require("fs");
+const { join } = require("path");
+
+module.exports = afterPack = async context => {
+    const { packager } = context;
+    const { platformSpecificBuildOptions, config } = packager;
+
+    const sources = [platformSpecificBuildOptions.icon, (config.mac && config.mac.icon) || config.icon].filter(
+        str => !!str
+    );
+
+    // If no explicit sources are defined, fallback to buildResources directory, then default framework icon
+    let fallbackSources = [packager.getDefaultFrameworkIcon()];
+    const buildResources = config.directories && config.directories.buildResources;
+    if (buildResources && existsSync(join(buildResources, "icons"))) {
+        fallbackSources = [buildResources].concat(fallbackSources);
+    }
+
+    await packager.resolveIcon(sources, fallbackSources, "set");
+
+    const filesToRename = [
+        { old: "icon_16x16.png", new: "icon_16.png" },
+        { old: "icon_48x48.png", new: "icon_48.png" }
+    ];
+
+    filesToRename.forEach(file => {
+        const oldPath = join(config.directories.output, ".icon-set", file.old);
+        const newPath = join(config.directories.output, ".icon-set", file.new);
+        if (existsSync(oldPath)) {
+            renameSync(oldPath, newPath);
+        }
+    });
+};

If someone wants to comment on the vesktop package with an adapted patch of this be my guest.

Do you plan on updating it ? Vencord's at version 9.4.0 rn

on systems using the corepack installed version of PNPM, installation will fail.

==> Starting build()...
/home/aiden/.nvm/versions/node/v22.2.0/lib/node_modules/corepack/dist/lib/corepack.cjs:23242
      throw new UsageError(`No version specified for ${raw} in "packageManager" of ${source}`);
            ^

UsageError: No version specified for pnpm@ in "packageManager" of package.json
    at parseSpec (/home/aiden/.nvm/versions/node/v22.2.0/lib/node_modules/corepack/dist/lib/corepack.cjs:23242:13)
    at loadSpec (/home/aiden/.nvm/versions/node/v22.2.0/lib/node_modules/corepack/dist/lib/corepack.cjs:23316:11)
    at async Engine.findProjectSpec (/home/aiden/.nvm/versions/node/v22.2.0/lib/node_modules/corepack/dist/lib/corepack.cjs:23490:22)
    at async Engine.executePackageManagerRequest (/home/aiden/.nvm/versions/node/v22.2.0/lib/node_modules/corepack/dist/lib/corepack.cjs:23542:24)
    at async Object.runMain (/home/aiden/.nvm/versions/node/v22.2.0/lib/node_modules/corepack/dist/lib/corepack.cjs:24235:5) {
  clipanion: { type: 'usage' }
}

Node.js v22.2.0

Note from Ven:

https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vesktop#n30
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=vesktop-git#n64
package issue

vesktop fixed the issue previously: https://github.com/Vencord/Vesktop/commit/6b948668b9a700aa86ef7c5843d8ab10b668ebf6

I built it both with pnpm 9.1.1 and pnpm 9.1.2 and it seemed to work fine both times. I'm good for now :) Thanks for being a badass maintainer, we love you.

@JThundley It might be a pnpm issue, but I'm not sure. I'm unable to reproduce it on my system. Maybe try a clean rebuild if you haven't already with your AUR helper

Now it's complaining about the next version of pnpm lol: ERR_PNPM_BAD_PM_VERSION  This project is configured to use v9.1.0 of pnpm. Your current pnpm is v9.1.2

I ran export COREPACK_ENABLE_STRICT=0 per the warning and it built and starts without issue.

Should be good now, changed it to rely on node corepack instead