Package Details: winetricks-git 20220411.r7.g9f605b01-1

Git Clone URL: https://aur.archlinux.org/winetricks-git.git (read-only, click to copy)
Package Base: winetricks-git
Description: Script to install various redistributable runtime libraries in Wine.
Upstream URL: http://wiki.winehq.org/winetricks
Licenses: LGPL
Conflicts: bin32-winetricks, winetricks
Provides: winetricks
Submitter: robertfoster
Maintainer: robertfoster
Last Packager: robertfoster
Votes: 102
Popularity: 0.54
First Submitted: 2015-03-03 18:34 (UTC)
Last Updated: 2022-04-17 08:09 (UTC)

Required by (66)

Sources (1)

Latest Comments

1 2 3 Next › Last »

Scrumplex commented on 2022-04-04 16:52 (UTC)

My take is just the recommended pkgver() from the Arch Wiki:

From 9c559e3d7192ffc31b86d57075df8908a01c752e Mon Sep 17 00:00:00 2001
From: Sefa Eyeoglu <contact@scrumplex.net>
Date: Mon, 4 Apr 2022 18:51:38 +0200
Subject: [PATCH] fix pkgver()

---
 PKGBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PKGBUILD b/PKGBUILD
index 94760ec..8bdd7ec 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -19,7 +19,7 @@ source=("$pkgname::git+https://github.com/Winetricks/winetricks.git")

 pkgver() {
   cd "$pkgname"
-  git describe --long --tags | sed -r 's/-([0-9]+)-/.r\1./' | sed -r 's/-test//'
+  git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
 }

 package() {
-- 
2.35.1

noabody commented on 2022-04-03 00:05 (UTC)

Maybe this. Super hybrid of someone else's work:

  local _ver="$(git show -s --date=format:'%Y%m%d' --format="%cd")"
  printf "%s.r%s.g%s" "$_ver" "$(git rev-list "$(git rev-list --tags --no-walk --max-count=1)"..HEAD --count)" "$(git rev-parse --short HEAD)"

As of today it yields: 20220401.r1.g98041242

kescherAUR commented on 2022-04-02 09:59 (UTC)

@plasticbomb1986 That is very odd, but should be fixable by just replacing all hyphens with dots with an additional sed:

git show -s --date=format:'%Y%m%d' --format="%cd.$(git describe --long --tags | sed -r 's/-([0-9]+)-/.r\1./' | cut -d'.' -f2- | sed -r 's/-/\./g'

Perhaps not very elegant.

plasticbomb1986 commented on 2022-04-02 08:14 (UTC)

@kerscherAUR I just tried this, and it gives me: 20220401.r3.1-g98041242

And complain about the - right before commit id.

kescherAUR commented on 2022-03-26 20:20 (UTC) (edited on 2022-03-26 20:20 (UTC) by kescherAUR)

How about this hybrid approach:

git show -s --date=format:'%Y%m%d' --format="%cd.$(git describe --long --tags | sed -r 's/-([0-9]+)-/.r\1./' | cut -d'.' -f2-)"

This would simply take the latest commit date, add the revision number since the last tag and the commit hash. Seems fine to me, honestly.

This results in "20220320.r0.g71b2fb44" for me.

MarsSeed commented on 2022-03-26 13:52 (UTC)

Don't hardcode r0!

It's not only in violation of Arch VCS guidelines, but it will wreak havoc on Pacman versioning.

Each new untagged commit will randomly cause the new generated version to be either newer or older as far as Pacman sees it.

ufo_driver commented on 2022-03-26 11:55 (UTC) (edited on 2022-03-26 11:56 (UTC) by ufo_driver)

I changed pkgver() to this (though I don't like r0 hardcode)

git show -s --date=format:'%Y%m%d' --format=%cd.r0.g%h

And my version become 20220320.r0.g71b2fb4-1

MarsSeed commented on 2022-03-23 23:39 (UTC)

As for the current predicament, Pacman surely is a mathematician. XD

20211230 > 202203 :)

MarsSeed commented on 2022-03-23 23:27 (UTC) (edited on 2022-03-23 23:28 (UTC) by MarsSeed)

But also it turns out it was not a good idea to delete the -test part of the version tag in PKGBUILD pkgver().

If I was the maintainer of this AUR package, I'd change git describe to ignore the git version tags that don't conform to the pattern of starting with eight digits.

I'd also keep suffixes, with the transformation 12345678-suffix -> 12345678suffix.

MarsSeed commented on 2022-03-23 23:16 (UTC)

Winetricks is getting stupider and stupider with its version tags XD