Package Details: fooyin 0.8.1-2

Git Clone URL: https://aur.archlinux.org/fooyin.git (read-only, click to copy)
Package Base: fooyin
Description: A customisable music player.
Upstream URL: https://github.com/ludouzi/fooyin
Keywords: alsa audio cpp20 customizable ffmpeg linux music music-player qt taglib
Licenses: GPL-3.0-only
Submitter: zxp19821005
Maintainer: zxp19821005
Last Packager: zxp19821005
Votes: 19
Popularity: 2.93
First Submitted: 2024-01-24 02:38 (UTC)
Last Updated: 2024-10-22 00:48 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 Next › Last »

ZhangHua commented on 2024-08-28 10:40 (UTC) (edited on 2024-08-28 10:51 (UTC) by ZhangHua)

Please add git into makedepends or we will see that makechrootpkg in devtools complains that it cannot handle git protocol.

What's more, may you consider using archive instead git repository? An archive is a repository workspace only and it saves space on large repository. What's more, using archive can build this package with makechrootpkg without git installed. You can set 

source=(
    "${pkgname}-${pkgver}.tar.gz::${url}/archive/refs/tags/v${pkgver}.tar.gz"
)

and update checksum to use archive instead git repo. If you choose to use archive, please also update "${srcdir}/${pkgname}.git" in PKGBUILD with "${srcdir}/${pkgname}-${pkgver}".

Please also note that archive does not contain any git submodule, but it has 3rdparty/libvgm only, as you build this package with system libvgm, I think this is not a big problem.

djustice commented on 2024-08-27 20:56 (UTC)

0.6.0 builds but requires libvgm*git (aur) as deps.

zxp19821005 commented on 2024-07-03 00:00 (UTC)

@ZhangHua 谢谢反馈，已修复。

ZhangHua commented on 2024-07-01 11:22 (UTC)

@zxp19821005 Oh no, it is my fault that I misspelled, the correct arguments to cmake is -DBUILD_WERROR=ON and -DINSTALL_HEADERS=ON. Please correct it so we can build this package successfully.

What's more, it seems that you still do not remove !strip in PKGBUILD, which may result worse performance and larger space usage in final binary installed on users' computer.

zxp19821005 commented on 2024-07-01 04:37 (UTC)

@ZhangHua 感谢你的建议，已经按照你的建议进行了修改并更新了版本。

ZhangHua commented on 2024-06-29 11:51 (UTC)

Hello, thank you for maintaining such a awesome package. But I think there are still some points which can be improved:

  • Remove conflicts=("fooyin"). pkgname has already in the check list, so there is no need to add it into conflicts. See here for more info.
  • Remove base-devel in makedepends. AUR packages are always assumed to be built with base-devel installed. If you want to use some tools in base-devel, please write them directly, but this is no needed for an AUR package. You can check here for more info.
  • Remove options=("!strip"). Stripping package is important, and I tested building this package with strip enabled, there seems no problem to run main functions normally.
  • Add -DBUILD_WERROR=ON and DINSTALL_HEADERS=ON in cmake arguments. Actually I want to enable all features in CMakeLists.txt, but BUILD_TESTING will be failed even I installed gtest, BUILD_ASAN will result a crash when starts app. BUILD_WERROR is easy to understand so I do not give it too much word. INSTALL_HEADERS is preferred to be enabled because Arch Linux usually packages headers with main package, this does not like other distributions, other distributions may split headers into another packages like fooyin-dev or fooyin-devel. You can run pacman -Qo /usr/include to find that there are so many packages ship their headers.

Martchus commented on 2024-05-20 18:18 (UTC)

Thanks for adding the fixes.

zxp19821005 commented on 2024-05-20 04:26 (UTC)

@Martchus @nl6720 Thank you for your guidance, it has been fixed.

Martchus commented on 2024-05-19 23:10 (UTC)

The architecture has to be x86_64 (plus maybe some additional concrete archs) but not any because the built package contains architecture-specific contents (see https://wiki.archlinux.org/title/PKGBUILD#arch).

nl6720 commented on 2024-05-19 16:10 (UTC)

libpipewire should be added to makedepends otherwise /usr/lib/fooyin/plugins/fyplugin_pipewire.so is not built.

Also, CMAKE_BUILD_TYPE should be set to None per https://wiki.archlinux.org/title/CMake_package_guidelines.

« First ‹ Previous 1 2 3 4 Next › Last »