Package Details: fooyin 0.8.1-2

Git Clone URL: https://aur.archlinux.org/fooyin.git (read-only, click to copy)
Package Base: fooyin
Description: A customisable music player.
Upstream URL: https://github.com/ludouzi/fooyin
Keywords: alsa audio cpp20 customizable ffmpeg linux music music-player qt taglib
Licenses: GPL-3.0-only
Submitter: zxp19821005
Maintainer: zxp19821005
Last Packager: zxp19821005
Votes: 15
Popularity: 1.14
First Submitted: 2024-01-24 02:38 (UTC)
Last Updated: 2024-10-22 00:48 (UTC)

Dependencies (27)

Required by (0)

Sources (1)

Latest Comments

« First ‹ Previous 1 2 3 Next › Last »

ZhangHua commented on 2024-06-29 11:51 (UTC)

Hello, thank you for maintaining such a awesome package. But I think there are still some points which can be improved:

  • Remove conflicts=("fooyin"). pkgname has already in the check list, so there is no need to add it into conflicts. See here for more info.
  • Remove base-devel in makedepends. AUR packages are always assumed to be built with base-devel installed. If you want to use some tools in base-devel, please write them directly, but this is no needed for an AUR package. You can check here for more info.
  • Remove options=("!strip"). Stripping package is important, and I tested building this package with strip enabled, there seems no problem to run main functions normally.
  • Add -DBUILD_WERROR=ON and DINSTALL_HEADERS=ON in cmake arguments. Actually I want to enable all features in CMakeLists.txt, but BUILD_TESTING will be failed even I installed gtest, BUILD_ASAN will result a crash when starts app. BUILD_WERROR is easy to understand so I do not give it too much word. INSTALL_HEADERS is preferred to be enabled because Arch Linux usually packages headers with main package, this does not like other distributions, other distributions may split headers into another packages like fooyin-dev or fooyin-devel. You can run pacman -Qo /usr/include to find that there are so many packages ship their headers.

Martchus commented on 2024-05-20 18:18 (UTC)

Thanks for adding the fixes.

zxp19821005 commented on 2024-05-20 04:26 (UTC)

@Martchus @nl6720 Thank you for your guidance, it has been fixed.

Martchus commented on 2024-05-19 23:10 (UTC)

The architecture has to be x86_64 (plus maybe some additional concrete archs) but not any because the built package contains architecture-specific contents (see https://wiki.archlinux.org/title/PKGBUILD#arch).

nl6720 commented on 2024-05-19 16:10 (UTC)

libpipewire should be added to makedepends otherwise /usr/lib/fooyin/plugins/fyplugin_pipewire.so is not built.

Also, CMAKE_BUILD_TYPE should be set to None per https://wiki.archlinux.org/title/CMake_package_guidelines.

<deleted-account> commented on 2024-05-17 18:20 (UTC)

Works perfectly now. Thanks zxp19821005 !

zxp19821005 commented on 2024-05-16 06:03 (UTC)

nl6720 Thanks for your feedback,I've forgot to delete the redundant code,fixed it.

nl6720 commented on 2024-05-16 05:38 (UTC)

Does not build in a clean chroot:

==> Starting build()...
sed: can't read /build/fooyin/src/fooyin.sh: No such file or directory
==> ERROR: A failure occurred in build().
    Aborting...

zxp19821005 commented on 2024-05-16 02:51 (UTC)

@uint2048_t Thanks for your feedback, fixed it.

<deleted-account> commented on 2024-05-14 23:33 (UTC)

This package doesn't work correctly for me. fooyin complains about missing plugins on startup. The fooyin-git package doesn't have this issue.

« First ‹ Previous 1 2 3 Next › Last »