Arch Linux User Repository

Suggested changes to follow community/freerdp.

Comments:

• I took advantage of the fact that github is not case sensitive and used lowercase for the source url.
• Maybe the docbook patch should be avoided as it might break in the future and require maintenance.
• Maybe the community package maintainer and contributors should be added as contributors here and not in the suggested format.
• With version 2.0.0 finally released I switched to use the stable release (actually freerdp-gstfree) so I most likely won't have freerdp-git installed on my system and won't keep track if this will break in the future.

Please synchronize PKGBUILD with community/freerdp, it brings wayland support and many other goodies: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/freerdp

Also please update source from git:// to git+https://

Can the depends please be fixed. It is currently impossible to build guacamole-server with rdp support without this package ...

The makedepends have to be adjusted from damageproto to xorgproto.

[ 36%] Linking C shared library libwinpr2.so [ 36%] Built target winpr make: *** [Makefile:152: all] Error 2

Update packagebuild to this, for download latest rc4 with enabled printer option which is currently not enabled in the package.

Maintainer: Christian Hesse mail@eworm.de

Contributor: Alexey Vasiliev robbinton@gmail.com

pkgname=freerdp-git pkgdesc='Free RDP client - git checkout' pkgver=2.0.0.rc4.r81.g7ad24b606 pkgrel=1 depends=('openssl' 'libxcursor' 'libcups' 'alsa-lib' 'libxext' 'libxdamage' 'ffmpeg' 'libxkbfile' 'libxinerama' 'libxv' 'openh264') makedepends=('git' 'krb5' 'cmake' 'damageproto') arch=('i686' 'x86_64') url="http://www.freerdp.com/" license=('GPL') provides=('freerdp') conflicts=('freerdp') source=('freerdp::git://github.com/FreeRDP/FreeRDP.git') sha256sums=('SKIP')

pkgver() { cd freerdp/

if GITTAG="$(git describe --abbrev=0 --tags 2>/dev/null)"; then
    printf '%s.r%s.g%s' \
        "$(sed -e "s/^${pkgname%%-git}//" -e 's/^[-_/a-zA-Z]\+//' -e 's/[-_+]/./g' <<< ${GITTAG})" \
        "$(git rev-list --count ${GITTAG}..)" \
        "$(git rev-parse --short HEAD)"
else
    printf '0.r%s.g%s' \
        "$(git rev-list --count master)" \
        "$(git rev-parse --short HEAD)"
fi

}

build() { cd freerdp/

cmake \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DCMAKE_INSTALL_LIBDIR=lib \
    -DWITH_PULSE=ON \
    -DWITH_SERVER=ON \
    -DWITH_OPENH264=ON \
    -DWITH_CUPS=ON \
    .
make

}

package() { cd freerdp/

make DESTDIR="${pkgdir}/" install

}

Please use git rev-parse --short HEAD instead of git log -1 --format='%h' in pkgver. I have log.showSignature enabled in my git config, and it prevents this packing from being built.

I'm having problems while building:

CheckSymbolExists.c:(.text.startup+0x3): Warning: undefined Reference to »pthread_mutex_timedlock«

Anybody knows a fix?

The file has FREERDP_VERSION_SUFFIX, which you ignore completely.

However... If the developers want a version string starting with 2.0 (for beta, rc, final or whatever) they should just tag it. This is a git package, so we use git tag.

I am taking it from the source's version numbering. I fail to see how the developers versioning is wrong, as it is their code.