Arch Linux User Repository

@whynothugo Thanks, I added a prepare() step to fetch all dependencies. Let me know if that works for you.

I'm undecided about --all-features. I'd prefer to be able to build a single binary that works for all. Unfortunately that does not currently seem to be possible.

The only issue seems to be --with-dns-sd, which overrides the default mDNS implementation: https://github.com/librespot-org/librespot/blob/dev/discovery/src/lib.rs#L106

From the wiki: https://github.com/librespot-org/librespot/wiki/Compiling#with-dns-sd "If with-dns-sd is enabled, librespot will crash if Avahi or Bonjour is not running. On the other hand, if with-dns-sd was not enabled, librespot might interfere with Avahi, Bonjour or other librespot instances if running, or even crash on some OSs."

If we add it, we break people without avahi. If we don't we break people with avahi.

I feel like staying with --all-features, and suggest everyone to run avahi. Could you elaborate if that's an option for you, or why not?

IMO this should be reported upstream, with a PR adding a CLI parameter to choose mDNS even if dns-sd is built in.

The --frozen flag is problematic. This flag indicates that no network access should happen so build fails:

==> Starting build()...
error: failed to get `base64` as a dependency of package `librespot v0.2.0 (/build/librespot-git/src/librespot)`

Caused by:
  attempting to make an HTTP request, but --frozen was specified
==> ERROR: A failure occurred in build().

This probably worked for you since you have everything in local cache -- building on a clean chroot (or cleaning up all cache and alike) will surface the error too.

I also noticed you added --all-features. This flag is also problematic, since it causes librespot to crash at startup if using systemd-resolved instead of avahi. The upstream default is safe, in that it works on any environment.

I think what @leonardder intended was for this to be built with pulseaudio support (or some other specific feature maybe?), but a blanked --all-features just makes this unusable for some of us. Generally following upstream as close as possible is the best practice.

@leonardder Updated, builds now with all features.

Could you consider making this package more similar to https://aur.archlinux.org/packages/librespot/ in how it builds (i.e. with all features instead of only Alsa)?

@whynothugo: Done, thanks for the patch.

Can you also install the systemd user service file?

diff --git a/PKGBUILD b/PKGBUILD
index dc57ac8..295710d 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -37,6 +37,8 @@ package()
         "$pkgdir"/usr/bin/librespot
     install -D -m 644 "$_pkgname"/contrib/librespot.service \
         "$pkgdir"/usr/lib/systemd/system/librespot.service
+    install -D -m 644 "$_pkgname"/contrib/librespot.user.service \
+        "$pkgdir"/usr/lib/systemd/user/librespot.service
     install -D -m 644 "$_pkgname"/LICENSE \
         "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
 }

@jack_slayton: Done, thanks!

As https://github.com/plietar/librespot is not longer actively maintained, you could consider switching to https://github.com/librespot-org/librespot

@aerosq Thanks, added aarch64.

Successfully compiled on ODROID C2. You may add aarch64 to the architecture list.