Arch Linux User Repository

won't compile

-- Build files have been written to: /home/tho/.cache/yay/libtd/src/build
[  0%] Built target generate_mime_types_gperf
[  0%] Built target tdmime_auto
[ 82%] Built target tdutils
[ 88%] Built target tdtl
[ 88%] Built target generate_json
[ 88%] Built target tl-parser
[ 88%] Generate TLO files
Error in parse:
Error near line 10 pos 11: `Can not parse nat const`
make[3]: *** [td/generate/CMakeFiles/tl_generate_tlo.dir/build.make:75: td/generate/CMakeFiles/tl_generate_tlo] Error 1
make[2]: *** [CMakeFiles/Makefile2:796: td/generate/CMakeFiles/tl_generate_tlo.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:358: CMakeFiles/prepare_cross_compiling.dir/rule] Error 2
make: *** [Makefile:179: prepare_cross_compiling] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

real    4.933
mem 22KB

I wonder what is so special about the sources of libtd that it takes literally almost an hour on my desktop to compile? All other packages I've encountered compile at most for a couple of minutes in the same environment. Even those that are seemingly more complex in their functionality than just a chat client.

@kovdan01 thanks for the patch. Could you please git send-email the patch to j.r@jugendhacker.de? Because I somehow can't git am it from my clipboard.

Hello @j.r ! Please consider using cmake wrappers instead of make commands in PKGBUILD. When a custom CMAKE_GENERATOR environment variable is set, we have to use something like cmake --build . --target all instead of just make. The same applies to make install. I've prepared a patch for that. Would be glad if you apply it using git am to save my credits in commit history. Thanks!

From 90960f8d105d1ba7c7c23d133bf1585427efd5b1 Mon Sep 17 00:00:00 2001
From: Daniil Kovalev <daniil@kovalev.website>
Date: Fri, 25 Nov 2022 16:40:15 +0300
Subject: [PATCH] Use cmake build and install wrappers instead of make ones

In case of custom `CMAKE_GENERATOR` environment variable (e.g. `Ninja`) we
have to use cmake wrappers instead of raw make commands in order to support
different build systems.
---
 PKGBUILD | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/PKGBUILD b/PKGBUILD
index 8d52dbf..e7b9d6f 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -31,14 +31,14 @@ build() {
        CC=/usr/bin/clang
        CXX=/usr/bin/clang++
        cmake -B build -S "$pkgname" -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_PREFIX:PATH="$pkgdir/usr" -Wno-dev
-       make -C build prepare_cross_compiling
+       cmake --build build --target prepare_cross_compiling
        cd "$pkgname"
        php SplitSource.php
        cd ..
-       make -C build
+       cmake --build build --target all
 }

 package() {
        cd "$srcdir"
-       make -C build install
+       cmake --build build --target install
 }
-- 
2.38.1

Should telegram-tdlib (=${pkgver}) be added to the provides array? For the package libtd-dev that is the case.

@djmattyg007 I updated the package according to cmake package guidelines, but unfortunately upstream somehow added compile tasks to the install target. I think there is not much I can do to avoid compilation in the package step. If you have a solution feel free to send me a patch over at sr.ht

I just built the latest version of this package, and I found that compilation was happening inside the package() function. This doesn't seem correct - compilation should be complete once build() is finished.

Okay thank you for the precision ^^

@franck.stauffer I'll remove make, but I explicitly set clang, because according to the libtd build instructions it does consume less RAM during build. For many multiple users the build failed before because they ran out of RAM.