Package Details: mcpelauncher-linux 1.1.2-2

Git Clone URL: https://aur.archlinux.org/mcpelauncher-linux.git (read-only, click to copy)
Package Base: mcpelauncher-linux
Description: Minecraft: Pocket Edition launcher for Linux
Upstream URL: https://github.com/minecraft-linux/mcpelauncher-manifest
Licenses: GPL-3.0-only
Provides: mcpelauncher-client
Submitter: HurricanePootis
Maintainer: HurricanePootis
Last Packager: HurricanePootis
Votes: 7
Popularity: 2.82
First Submitted: 2024-06-12 01:51 (UTC)
Last Updated: 2025-01-26 22:15 (UTC)

Dependencies (96)

Required by (2)

Sources (32)

Latest Comments

1 2 Next › Last »

docquantum commented on 2025-02-09 06:31 (UTC)

Also, not sure if the package needs to be changed to facilitate the fix for this bug: https://github.com/minecraft-linux/mcpelauncher-manifest/issues/1079

Or if I'm doing something wrong, but the suggestion is to add -DNDEBUG as a build arg to prevent the "Please check your Keyboard Layout. No Fallback Implemented" window from popping up whenever clicking on non-game keys (e.g. super)

index f3299ac..14b7c3b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -138,6 +138,7 @@ build() {
        -DCMAKE_CXX_COMPILER=clang++
        -DCMAKE_BUILD_TYPE=None
        -DENABLE_DEV_PATHS=OFF
+       -DCMAKE_CXX_FLAGS="-DNDEBUG"
        -Wno-dev
        )
        cmake -B build "${_args[@]}"

I'm not sure if this is the right place for it since there is a "debug" binary that is created that would ideally not be built with this flag.

docquantum commented on 2025-02-09 06:05 (UTC) (edited on 2025-02-09 06:11 (UTC) by docquantum)

I wasn't able to get this to build on Linux 6.13.1 because of SDL3 failing to build due to not being able to find linux/blkdev.h as part of the uring submodule. This might be a missing import since I have linux-headers installed and everything needed for the file to exist.

Not sure if that's related to the packaging or the actual repo.

I was able to get around it by adding -DSDL_LIBURING=OFF to the _args in the build() function:

index f3299ac..87aa16c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -138,6 +138,7 @@ build() {
        -DCMAKE_CXX_COMPILER=clang++
        -DCMAKE_BUILD_TYPE=None
        -DENABLE_DEV_PATHS=OFF
+       -DSDL_LIBURING=OFF
        -Wno-dev
        )
        cmake -B build "${_args[@]}"

The original error:

Building C object sdl3/CMakeFiles/SDL3-static.dir/src/file/io_uring/SDL_asyncio_liburing.c.o
FAILED: sdl3/CMakeFiles/SDL3-static.dir/src/file/io_uring/SDL_asyncio_liburing.c.o
/usr/bin/clang -DSDL_BUILD_MAJOR_VERSION=3 -DSDL_BUILD_MICRO_VERSION=7 -DSDL_BUILD_MINOR_VERSION=1 -DSDL_STATIC_LIB -DUSING_GENERATED_CONFIG_H -I/home/docquantum/.cache/yay/mcpelauncher-linux/src/build/sdl3/include-config-none/build_config -I/home/docquantum/.cache/yay/mcpelauncher-linux/src/build/sdl3/include-revision -I/home/docquantum/.cache/yay/mcpelauncher-linux/src/mcpelauncher-manifest/sdl3/include -I/home/docquantum/.cache/yay/mcpelauncher-linux/src/mcpelauncher-manifest/sdl3/src -isystem /usr/include/pipewire-0.3 -isystem /usr/include/spa-0.2 -isystem /usr/include/libdrm -isystem /usr/include/dbus-1.0 -isystem /usr/lib/dbus-1.0/include -isystem /usr/include/ibus-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/sysprof-6 -isystem /usr/include/libusb-1.0 -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/home/docquantum/.cache/yay/mcpelauncher-linux/src=/usr/src/debug/mcpelauncher-linux -flto=auto-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=/home/docquantum/.cache/yay/mcpelauncher-linux/src=/usr/src/debug/mcpelauncher-linux -flto=auto -flto=thin -Wall -Wundef -Wfloat-conversion -fno-strict-aliasing -Wdocumentation -Wdocumentation-unknown-command -fcomment-block-commands=threadsafety -Wshadow -Wno-unused-local-typedefs -Wimplicit-fallthrough -fcolor-diagnostics -idirafter/home/docquantum/.cache/yay/mcpelauncher-linux/src/mcpelauncher-manifest/sdl3/src/video/khronos -D_REENTRANT -Winvalid-pch -Xclang -include-pch -Xclang /home/docquantum/.cache/yay/mcpelauncher-linux/src/build/sdl3/CMakeFiles/SDL3-static.dir/cmake_pch.h.pch -Xclang -include -Xclang /home/docquantum/.cache/yay/mcpelauncher-linux/src/build/sdl3/CMakeFiles/SDL3-static.dir/cmake_pch.h -MD -MT sdl3/CMakeFiles/SDL3-static.dir/src/file/io_uring/SDL_asyncio_liburing.c.o -MF sdl3/CMakeFiles/SDL3-static.dir/src/file/io_uring/SDL_asyncio_liburing.c.o.d -o sdl3/CMakeFiles/SDL3-static.dir/src/file/io_uring/SDL_asyncio_liburing.c.o -c /home/docquantum/.cache/yay/mcpelauncher-linux/src/mcpelauncher-manifest/sdl3/src/file/io_uring/SDL_asyncio_liburing.c
In file included from /home/docquantum/.cache/yay/mcpelauncher-linux/src/mcpelauncher-manifest/sdl3/src/file/io_uring/SDL_asyncio_liburing.c:32:
In file included from /usr/include/liburing.h:17:
/usr/include/liburing/compat.h:11:10: fatal error: 'linux/blkdev.h' file not found
   11 | #include <linux/blkdev.h>
      |          ^~~~~~~~~~~~~~~~

asalde_le1 commented on 2024-08-19 08:07 (UTC)

@HurricanePootis Thank you very much for your kind words and for your work on this package!

HurricanePootis commented on 2024-08-19 03:55 (UTC)

@asalde_le1

Don't be sorry that you asked questions. Asking questions is the best way to learn. Sorry if I came across rude. You did a good thing reaching out to me with your concerns, even if in the end they ended up being not true. Without you, I wouldn't have gone again and checked the flags to get it building. So, thank you for motivating me to do a deeper check!

asalde_le1 commented on 2024-08-19 03:30 (UTC)

@HurricanePootis thank you for the detailed answer. Sorry if some of my questions were dumb.

HurricanePootis commented on 2024-08-19 03:05 (UTC) (edited on 2024-08-19 03:42 (UTC) by HurricanePootis)

@asalde_le1

  1. Setting DCMAKE_BUILD_TYPE to Release is not advised by the CMake package guidelines, as it overrides the makeflags set for Arch Linux
  2. The reason why you thinking specifying -stdlib=c++17 fixed the issue is because by giving cmake the arugment -DCMAKE_CXX_FLAGS="-stdlib=c++17", you are not passing along the $CXXFLAGS variable to Cmake as defined in /etc/makepkg.conf, where the -Wp,-D_FORTIFY_SOURCE-3 is. The project currently builds and is able to run as is. If the project requires C++17, then it will be automatically set in Cmake as needed by the developers. Edit: mcpelauncher-manifest's CMakeLists.txt does set C++17 as a standard, no need for the flag.
  3. If you would to read the PKGBUILD, -DENABLE_DEV_PATHS=OFF is already set

asalde_le1 commented on 2024-08-19 00:23 (UTC)

Also please add -DENABLE_DEV_PATHS=OFF option and change DCMAKE_BUILD_TYPE to Release. And the v1.0.0-qt6 version is released

asalde_le1 commented on 2024-08-19 00:01 (UTC)

@HurricanePootis in ci configs in official repos they specify c++ 17 standard, that fixes the problem for me. Maybe the better way is to specify 17 standard?

HurricanePootis commented on 2024-08-18 18:12 (UTC)

@asalde_le1 the problem was not the C++ standard, it was -Wp,-D_FORTIFY_SOURCE=3. I am pushing an update rn to fix this.

asalde_le1 commented on 2024-08-18 15:32 (UTC) (edited on 2024-08-18 16:29 (UTC) by asalde_le1)

The problem is that by default the compiler uses C++ 14 instead of 17, that is required. Here is the patch to fix this problem:

diff --git a/PKGBUILD b/PKGBUILD
index 8815f6e..cf32916 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -133,7 +133,8 @@ build() {
     -B build -DCMAKE_INSTALL_PREFIX=/usr \
     -DCMAKE_BUILD_TYPE=RelWithDebInfo \
     -DENABLE_DEV_PATHS=OFF \
-    -Wno-dev
+    -Wno-dev \
+    -DCMAKE_CXX_FLAGS="--std=c++17"
   cmake --build build --parallel
 }

1 2 Next › Last »