Arch Linux User Repository

In any case, this package should not have been updated to 0.11.6 in the first place. Whether we assume older revisions to be similarly breached is a different (albeit important) topic. (EDIT: Also, confirming that the vendored dependencies match what is upstream should be relatively easy, right?)

@timschumi 0.11.5 is not known-good. The package history as a whole is suspect according to the developer. Their comments here indicate they do not know if any part of the project is uncompromised: https://github.com/lawl/NoiseTorch/issues/253#issuecomment-1130597691

Why is this updated to 0.11.6? 0.11.6 is the "this may have been compromised, do not use this." release. Stay at the known-good revision, 0.11.5 (EDIT: and preferably lock it to the last known-good commit, 8a918f9076ea057c505fd92bc85b080e125b15d5).

To solve these issues once and for all I created this PR here: https://github.com/lawl/NoiseTorch/pull/129

With it we can now define version and distribution build-time, as well as disable the updater similarly.

Fine with me. Version seems to be set just fine if referenced by commit. But I don't think we need pkgver(), I expect this to be bumped manually.

Not to piss on anyones work here. I don't think that you should use git tags as build source, since they can be manipulated by enforcing a new commit to be this and that tag. (correct me if I'm wrong here)

I'd suggest using the commit hash directly. In case of 0.10.1 it's this one: https://github.com/lawl/NoiseTorch/commit/ee91fea993138624dce47b4c0b626a99db25f656 so -> ee91fea993138624dce47b4c0b626a99db25f656

Here the example pkgbuild

# Maintainer:  Travis Collins <erbrecht at pobox dot com>
# Contributor: Justin Kromlinger <hashworks@archlinux.org>

# Note: The upstream maintainer does not allow ANY modifications
# to the source code. Please refrain from doing so.
# https://lists.archlinux.org/pipermail/aur-general/2021-May/036230.html

pkgname=noisetorch
pkgver=0.10.1
pkgrel=5
pkgdesc='Real-time microphone noise suppression on Linux.'
arch=('x86_64')
url=https://github.com/lawl/NoiseTorch
license=('GPL3')
depends=('pulseaudio' 'polkit')
makedepends=('go' 'cmake' 'git')
provides=('noisetorch')
install="${pkgname}.install"
_commit=ee91fea993138624dce47b4c0b626a99db25f656
source=("git+${url}#commit=${_commit}"
        "${pkgname}.install")
sha256sums=('SKIP'
            '171a4179c7e0f3a018a314893e81e598c02cfee274c90d715a302660af920eba')

pkgver() {
  cd NoiseTorch
  git describe --tags | sed 's/-/+/g'
}

build() {
    export GOPATH="$srcdir/go"
    cd NoiseTorch/c/ladspa
    make
    cd ${srcdir}/NoiseTorch
    export CGO_CPPFLAGS="${CPPFLAGS}"
    export CGO_CFLAGS="${CFLAGS}"
    export CGO_CXXFLAGS="${CXXFLAGS}"
    export CGO_LDFLAGS="${LDFLAGS}"
    export GOFLAGS="-buildmode=pie -trimpath -ldflags=-linkmode=external -mod=readonly -modcacherw"
    go generate
    go build -o bin/noisetorch
    go clean -modcache
}

package() {
    cd NoiseTorch
    install -D -m755 bin/noisetorch "${pkgdir}/usr/bin/noisetorch"
    install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
    install -D -m644 assets/noisetorch.desktop "${pkgdir}/usr/share/applications/noisetorch.desktop"
    install -D -m644 assets/icon/LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/icon-LICENSE"
    install -D -m644 assets/icon/noisetorch.png "${pkgdir}/usr/share/icons/hicolor/256x256/apps/noisetorch.png"
}

The changes are

_commit=ee91fea993138624dce47b4c0b626a99db25f656
source=("git+${url}#commit=${_commit}"

To get the source by commit as well as

pkgver() {
  cd NoiseTorch
  git describe --tags | sed 's/-/+/g'
}

To generate the pkgver by the git tag of that commit.

@Fumon thanks, i updated the package this this updated patch, now noisetorch can be installed normaly

If you're running into the same error as @foxite @karthikjayd and @mnqn on version 0.10.1-3, the patch file needs an update.

If you're doing a manual build, change main.patch to,

--- main.go     2021-05-16 15:53:15.287331017 -0400
+++ src/NoiseTorch-0.10.1/main.go       2021-05-16 15:53:21.954164782 -0400
@@ -25,7 +25,6 @@
        "github.com/aarzilli/nucular/style"
 )

-//go:generate go run scripts/embedversion.go
 //go:generate go run scripts/embedlicenses.go

 //go:embed c/ladspa/rnnoise_ladspa.so

Then run updpkgsums and the package should build properly.

I'm facing the same Issue as @karthikjayd and @foxite. Package broken.

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error making: noisetorch

I am facing the same issue that @foxite has pointed out.

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
:: Packages failed to build: noisetorch-0.10.1-3