Arch Linux User Repository

To solve these issues once and for all I created this PR here: https://github.com/lawl/NoiseTorch/pull/129

With it we can now define version and distribution build-time, as well as disable the updater similarly.

Fine with me. Version seems to be set just fine if referenced by commit. But I don't think we need pkgver(), I expect this to be bumped manually.

Not to piss on anyones work here. I don't think that you should use git tags as build source, since they can be manipulated by enforcing a new commit to be this and that tag. (correct me if I'm wrong here)

I'd suggest using the commit hash directly. In case of 0.10.1 it's this one: https://github.com/lawl/NoiseTorch/commit/ee91fea993138624dce47b4c0b626a99db25f656 so -> ee91fea993138624dce47b4c0b626a99db25f656

Here the example pkgbuild

# Maintainer:  Travis Collins <erbrecht at pobox dot com>
# Contributor: Justin Kromlinger <hashworks@archlinux.org>

# Note: The upstream maintainer does not allow ANY modifications
# to the source code. Please refrain from doing so.
# https://lists.archlinux.org/pipermail/aur-general/2021-May/036230.html

pkgname=noisetorch
pkgver=0.10.1
pkgrel=5
pkgdesc='Real-time microphone noise suppression on Linux.'
arch=('x86_64')
url=https://github.com/lawl/NoiseTorch
license=('GPL3')
depends=('pulseaudio' 'polkit')
makedepends=('go' 'cmake' 'git')
provides=('noisetorch')
install="${pkgname}.install"
_commit=ee91fea993138624dce47b4c0b626a99db25f656
source=("git+${url}#commit=${_commit}"
        "${pkgname}.install")
sha256sums=('SKIP'
            '171a4179c7e0f3a018a314893e81e598c02cfee274c90d715a302660af920eba')

pkgver() {
  cd NoiseTorch
  git describe --tags | sed 's/-/+/g'
}

build() {
    export GOPATH="$srcdir/go"
    cd NoiseTorch/c/ladspa
    make
    cd ${srcdir}/NoiseTorch
    export CGO_CPPFLAGS="${CPPFLAGS}"
    export CGO_CFLAGS="${CFLAGS}"
    export CGO_CXXFLAGS="${CXXFLAGS}"
    export CGO_LDFLAGS="${LDFLAGS}"
    export GOFLAGS="-buildmode=pie -trimpath -ldflags=-linkmode=external -mod=readonly -modcacherw"
    go generate
    go build -o bin/noisetorch
    go clean -modcache
}

package() {
    cd NoiseTorch
    install -D -m755 bin/noisetorch "${pkgdir}/usr/bin/noisetorch"
    install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
    install -D -m644 assets/noisetorch.desktop "${pkgdir}/usr/share/applications/noisetorch.desktop"
    install -D -m644 assets/icon/LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/icon-LICENSE"
    install -D -m644 assets/icon/noisetorch.png "${pkgdir}/usr/share/icons/hicolor/256x256/apps/noisetorch.png"
}

The changes are

_commit=ee91fea993138624dce47b4c0b626a99db25f656
source=("git+${url}#commit=${_commit}"

To get the source by commit as well as

pkgver() {
  cd NoiseTorch
  git describe --tags | sed 's/-/+/g'
}

To generate the pkgver by the git tag of that commit.

@Fumon thanks, i updated the package this this updated patch, now noisetorch can be installed normaly

If you're running into the same error as @foxite @karthikjayd and @mnqn on version 0.10.1-3, the patch file needs an update.

If you're doing a manual build, change main.patch to,

--- main.go     2021-05-16 15:53:15.287331017 -0400
+++ src/NoiseTorch-0.10.1/main.go       2021-05-16 15:53:21.954164782 -0400
@@ -25,7 +25,6 @@
        "github.com/aarzilli/nucular/style"
 )

-//go:generate go run scripts/embedversion.go
 //go:generate go run scripts/embedlicenses.go

 //go:embed c/ladspa/rnnoise_ladspa.so

Then run updpkgsums and the package should build properly.

I'm facing the same Issue as @karthikjayd and @foxite. Package broken.

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error making: noisetorch

I am facing the same issue that @foxite has pointed out.

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
:: Packages failed to build: noisetorch-0.10.1-3

Hi, thanks for adopting this package. Unfortunately with the latest release I can no longer build this package -- I'm using yay, and this is the output:

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error making: noisetorch

This is the contents of main.go.rej:

--- main.go 2021-01-31 01:57:33.000000000 -0500
+++ main.go.1   2021-02-01 09:09:20.817150966 -0500
@@ -25,7 +25,6 @@

 //go:generate go run scripts/embedbinary.go c/ladspa/rnnoise_ladspa.so librnnoise.go libRNNoise
 //go:generate go run scripts/embedbinary.go assets/patreon.png patreon.go patreonPNG
-//go:generate go run scripts/embedversion.go
 //go:generate go run scripts/embedlicenses.go

 type device struct {

I checked main.go and line 23 to 26 look like this:

//go:generate go run scripts/embedversion.go
//go:generate go run scripts/embedlicenses.go

//go:embed c/ladspa/rnnoise_ladspa.so

I'm not an expert on any of this but is that trying to remove a line which has already been made blank?

It seems likely that I'm the only person experiencing this, because the update was 5 days ago and nobody else has mentioned it. But it seems weird that I am getting an error which seems to be unrelated to anything on my machine.

We've actually been making an effort to move this into the official repos. I think I 100% agree with you though.

What I'm arguing is that it doesn't matter what the license says. The license could explicitly say "arch linux users can never use this package" but that doesn't mean anything because this is a build script, not the program itself. We're doing nothing but providing the recipe for users to build/install locally on their machines. The author is mistakenly thinking that they have control over what users do with source that is made available to the public. It doesn't matter if it's GPL, proprietary, or ultra-illegal-you-cannot-change-anything-because-i-said-so license.

Again, if this were in the official repos with pre-built packages then it'd be a different story.