Arch Linux User Repository

Hi, thanks for adopting this package. Unfortunately with the latest release I can no longer build this package -- I'm using yay, and this is the output:

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error making: noisetorch

This is the contents of main.go.rej:

--- main.go 2021-01-31 01:57:33.000000000 -0500
+++ main.go.1   2021-02-01 09:09:20.817150966 -0500
@@ -25,7 +25,6 @@

 //go:generate go run scripts/embedbinary.go c/ladspa/rnnoise_ladspa.so librnnoise.go libRNNoise
 //go:generate go run scripts/embedbinary.go assets/patreon.png patreon.go patreonPNG
-//go:generate go run scripts/embedversion.go
 //go:generate go run scripts/embedlicenses.go

 type device struct {

I checked main.go and line 23 to 26 look like this:

//go:generate go run scripts/embedversion.go
//go:generate go run scripts/embedlicenses.go

//go:embed c/ladspa/rnnoise_ladspa.so

I'm not an expert on any of this but is that trying to remove a line which has already been made blank?

It seems likely that I'm the only person experiencing this, because the update was 5 days ago and nobody else has mentioned it. But it seems weird that I am getting an error which seems to be unrelated to anything on my machine.

We've actually been making an effort to move this into the official repos. I think I 100% agree with you though.

What I'm arguing is that it doesn't matter what the license says. The license could explicitly say "arch linux users can never use this package" but that doesn't mean anything because this is a build script, not the program itself. We're doing nothing but providing the recipe for users to build/install locally on their machines. The author is mistakenly thinking that they have control over what users do with source that is made available to the public. It doesn't matter if it's GPL, proprietary, or ultra-illegal-you-cannot-change-anything-because-i-said-so license.

Again, if this were in the official repos with pre-built packages then it'd be a different story.

You may be right, but it's a little unclear. Section 7c states that a GPLv3 licensor can apply additional terms:

Prohibiting misrepresentation of the origin of that material, or requiring that modified versions of such material be marked in reasonable ways as different from the original version.

It doesn't really say this is a requirement only for redistribution or packaged versions, so I'm not really sure if it's enforceable.

Either way, I think I'm pretty much done maintaining this. I thought it would be an interesting foray into building packages, but it has been a bad experience. Normally this kind of thing is right up my alley, and I love that I've been able to contribute a bit to Arch.

If someone wants to take over I'd be glad to help transition. I actually started a bit of work to create a new make target for distros that use go build tags to selectively include go source instead of patching things (https://github.com/erbrecht/NoiseTorch/tree/distro-build). If upstream accepts this method, which they stated they would, they wouldn't be asking us to rename the package. I just don't want to maintain this package since it's basically been an uphill battle from the start.

I do not believe that we are under any obligation to change the name so long as this is in the AUR. This is not distribution of pre-built software, this is a build script for users to create binaries for themselves. It's why the AUR is able to have myriad proprietary softwares in the repository. If Arch were to include noisetorch in the official repositories then I imagine Arch would then need to solicit a fork.

Unless there's going to be serious potential ramifications (legal threats, pushing the dev into going open-code in some misguided attempt to "fix" the situation, etc.) it seems like the package can just continue to live, patched, in the AUR alongside countless other softwares that upstream authors do not bless.

The author has demonstrated a lack of tact that ensures a barrier to mutuality; I propose we just continue doing our thing in the AUR and make software that's proper in accordance to sane packaging.

Or noiseflashlight

Can't it be like "noisetorch-patched" or something?

I'm not really sure where this hostility from upstream is coming from. I suppose you can just rename it to not-noisetorch and move on with this. :p what a silly upstream move.

I was notified by the owner of the repo that starting with the next release, they will be adding a restriction to modified versions of the application:

https://github.com/lawl/NoiseTorch/issues/2#issuecomment-785262068

Addition to the license is here:

https://github.com/lawl/NoiseTorch/commit/8b054c20a909c9cc459e87ee8b56226c0428201b

We'll need to either change the name of this package, or stop distributing it this way. I'm open to naming suggestions, but with this latest change we can't push this into [community] as-is.

It looks like their own implementation. They mentioned in the release notes that it's their own, and the repo doesn't seem to contain any submodules or links to other repos.

I created a PKGBUILD for their ladspa implementation:

https://gist.github.com/erbrecht/e35aad169e046cb05fe859cecb554598

I also updated my experimental PKGBUILD to properly link the library:

https://github.com/erbrecht/noisetorch-aur-package

Everything seems to work fine.