Arch Linux User Repository

You may be right, but it's a little unclear. Section 7c states that a GPLv3 licensor can apply additional terms:

Prohibiting misrepresentation of the origin of that material, or requiring that modified versions of such material be marked in reasonable ways as different from the original version.

It doesn't really say this is a requirement only for redistribution or packaged versions, so I'm not really sure if it's enforceable.

Either way, I think I'm pretty much done maintaining this. I thought it would be an interesting foray into building packages, but it has been a bad experience. Normally this kind of thing is right up my alley, and I love that I've been able to contribute a bit to Arch.

If someone wants to take over I'd be glad to help transition. I actually started a bit of work to create a new make target for distros that use go build tags to selectively include go source instead of patching things (https://github.com/erbrecht/NoiseTorch/tree/distro-build). If upstream accepts this method, which they stated they would, they wouldn't be asking us to rename the package. I just don't want to maintain this package since it's basically been an uphill battle from the start.

I do not believe that we are under any obligation to change the name so long as this is in the AUR. This is not distribution of pre-built software, this is a build script for users to create binaries for themselves. It's why the AUR is able to have myriad proprietary softwares in the repository. If Arch were to include noisetorch in the official repositories then I imagine Arch would then need to solicit a fork.

Unless there's going to be serious potential ramifications (legal threats, pushing the dev into going open-code in some misguided attempt to "fix" the situation, etc.) it seems like the package can just continue to live, patched, in the AUR alongside countless other softwares that upstream authors do not bless.

The author has demonstrated a lack of tact that ensures a barrier to mutuality; I propose we just continue doing our thing in the AUR and make software that's proper in accordance to sane packaging.

Or noiseflashlight

Can't it be like "noisetorch-patched" or something?

I'm not really sure where this hostility from upstream is coming from. I suppose you can just rename it to not-noisetorch and move on with this. :p what a silly upstream move.

I was notified by the owner of the repo that starting with the next release, they will be adding a restriction to modified versions of the application:

https://github.com/lawl/NoiseTorch/issues/2#issuecomment-785262068

Addition to the license is here:

https://github.com/lawl/NoiseTorch/commit/8b054c20a909c9cc459e87ee8b56226c0428201b

We'll need to either change the name of this package, or stop distributing it this way. I'm open to naming suggestions, but with this latest change we can't push this into [community] as-is.

It looks like their own implementation. They mentioned in the release notes that it's their own, and the repo doesn't seem to contain any submodules or links to other repos.

I created a PKGBUILD for their ladspa implementation:

https://gist.github.com/erbrecht/e35aad169e046cb05fe859cecb554598

I also updated my experimental PKGBUILD to properly link the library:

https://github.com/erbrecht/noisetorch-aur-package

Everything seems to work fine.

Are you sure it's their own implementation or that it's just copied into there from somewhere? I'd ideally like to devendor it entirely (and build the C stuff in (a) separate package(s)) and then just link to it. Think that's doable?

Ok, after looking at this for just a bit, here is what I see. Initially, noisetorch was using the ladspa plugin provided by https://github.com/werman/noise-suppression-for-voice (which in turn uses xiph's rnnoise library. It was embedding the binary, and I modified it to make use of the actual shared library.

Now, noisetorch has its own implementation of the ladspa plugin, again based on xiph's rnnoise library (provides librnnoise.so). I think what we need is the rnnoise_ladspa.so that is built here https://github.com/lawl/NoiseTorch/tree/master/c/ladspa. I have a PKGBUILD available here https://github.com/erbrecht/noisetorch-aur-package. It tries to rely on the rnnoise.so shared library, but it doesn't work since it's not the ladspa plugin (I think).

Sorry it took a while. I'm now setting the capability directly on the binary in the install file. Thanks for that suggestion.

I took a look at your changes and I implemented most of them except the dependency 2. I'm also working on linking rnnoise. It should be pretty straight forward. I'll try to get to that as soon as I can.

I originally had hicolor-icon-theme as a dependency but removed it after this feedback (https://bbs.archlinux.org/viewtopic.php?pid=1917440#p1917440). It seems to make sense.

Also, export GOPATH="$srcdir/go" is there so that the go build dependencies don't end up in the user's system. go clean -modcache cleans the source directory after the build so all those dependencies don't take up space. I'd be inclined to leave those unless there is a pressing reason to remove them. I did remove the go clean command from the prepare function since it's not really necessary before the build.