@xiota: This package no longer compiles with the boost update to version 1.89!
This patch solve the issue on my machine: https://pastebin.com/w1TjGrxk
| Git Clone URL: | https://aur.archlinux.org/sourcetrail.git (read-only, click to copy) |
|---|---|
| Package Base: | sourcetrail |
| Description: | Interactive source explorer for C/C++ and Java |
| Upstream URL: | https://github.com/petermost/Sourcetrail |
| Licenses: | GPL-3.0-only |
| Submitter: | jetm |
| Maintainer: | xiota |
| Last Packager: | xiota |
| Votes: | 26 |
| Popularity: | 1.24 |
| First Submitted: | 2017-04-12 15:18 (UTC) |
| Last Updated: | 2025-10-21 21:19 (UTC) |
@xiota: This package no longer compiles with the boost update to version 1.89!
This patch solve the issue on my machine: https://pastebin.com/w1TjGrxk
@xiota: Thanks for the response & the quick update. I understand your reasoning about having the vendored repo, but there's a reason why distros don't do this and additionally prefer downloading patches from upstream instead of providing those themselves: It makes the pkg very hard to check for malice, especially if not all commits in the vendored repo are gpg signed. I may trust you to have no malicious intends, but I don't want to trust you not getting hacked. And no, using patches isn't that cumbersome that you can't do it, it's only a minor inconvenience.
As 2 side notes:
- cp --reflink=auto is the default nowadays, no need to be explicit (maybe Arch's coreutils are outdated, if so, forget it)
- You don't have to increase the pkgrel to push changes to the AUR git. No need for a bump when removing a dep and changing nothing else.
@xiota: May you please at least respond? An unnecessary dependency is a bug and I don't want to abuse the out of date button to get attention.
On another note, why do you vendor the real upstream git repo instead of using it directly? As far as I've seen, there are no changes made by you in the "forked" repo source, as long as you don't have purposefully changed your git username in commits to it (which seems unlikely after a quick review).
Why the additional makedependency on archlinux-java-run just for specifiying the java version to run? Just prefix the command with `JAVA_HOME=/usr/lib/jvm/java-<nr>-openjdk PATH="/usr/lib/jvm/java-<nr>-openjdk/bin:$PATH <your_cmd>". It isn't really necessary.
sourcetrail/src/sourcetrail/src/lib/data/search/SearchIndex.cpp
454 // first letter
455 if (index == 0)
456 {
457 firstLetterScore += firstLetterBonus;
! 458 } else if (index >= text.size() || index >= text.size() - 1) {
+ 459 continue;
+ 460 }
The character here is out of bounds. need fix.
Pinned Comments
xiota commented on 2024-06-20 03:07 (UTC) (edited on 2025-10-14 20:15 (UTC) by xiota)
Please observe the following when flagging or commenting: