Arch Linux User Repository

The issue about versioning is simply about correcting an outdated scheme, which is not used anymore.

Regarding tests under Wine. Imagine my surprise when Wine prefix creation window popped during compilation. And ~/.wine got created, rechecked and confirmed. And it happens exactly in test 13.

I'm not familiar with upstream repo(s), Wine-Metal connection or testing procedures, but please take a look at: https://github.com/KhronosGroup/SPIRV-Cross/blob/7d92d7d8794b102f550ad33dbedbd82203b755a9/test_shaders.py#L107-L110 And there's thousands hits for Metal.

@drws 1) Building the required upstream dependencies with specific commits when they strictly require it is not an issue. As already explained, the test suite fails if we use the pre-compiled dependencies from packages in the official repositories, as they have different versions than the ones expected by upstream. Your complain about this subject does not belong to here in the packaging side, but it belongs to the upstream side. You need to convince the upstream developers to make their software work with the latest stable versions of the dependencies. 2) This can be considered to better reflect the underlying sdk version, although it currently causes no issues, since this is just a version schema. 3) I see no tests running or trying to be run under Wine. All tests are passing fine, without any skipped ones. I also do not see any dependency on Wine here, as all binary files shipped by the package are targeting the GNU/Linux platform, and nothing shipped by the package needs Wine to run. Provide some evidence about Wine requirement if you have some. 4) The current pkgdesc already matches how upstream describes itself, and this is sufficient. See also answer about item 3, as Wine is not required. 5) Test 13 (spirv-cross-test-hlsl) is passing fine without Wine installed.

@dbermond: The PKGBUILD has multiple issues:

1. The dependencies glslang, spirv-headers, and spirv-tools (@sukanka's comment) are still not being used even two years later. The answer from 2022 is not a solution. The PKGBUILD needs to handle the AUR dependencies being used. If current AUR packages don't suffice, you could split off the unwanted deps from this package into a new AUR one that can be used. Or do some patching of this package. But please let's stop building multiple packages in one PKGBUILD.

2. @As abouvier mentioned before, the versioning scheme changed in the past. See (and please fix): https://github.com/KhronosGroup/SPIRV-Cross/tags

3. This software apparently uses Wine and/or Apple Metal. It also runs some of the tests with Wine - which needs to be added to build deps! And possibly optional ones too?

4. Please mention Wine/Metal in the package description, primarily to serve as a warning to users.

@maxcutlyp: Late answer, but I think this test is a Wine/Metal one, so probably related. You could try to move ~/.wine somewhere else, build the package, remove the new ~/.wine and put the old one back.

I recieve this warning, which seems to defeat part of the reason for using: -- spirv-tools not linked - illegal SPIRV may be generated for HLSL

@sukanka The test suite fails to pass when using binaries from the official repositories, as upstream expects specific commits for them. Your proposed PKGBUILD does not produces and does not run the test suite, as you missed the needed symlinks. On build(), your PKGBUILD shows "SPIRV-Cross: Testing will be disabled for SPIRV-Cross.", and on check() "No tests were found!!!".

This package should use glslang, spirv-headers, and spirv-tools as depends instead of building them from source. A modified version https://gist.github.com/sukanka/8c122dad9ce45029fb980949d0b20012

The version is wrong, it should be 1.3.211.0, the same versioning scheme as spirv-headers or vulkan-extra-tools.

@abouvier Package updated.

Why did you remove the flag? :p

The package is really out of date.

@maxcutlyp I've just checked, and the package is building fine. No tests hanging.