Arch Linux User Repository

@seqfault the build is not failing. The problem is that the checks are failing and only upstream can fix those, see https://github.com/xou816/spot/pull/684. You can disable the tests by passing --nocheck to makepkg.

@jeidnx @dpeukert the build is still failing, please fix the package: https://paste.rs/UNAXd.txt

the build is failing: https://0x0.st/H44u.txt

@mihalycsaba maybe we could rename the binary to spot-client?

what can we do about the afdko conflict? that package also provides /usr/bin/spot

Also, the package has a makedepend on blueprint-compiler now.

@Rayr disable-clippy.patch fails to apply after recent changes, but Clippy no longer prevents building, so I propose removing it:

diff --git a/.SRCINFO b/.SRCINFO
index af788d6..294b781 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = spot-client-git
    pkgdesc = Gtk/Rust native Spotify client - git version
    pkgver = r698.4b1209d
-   pkgrel = 2
+   pkgrel = 3
    url = https://github.com/xou816/spot
    arch = x86_64
    arch = i686
@@ -30,8 +30,6 @@ pkgbase = spot-client-git
    conflicts = spot-client
    options = !lto
    source = spot-client-git::git+https://github.com/xou816/spot
-   source = disable-clippy.patch
    sha512sums = SKIP
-   sha512sums = 1cb0faced2e6801cb994e9af7b81411355837b2efcd9c82b82751508e0bfcc967c50b3d6296bfdb8c017bbf2e7a503a3920d36cb896e44c896c23f5b9e1d13f1

 pkgname = spot-client-git
diff --git a/PKGBUILD b/PKGBUILD
index 1aa5909..e0dc3d6 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,7 +4,7 @@
 _projectname='spot'
 pkgname="$_projectname-client-git"
 pkgver='r698.4b1209d'
-pkgrel='2'
+pkgrel='3'
 pkgdesc='Gtk/Rust native Spotify client - git version'
 arch=('x86_64' 'i686' 'arm' 'armv6h' 'armv7h' 'aarch64')
 url="https://github.com/xou816/$_projectname"
@@ -16,23 +16,12 @@ checkdepends=('appstream-glib')
 provides=("$_projectname-client")
 conflicts=("$_projectname-client")
 options=('!lto') # build breaks with LTO enabled (https://gitlab.com/dpeukert/pkgbuilds/-/issues/38)
-source=(
-   "$pkgname::git+$url"
-   'disable-clippy.patch'
-)
-sha512sums=('SKIP'
-            '1cb0faced2e6801cb994e9af7b81411355837b2efcd9c82b82751508e0bfcc967c50b3d6296bfdb8c017bbf2e7a503a3920d36cb896e44c896c23f5b9e1d13f1')
+source=("$pkgname::git+$url")
+sha512sums=('SKIP')

 _sourcedirectory="$pkgname"
 _builddirectory='build'

-prepare() {
-   cd "$srcdir/$_sourcedirectory/"
-
-   # Disable clippy tests, as they don't realy make sense for user builds (https://gitlab.com/dpeukert/pkgbuilds/-/issues/37)
-   patch --forward -p1 < '../disable-clippy.patch'
-}
-
 pkgver() {
    cd "$srcdir/$_sourcedirectory/"
    echo "r$(git rev-list --count HEAD).$(git rev-parse --short HEAD)"
diff --git a/disable-clippy.patch b/disable-clippy.patch
deleted file mode 100644
index 25b9544..0000000
--- a/disable-clippy.patch
+++ /dev/null
@@ -1,19 +0,0 @@
-diff --git a/src/meson.build b/src/meson.build
-index 755d870..fac1b77 100644
---- a/src/meson.build
-+++ b/src/meson.build
-@@ -208,14 +208,3 @@ test('Unit tests',
-   ],
-   timeout: 180
- )
--
--cargo_clippy = find_program(meson.source_root() / 'build-aux/clippy.sh')
--test('Clippy',
--  cargo_clippy,
--  args: [
--    meson.source_root(),
--    meson.build_root(),
--    get_option('offline') ? 'true' : 'false'
--  ],
--  timeout: 180
--)

@samsapti thanks, fixed

The PKGBUILD's pkgver() doesn't output the latest commit, it outputs the latest tag (which somehow evaluates to 0.3.1 instead of 0.3.3). In contrast, it's the latest commit that's actually built. Since 0.3.1 is older than the pkgver specified in the PKGBUILD, it causes AUR helpers to think it's out of date and rebuilds/reinstalls the same version on every system upgrade. I've made a fix below:

diff --git a/PKGBUILD b/PKGBUILD
index 3bcb43a..1aa5909 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@
 # Contributor: NicoHood <archlinux {cat} nicohood {dog} de>
 _projectname='spot'
 pkgname="$_projectname-client-git"
-pkgver='0.3.3.r19.geb347ae'
+pkgver='r698.4b1209d'
 pkgrel='2'
 pkgdesc='Gtk/Rust native Spotify client - git version'
 arch=('x86_64' 'i686' 'arm' 'armv6h' 'armv7h' 'aarch64')
@@ -35,7 +35,7 @@ prepare() {

 pkgver() {
    cd "$srcdir/$_sourcedirectory/"
-   git describe --long --tags | sed -e 's/^v//' -e 's/-\([^-]*-g[^-]*\)$/-r\1/' -e 's/-/./g'
+   echo "r$(git rev-list --count HEAD).$(git rev-parse --short HEAD)"
 }

 build() {

This is broken currently (fails a post-build test with a MALLOC error). See this comment in the upstream issue: https://github.com/xou816/spot/issues/542#issuecomment-1208748141

(also posted this on the spot-client AUR package page)