Package Details: spotdl 4.2.5-5

Git Clone URL: https://aur.archlinux.org/spotdl.git (read-only, click to copy)
Package Base: spotdl
Description: Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
Upstream URL: https://github.com/spotDL/spotify-downloader
Keywords: download-music mp3 music playlists song song-lyrics spotify youtube-music
Licenses: MIT
Conflicts: python-spotdl
Provides: python-spotdl
Replaces: python-spotdl
Submitter: zoorat
Maintainer: zoorat (pekkarr, aminvakil)
Last Packager: pekkarr
Votes: 20
Popularity: 0.88
First Submitted: 2024-03-31 19:44 (UTC)
Last Updated: 2024-04-27 11:57 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 .. 9 Next › Last »

gesh commented on 2024-04-01 10:39 (UTC) (edited on 2024-04-01 10:41 (UTC) by gesh)

tests/utils/test_config.py tests fail. Also, by running them with || echo, you're masking the test failures, so the package installs despite test failures.

Finally, it's a shame that this package loses the git history of python-spotdl. If you feel like recovering that history, add a python-spotdl branch pointing to the old python-spotdl/master and git merge --allow-unrelated-histories -Xours python-spotdl to merge them.

zoorat commented on 2024-03-31 21:42 (UTC)

@pekkarr thanks a lot for the help

pekkarr commented on 2024-03-31 20:21 (UTC)

files.pythonhosted.org is just an alternative URL for downloading PyPI sdists. The files are exactly the same as those downloaded from pypi.io. The Python package guidelines list those URLs, but there's a "Note: With RFC0020 the default is to use upstream provided source tarballs, instead of PyPI provided sdist tarballs". So getting the source from Github would be better (with renaming the source file as in the previous comment).

Another minor issue is that $pkgname should not be in provides, as every package implicitly provides itself.

Otherwise the spotdl package looks good.

zoorat commented on 2024-03-31 19:48 (UTC)

@pekkarr i was thinking about @gesh 's suggestion and used files.pythonhosted.org from https://wiki.archlinux.org/title/Python_package_guidelines

i uploaded those to https://aur.archlinux.org/packages/spotdl.

can you please check that out

pekkarr commented on 2024-03-31 19:25 (UTC)

@zoorat Thanks! Could you also prefix the source tarball with $pkgname as @gesh suggested? Arch package guidelines say that sources have to be unique. The PKGBUILD wiki page explains why this is needed. For example, the source variable could be defined as

source=("$pkgname-$pkgver.tar.gz::$url/archive/v$pkgver.tar.gz")

zoorat commented on 2024-03-31 19:06 (UTC)

@pekkarr i didn't know about this pypi situation. i am updating it now.

pekkarr commented on 2024-03-31 14:21 (UTC)

@zoorat Please don't use PyPI as the source, see Arch Linux RFC 20. And yes, upstream changed the v4.2.5 git tag from c646615 to bd38845 which is why the checksum changed.

By the way, I agree with @xiota, this package should be renamed to spotdl. This could be done by submitting it with the new name to AUR and then submitting a merge request to merge python-spotdl into spotdl.

zoorat commented on 2024-03-31 14:08 (UTC)

@gesh thanks for the report

the reason why the b2sum is wrong is because they published v4.2.5 twice. (just checked my emails) most probably because they had some build error before. i am updating it now.

and all tarballs you tested failed because i changed the source from pypi.io to github for upgrading to the 4.2.5 version.

gesh commented on 2024-03-31 12:57 (UTC)

b2sums incorrectly updated, and it is unclear what release it was generated from -- testing with the tarballs for 4.2.{3,4,5} all yield different b2sums.

Also, please prefix the source tarball with $pkgname -- some of us combine source caches, and it is nice to have some indication of what package pulled in what source.

« First ‹ Previous 1 2 3 4 5 6 7 .. 9 Next › Last »