Package Details: spotdl 4.2.5-5

Git Clone URL: https://aur.archlinux.org/spotdl.git (read-only, click to copy)
Package Base: spotdl
Description: Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
Upstream URL: https://github.com/spotDL/spotify-downloader
Keywords: download-music mp3 music playlists song song-lyrics spotify youtube-music
Licenses: MIT
Conflicts: python-spotdl
Provides: python-spotdl
Replaces: python-spotdl
Submitter: zoorat
Maintainer: zoorat (pekkarr, aminvakil)
Last Packager: pekkarr
Votes: 20
Popularity: 0.94
First Submitted: 2024-03-31 19:44 (UTC)
Last Updated: 2024-04-27 11:57 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »

aminvakil commented on 2023-11-12 14:56 (UTC) (edited on 2023-11-12 14:57 (UTC) by aminvakil)

I agree with @pekkarr about Makefile, let's keep things simple.

I use a bash script for myself for bumping packages which it's local and https://github.com/aminvakil/aur to test changes and build packages nightly for packages I maintain and co-maintain (which I invite you to use in case you wanted a really clean build and / or propose changes or good to haves in it).

Also aurpublish, locally and on github actions.

zoorat commented on 2023-11-12 12:00 (UTC)

@pekkarr i was reading https://www.shellcheck.net/wiki/SC2164 and totally forgot about the makepkg hook. sorry. my bad.

@aminvakil i thought it would be a good quality of life change... removed it.

about Makefile, i saw many packages with them. i got that it won't be useful for users to review, so i added a comment. it's not that big to understand it's a script for maintainers. and i can see people without package manager can use it...

if you guys strongly think it is bad thing then i will remove it.

pekkarr commented on 2023-11-12 10:43 (UTC)

I agree with @aminvakil, the changelog is unnecessary in the package. Very few official packages use that pacman feature, and users can find the changelog on upstream Github repository anyways.

Also, in my opinion the AUR git repository is wrong place for a Makefile for maintaining the PKGBUILD. It adds unnecessary complexity that users need to review when they install the package, while being completely useless for users. Thus, it should not be committed to the AUR.

Using exit inside PKGBUILD is also wrong: it causes the whole makepkg process to exit without running hooks set by makepkg that print A failure occurred in .... Makepkg runs the functions in an environment where a non-zero exit status from a command already terminates the function, so adding || exit or similar to commands is also unnecessary.

By the way, using cd would be simpler than pushd. There's no need to change the working directory back to the original after each function. pushd and popd also unnecessarily print the directory stack after each invocation.

The GIT_DIR=. workaround is also unnecessary now, since that python-poetry bug has been fixed.

aminvakil commented on 2023-11-12 09:37 (UTC)

Why should we have changelog.md in this repository? Do you want to keep this updated on every release?

zoorat commented on 2023-11-12 04:57 (UTC)

hey,

i added the changelog. use pacman -Qc python-spotdl to check it, and linted PKGBUILD based on shellcheck, also added a Makefile to make life easier :)

and thanks @aminvakil, @AlexisBRENON and @txtsd for keep this package uptodate.

txtsd commented on 2023-11-03 04:07 (UTC)

@ioan patch is included in base-devel which should be installed if you're building anything on Arch.

ioan commented on 2023-11-03 01:35 (UTC)

python-syncedlyrics/PKGBUILD: line 25: patch: command not found

pekkarr commented on 2023-06-03 09:34 (UTC)

@sentientmachin3 Does the directory /usr/lib/python3.11/site-packages/spotipy/ exist on your system? Have you rebuilt python-spotipy after the python upgrade from 3.10 to 3.11?

sentientmachin3 commented on 2023-06-03 09:20 (UTC) (edited on 2023-06-03 09:21 (UTC) by sentientmachin3)

I'm getting an error when running spotdl, here is the stack

Traceback (most recent call last): File "/usr/bin/spotdl", line 5, in <module> from spotdl import console_entry_point File "/usr/lib/python3.11/site-packages/spotdl/__init__.py", line 13, in <module> from spotdl.console import console_entry_point File "/usr/lib/python3.11/site-packages/spotdl/console/__init__.py", line 5, in <module> from spotdl.console.entry_point import console_entry_point File "/usr/lib/python3.11/site-packages/spotdl/console/entry_point.py", line 9, in <module> from spotdl.console.download import download File "/usr/lib/python3.11/site-packages/spotdl/console/download.py", line 7, in <module> from spotdl.download.downloader import Downloader File "/usr/lib/python3.11/site-packages/spotdl/download/downloader.py", line 19, in <module> from spotdl.download.progress_handler import ProgressHandler File "/usr/lib/python3.11/site-packages/spotdl/download/progress_handler.py", line 23, in <module> from spotdl.types.song import Song File "/usr/lib/python3.11/site-packages/spotdl/types/song.py", line 9, in <module> from spotdl.utils.spotify import SpotifyClient File "/usr/lib/python3.11/site-packages/spotdl/utils/spotify.py", line 16, in <module> from spotipy import Spotify ModuleNotFoundError: No module named 'spotipy' The installation went fine, resetting the cache does not affect the issue. The tool works when installed via pip

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »