Arch Linux User Repository

/opt/ventoy/tool/{ventoy_lib.sh,VentoyWorker.sh} these 2 scripts aren't posix complient. so please change #!/bin/sh to #!/usr/bin/env bash for those scripts.

Please fix "ventoy.desktop ... FAILED" checksum validation.

@TankMissile: Oops, fixed.

The binaries can't be symlinked due to the use of relative paths.

The .desktop file for the new linux GUI should not have Terminal=true. Also, instead of having scripts that point to the ventoy commands, why not symlink them instead?

I tend to agree. Thanks !

@Kr1ss: I think printing the messages isn't necessary at all and makes the PKGBUILD messy. Just my 2 cents.

Thank you @ron2138 !

The first idea I had earlier (to check if output goes to a tty or not), was a bit too quick. It wouldn't prevent colored lines in the log, because makepkg redirects the data stream to the log file outside of the PKGBUILD's functions, and thus after that condition would be tested.

I figured it would make much more sense anyways, to let the user switch off color explicitely via the -m/--nocolor flag which you mentioned. The only (sensible) way to check if that flag is set or not, that I could come up with, is querying a variable that depends on it.

You're correct in that USE_COLOR is a variable defined by makepkg itself. That doesn't offend the recommendation in the packaging etiquette though, in my opinion, since it's not a subroutine.

As I understand that wiki clause, internal makepkg functions should not be used because the build script could break when those functions are changed at some point. This is not the case when a variable is queried though. Building would still work after a change.

In case that I'm getting something completely wrong please let me know. Also @yochananmarqos and/or @DuckSoft, do you have any strong opinions about this ? Would it make more sense to just remove the color codes ?

Replying @Kr1ss's comment at 2021-08-31 20:31:

Under a quick test, it solves my issue.

Does $USE_COLOR an internal variable of makepkg? If yes, doesn't https://wiki.archlinux.org/title/Arch_package_guidelines#Package_etiquette apply to it too? See comment at 2021-08-28 20:18. For the reference, Kr1ss suggests

--- a/PKGBUILD
+++ b/PKGBUILD
@@ -23,7 +23,10 @@ sha256sums=('81ae02a06b132b5965dd09c9b64e000a6dafa1d57e03d8564feefda14ef1ee02'
         '00dec31721a052d5e6c928e3b38b870959bdb42188f34717898d99c0cef950df'
         '1555f65997e6d92ca29a774b45052e97a3358430fa5869f521a4fe7818427a1f')

-_msg2() { printf "\e[1;34m  ->\e[0;1m %s\e[0m\n" "$1"; }
+_msg2() {
+  if [ "$USE_COLOR" = n ]; then printf "  -> %s\n" "$1"
+  else printf "\e[1;34m  ->\e[0;1m %s\e[0m\n" "$1"; fi
+}

 prepare() {
   _msg2 "Decompress tools..."

Oh, the latest pkgrel update (to 1.0.51-2) should actually have solved your issue @ron2138. Hasn't it ?

Replying @Kr1ss's comment at 2021-08-30 16:15

Do you mean

diff --git a/PKGBUILD b/PKGBUILD
index c802de3..dec468a 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -23,7 +23,10 @@ sha256sums=('81ae02a06b132b5965dd09c9b64e000a6dafa1d57e03d8564feefda14ef1ee02'
             '00dec31721a052d5e6c928e3b38b870959bdb42188f34717898d99c0cef950df'
             '1555f65997e6d92ca29a774b45052e97a3358430fa5869f521a4fe7818427a1f')

-_msg2() { printf "\e[1;34m  ->\e[0;1m %s\e[0m\n" "$1"; }
+_msg2() { if tty --silent; then
+            printf "\e[1;34m  ->\e[0;1m %s\e[0m\n" "$1"
+          else
+            printf "  -> %s\n" "$1"
+          fi
+}

 prepare() {
   _msg2 "Decompress tools..."

?

Not tested.