| Git Clone URL: | https://aur.archlinux.org/ventoy-bin.git (read-only, click to copy) |
|---|---|
| Package Base: | ventoy-bin |
| Description: | A new bootable USB solution |
| Upstream URL: | http://www.ventoy.net |
| Keywords: | boot image iso multiboot usb |
| Licenses: | GPL-3.0-or-later |
| Conflicts: | ventoy |
| Provides: | ventoy |
| Submitter: | DuckSoft |
| Maintainer: | DuckSoft (KokaKiwi, yochananmarqos, Kr1ss) |
| Last Packager: | yochananmarqos |
| Votes: | 360 |
| Popularity: | 7.85 |
| First Submitted: | 2020-05-19 06:14 (UTC) |
| Last Updated: | 2024-12-13 03:01 (UTC) |
@ron2138 :
Yes, that's correct, the colored output you're referring to is caused by a logging function in PKGBUILD.
It should be possible though to detect if output goes to a terminal and only then include the ANSI color codes, so that when printing to a log file only raw text is outputted.
Will check that when I'm home tonight.
While extracting, I got messages that had colors within. Defeating --nocolor option of makepkg, which is nice to its --log. I believe these colors are created by the arch's maintainer. Am I right? Can that be improved?
Oh I am sorry, I just updated ventoy-bin and saw _msg2. Didn't realize it is wrapping printf, and completely forgot I suggested this before - I've been doing it to a couple of packages lately. Apologies and thanks for making the package better!
@thiagowfx: That was actually already done awhile ago.
@thiagowfx - We do use printf since you made that suggestion the first time.
https://wiki.archlinux.org/title/Arch_package_guidelines#Package_etiquette:
Do not use makepkg subroutines (e.g. error, msg, msg2, plain, warning) as they might change at any time. To print data, use printf or echo.
@DuckSoft: you are right, its my fault.
@TheHitMan:
qemu-system-x86_64 -cdrom /dev/sdb
I think you have used the wrong arguments for qemu. Try qemu-system-x86_64 -hda /dev/sdb.
FYI: Here is how I test ventoy-bin after each release:
$ dd if=/dev/zero of=/tmp/vdisk.img bs=1M count=1024
$ sudo losetup /dev/loop0 /tmp/vdisk.img
$ ventoy -i /dev/loop0
...
$ qemu-system-x86_64 -hda /dev/loop0
Attention: You will install Ventoy to /dev/sdb. All the data on the disk /dev/sdb will be lost!!!
Continue? (y/n) y
All the data on the disk /dev/sdb will be lost!!! Double-check. Continue? (y/n) y
Create partitions on /dev/sdb by parted in MBR style ... Done mkfs on disk partitions ... create efi fat fs /dev/sdb2 ... mkfs.fat 4.2 (2021-01-31) success mkexfatfs 1.3.0 Creating... done. Flushing... done. File system created successfully. writing data to disk ... sync data ... esp partition processing ...
Install Ventoy to /dev/sdb successfully finished.
[root@HTM-Burki-Flur u0]#
qemu-system-x86_64 -cdrom /dev/sdb
but i cant boot
Please do not use msg2 and similar functions in the PKGBUILD:
https://wiki.archlinux.org/title/Arch_package_guidelines:
Do not use makepkg subroutines (e.g. error, msg, msg2, plain, warning) as they might change at any time. To print data, use printf or echo.
Pinned Comments