Arch Linux User Repository

I had to change a few things to get this to build:
1. Use regular glslang (not -git)
2. Download the git submodules recursively
3. Remove some arguments from cmake

diff --git a/PKGBUILD b/PKGBUILD
index e564f7a..a7ae1ff 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -11,7 +11,7 @@ arch=('i686' 'x86_64' 'aarch64')
 url=https://github.com/nihui/waifu2x-ncnn-vulkan
 license=(MIT)
 depends=('vulkan-icd-loader' 'libwebp')
-makedepends=('git' 'cmake' 'glslang-git' 'vulkan-headers' 'ncnn')
+makedepends=('git' 'cmake' 'glslang' 'vulkan-headers' 'ncnn')
 conflicts=("${pkgname%-git}" "${pkgname%-git}-bin")
 provides=("${pkgname%-git}")
 source=(git+"${url}".git)
@@ -25,14 +25,13 @@ prepare() {
     # Fix default model path
     sed -i 's|path_t model = PATHSTR("models-cunet")|path_t model = PATHSTR("/usr/share/waifu2x-ncnn-vulkan/models-cunet")|' "${pkgname%-git}"/src/main.cpp
     sed -i 's|return get_executable_directory() + path;|return "/usr/share/waifu2x-ncnn-vulkan/" + path;|' "${pkgname%-git}"/src/main.cpp
+    cd "${srcdir}/waifu2x-ncnn-vulkan"
+    git submodule update --init --recursive
 }

 build() {
     cmake -B build -S "${pkgname%-git}"/src \
-        -DCMAKE_INSTALL_PREFIX=/usr \
-        -DGLSLANG_TARGET_DIR=/usr/lib/cmake \
-        -DUSE_SYSTEM_NCNN=on \
-        -DUSE_SYSTEM_WEBP=on
+        -DCMAKE_INSTALL_PREFIX=/usr
     cmake --build build
 }

Is there a reason why this depends on glslang-git, and not just glslang?

Hi, I think I solved the build dependency problem. Just add -DGLSLANG_TARGET_DIR="/usr/lib/cmake/" to specify the glslangTarget.cmake path. This should work for ncnn and all packages with submodule of ncnn. In this way, you can remove the submodules downloading and use 'ncnn-git' as make dependency.

Thank you for your package. I made dain-ncnn-vulkan and cain-ncnn-vulkan and fixed the load_module issue, hope that will be helpful for you too.

If that happens maybe simply enforce the -git variant of the dependency?

Still, at the very least follow the guidelines for submodules so that it can get cached. https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_submodules

I'll switch to system webp/ncnn on the stable package, but I'm hesitant to use system ncnn on this -git package. It depends on a specific version of ncnn that is sometimes between the latest release and head.

That same problem with "Whoops! Connection failed. Please try again. If the problem persists, contact our customer support." is back. So 3.7.4 has NOT resolved the problem (as i'm still running that exact 3.7.4 binary) and the problem was related to something else.

In the end, NordVPN is just unusable for me in any way, there are so many different errors over time. - This ARCH package does not seem very active / no real help here (maybe because no one has any knowledge about the potential issues) - NordVPN support is not willing to help in any way (because i'm not using one of the packaged created by NordVPN) - There are 0 detailled logs attached to that NordVPN binary and that could lead to a possible problem / a possible solution

Anyway i'm done with nordvpn in this state, and as soon as my subscription is going to be expired, i'll check another VPN provider.

This comment was originally about submodule guidelines, but after looking at the CMakeLists.txt I found out you can use system ncnn and libwebp.

Could you make it use system ncnn and libwebp instead of submodules? Would make re-compiling faster and done properly instead of re-downloading (and re-compiling) it each time.

diff --git a/PKGBUILD b/PKGBUILD
index db519ce..77d6171 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,13 +2,13 @@
 # Contributor: Utkan Güngördü <utkan@freeconsole.org>

 pkgname=waifu2x-ncnn-vulkan-git
-pkgver=20200606.r0.gcd12dff
+pkgver=20200818.r0.g8b5c1cd
 pkgrel=1
 pkgdesc="waifu2x converter ncnn version, runs fast on intel / amd / nvidia GPU with vulkan"
 url="https://github.com/nihui/waifu2x-ncnn-vulkan"
 license=('MIT')
-depends=('vulkan-icd-loader' 'vulkan-driver')
-makedepends=('git' 'cmake' 'glslang' 'vulkan-headers')
+depends=('vulkan-icd-loader' 'vulkan-driver' 'libwebp')
+makedepends=('git' 'cmake' 'glslang' 'vulkan-headers' 'ncnn')
 conflicts=('waifu2x-ncnn-vulkan')
 provides=('waifu2x-ncnn-vulkan')
 arch=('i686' 'x86_64')
@@ -27,9 +27,6 @@ pkgver() {
 prepare() {
     cd "${srcdir}/waifu2x-ncnn-vulkan"

-    # init ncnn submodule
-    git submodule update --init --recursive
-
     # Fix default model path
     sed -i 's|path_t model = PATHSTR("models-cunet")|path_t model = PATHSTR("/usr/share/waifu2x-ncnn-vulkan/models-cunet")|' src/main.cpp
 }
@@ -40,6 +37,9 @@ build() {
     cd build
     cmake \
         -DCMAKE_INSTALL_PREFIX=/usr \
+        -DGLSLANG_TARGET_DIR=/usr/lib/cmake \
+        -DUSE_SYSTEM_NCNN=on \
+        -DUSE_SYSTEM_WEBP=on \
         ..
     make
 }

Thanks, I updated the pkgbuild for the ncnn submodule.

Had to add

git submodule update --init

to the prepare function after the cd command.