Arch Linux User Repository

Hi, I think I solved the build dependency problem. Just add -DGLSLANG_TARGET_DIR="/usr/lib/cmake/" to specify the glslangTarget.cmake path. This should work for ncnn and all packages with submodule of ncnn. In this way, you can remove the submodules downloading and use 'ncnn-git' as make dependency.

Thank you for your package. I made dain-ncnn-vulkan and cain-ncnn-vulkan and fixed the load_module issue, hope that will be helpful for you too.

If that happens maybe simply enforce the -git variant of the dependency?

Still, at the very least follow the guidelines for submodules so that it can get cached. https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_submodules

I'll switch to system webp/ncnn on the stable package, but I'm hesitant to use system ncnn on this -git package. It depends on a specific version of ncnn that is sometimes between the latest release and head.

That same problem with "Whoops! Connection failed. Please try again. If the problem persists, contact our customer support." is back. So 3.7.4 has NOT resolved the problem (as i'm still running that exact 3.7.4 binary) and the problem was related to something else.

In the end, NordVPN is just unusable for me in any way, there are so many different errors over time. - This ARCH package does not seem very active / no real help here (maybe because no one has any knowledge about the potential issues) - NordVPN support is not willing to help in any way (because i'm not using one of the packaged created by NordVPN) - There are 0 detailled logs attached to that NordVPN binary and that could lead to a possible problem / a possible solution

Anyway i'm done with nordvpn in this state, and as soon as my subscription is going to be expired, i'll check another VPN provider.

This comment was originally about submodule guidelines, but after looking at the CMakeLists.txt I found out you can use system ncnn and libwebp.

Could you make it use system ncnn and libwebp instead of submodules? Would make re-compiling faster and done properly instead of re-downloading (and re-compiling) it each time.

diff --git a/PKGBUILD b/PKGBUILD
index db519ce..77d6171 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,13 +2,13 @@
 # Contributor: Utkan Güngördü <utkan@freeconsole.org>

 pkgname=waifu2x-ncnn-vulkan-git
-pkgver=20200606.r0.gcd12dff
+pkgver=20200818.r0.g8b5c1cd
 pkgrel=1
 pkgdesc="waifu2x converter ncnn version, runs fast on intel / amd / nvidia GPU with vulkan"
 url="https://github.com/nihui/waifu2x-ncnn-vulkan"
 license=('MIT')
-depends=('vulkan-icd-loader' 'vulkan-driver')
-makedepends=('git' 'cmake' 'glslang' 'vulkan-headers')
+depends=('vulkan-icd-loader' 'vulkan-driver' 'libwebp')
+makedepends=('git' 'cmake' 'glslang' 'vulkan-headers' 'ncnn')
 conflicts=('waifu2x-ncnn-vulkan')
 provides=('waifu2x-ncnn-vulkan')
 arch=('i686' 'x86_64')
@@ -27,9 +27,6 @@ pkgver() {
 prepare() {
     cd "${srcdir}/waifu2x-ncnn-vulkan"

-    # init ncnn submodule
-    git submodule update --init --recursive
-
     # Fix default model path
     sed -i 's|path_t model = PATHSTR("models-cunet")|path_t model = PATHSTR("/usr/share/waifu2x-ncnn-vulkan/models-cunet")|' src/main.cpp
 }
@@ -40,6 +37,9 @@ build() {
     cd build
     cmake \
         -DCMAKE_INSTALL_PREFIX=/usr \
+        -DGLSLANG_TARGET_DIR=/usr/lib/cmake \
+        -DUSE_SYSTEM_NCNN=on \
+        -DUSE_SYSTEM_WEBP=on \
         ..
     make
 }

Thanks, I updated the pkgbuild for the ncnn submodule.

Had to add

git submodule update --init

to the prepare function after the cd command.

Now it works, good work

I've added a ncnn package that follows releases instead of git master. Try removing ncnn-git then rebuilding.

Like the others said, the output is always a black image (just sayin').

Tried your value and the minimum, 32. Both returned black image. I will start an issue on the github page.

There used to be some bugs that caused black images if you ran out of vram, but should have been fixed and throw an error instead.

You could try setting -t 200 to reduce the tile size and see if it helps. If not you should start an issue upstream: https://github.com/nihui/waifu2x-ncnn-vulkan/issues

Installed latest ncnn-git and recompiled the package, it didn't help.

Not sure how to check the vulkan driver, but I have a GTX 1060 running nvidia driver version 440.82

It works for me with: ncnn-git: 20200413.r10.gbd55ddcf-1 waifu2x-ncnn-vulkan-git: 20200414.r1.g23a679c-1

Try updating ncnn, then recompiling this package. If that doesn't help, what's your hardware and vulkan driver you're using? It may be an upstream issue.

No matter what picture I give it the output is always a completely black 4k image. Edit : should probably add that the program reports no errors with the verbose tag

ncnn changed something that breaks this. Upstream will need to fix it, but until then I've pinned ncnn-git at a commit that works. You'll need to rebuild ncnn-git then this should compile.

This error shows up when compiling

make[2]: *** [CMakeFiles/waifu2x-ncnn-vulkan.dir/build.make:93: CMakeFiles/waifu2x-ncnn-vulkan.dir/waifu2x.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/niko/.cache/yay/waifu2x-ncnn-vulkan-git/src/waifu2x-ncnn-vulkan/src/build'
make[1]: *** [CMakeFiles/Makefile2:121: CMakeFiles/waifu2x-ncnn-vulkan.dir/all] Error 2
make[1]: Leaving directory '/home/niko/.cache/yay/waifu2x-ncnn-vulkan-git/src/waifu2x-ncnn-vulkan/src/build'
make: *** [Makefile:101: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
Error making: waifu2x-ncnn-vulkan-git

idk where to mention this except here so ¯_(ツ)_/¯

good catch, fixed.

was 'add upconv_7_photo model' https://github.com/nihui/waifu2x-ncnn-vulkan/commit/b373ce2ec7184959e3b9bea985a90ab1964d1f87
but it's not pick into package after build - pls fix it

--- PKGBUILD_old    2020-01-13 19:02:49.638479000 +0300
+++ PKGBUILD    2020-01-13 19:11:14.357340893 +0300
@@ -54,4 +54,7 @@
     for f in models-upconv_7_anime_style_art_rgb/*; do
         install -Dm 644 "$f" ${pkgdir}/usr/share/waifu2x-ncnn-vulkan/"$f"
     done
+    for f in models-upconv_7_photo/*; do
+        install -Dm 644 "$f" ${pkgdir}/usr/share/waifu2x-ncnn-vulkan/"$f"
+    done
 }

Fixed!

Could you update the dependencies?

depends=('vulkan-icd-loader' 'vulkan-driver') makedepends=('git' 'cmake' 'ncnn-git')

ncnn-git is only needed while building, and vulkan-driver must be installed for it to actually work.

Models are installed to /usr/share/models instead of /usr/share/waifu2x-ncnn-vulkan