Package Details: xournalpp-git 1.2.3.r332.g67289c850-1

Git Clone URL: https://aur.archlinux.org/xournalpp-git.git (read-only, click to copy)
Package Base: xournalpp-git
Description: Xournal++ is a handwriting Notetaking software with PDF annotation support. Supports Pen input like Wacom Tablets.
Upstream URL: https://github.com/xournalpp/xournalpp
Keywords: annotation notebook pdf tablet
Licenses: GPL2
Conflicts: xournalpp
Submitter: ka2107
Maintainer: thynkon
Last Packager: thynkon
Votes: 28
Popularity: 0.44
First Submitted: 2015-10-18 01:29 (UTC)
Last Updated: 2024-08-25 13:51 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 11 .. 13 Next › Last »

sikmir commented on 2019-07-23 19:35 (UTC)

@youduda. hmm, that's strange. I've just commented out lua detection in CMakeLists.txt, so Lua_FOUND is not true and ENABLE_PLUGINS is not true. After such build everything works properly, Xournalpp doesn't try to load lua libs (checked by strace -T -e trace=openat ./xournalpp) and Xournalpp doesn't have Plugin menu section.

youduda commented on 2019-07-23 17:05 (UTC)

Moving lua to optional dependencies breaks plugin support when building in clean environment. For this Xournalpp must support only loading lua libraries when lua is installed.

sikmir commented on 2019-07-23 16:00 (UTC) (edited on 2019-07-23 16:23 (UTC) by sikmir)

One more, you don't need gettext in makedepends.

See wiki page:

Note: The group base-devel is assumed to be already installed when building with makepkg. Members of this group should not be included in makedepends array.

$ pacman -Qi gettext | grep Groups
Groups          : base  base-devel

And move lua to optdepends():

optdepends=('lua>=5.3: Enable Xournal++ Plugins')

sikmir commented on 2019-07-23 15:53 (UTC) (edited on 2019-07-23 16:14 (UTC) by sikmir)

And could you please add check() stage:

-makedepends=('git' 'cmake' 'gettext')
+makedepends=('git' 'cmake' 'gettext' 'cppunit>=1.12')
...
-       cmake -DCMAKE_INSTALL_PREFIX="/usr/" -DDEV_CONFIG_DIR="$configdir/xournalpp" ..
-       make
+       cmake -DCMAKE_INSTALL_PREFIX="/usr/" -DDEV_CONFIG_DIR="$configdir/xournalpp" -DENABLE_CPPUNIT=ON ..
+       cmake --build .
...
+check() {
+       cd "${srcdir}/${_pkgname}/build"
+
+       cmake --build . --target test
+}

sikmir commented on 2019-07-23 15:35 (UTC) (edited on 2019-07-23 16:19 (UTC) by sikmir)

Minor fix ('r' before number of commits, ref. pkgver):

$ git describe --tags | sed -e 's|v||g' -e 's|glib.||g' -e 's|-|.|g'
1.0.13.nightly.20190709.86.g02084518
$ git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
1.0.13.nightly.20190709.r86.g02084518

eliasrg commented on 2019-03-21 02:37 (UTC)

The line configdir="$XDG_CONFIG_HOME" seems wrong, as $XDG_CONFIG_HOME is assumed by the standard (https://developer.gnome.org/basedir-spec/) to be an absolute path. I suggest replacing it with

configdir="$(realpath --relative-to="$HOME" "$XDG_CONFIG_HOME")"

to ensure that DEV_CONFIG_DIR is relative to the user's home dir (as specified in cmake/README.md).

swiftscythe commented on 2019-03-12 00:12 (UTC)

new revision requires libzip: https://github.com/xournalpp/xournalpp/commit/a05afb4d3e0acf388a5bb55e86d14582fd2a9e48

LittleHuba commented on 2019-03-05 19:44 (UTC)

alsa-utils, curl and vlc are no longer required as dependencies, as recording is now directly handled by using portaudio

youduda commented on 2019-02-27 22:41 (UTC)

Fixed, empty bash function, I sometimes forget that this is not allowed.

macxcool commented on 2019-02-27 21:23 (UTC) (edited on 2019-02-27 21:24 (UTC) by macxcool)

Got this on the run of the install script:

(1/1) upgrading xournalpp-git

[----------------------------------] 100%

/tmp/alpm_Bbr6Cw/.INSTALL: line 2: syntax error near unexpected token `}'

/tmp/alpm_Bbr6Cw/.INSTALL: line 2: `}'

/usr/bin/bash: post_upgrade: command not found

error: command failed to execute correctly

« First ‹ Previous 1 2 3 4 5 6 7 8 9 10 11 .. 13 Next › Last »