Arch Linux User Repository

Hello,

please fix the install to add the new ya binary

diff --git a/PKGBUILD b/PKGBUILD
index fb7e347..07434e7 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -49,6 +49,7 @@ check() {
 package() {
   cd "$srcdir/$_pkgname"
   install -Dm755 "target/release/$_pkgname" "$pkgdir/usr/bin/$_pkgname"
+  install -Dm755 "target/release/ya" "$pkgdir/usr/bin/ya"
   install -Dm644 "LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENCE"
   install -Dm644 "README.md" "$pkgdir/usr/share/doc/$pkgname/README.md"
   install -Dm644 "assets/yazi.desktop" "$pkgdir/usr/share/applications/yazi.desktop"

Please fix missing makedepends

diff --git i/PKGBUILD w/PKGBUILD
index 2af18d1..08b3278 100644
--- i/PKGBUILD
+++ w/PKGBUILD
@@ -19,7 +19,7 @@ optdepends=(
     'fzf: for directory jumping'
     'poppler: for PDF preview'
     'zoxide: for directory jumping')
-makedepends=(cargo git)
+makedepends=(cargo git imagemagick)
 options=(!lto)
 provides=(yazi)
 conflicts=(yazi)

The package is broken. The PKGBUILD should be modified as follows:

diff --git a/PKGBUILD b/PKGBUILD
index 8116177..78284ab 100644
--- a/PKGBUILD
+++ b/PKGBUILD

@@ -59,7 +59,7 @@ package() {
     convert assets/logo.png -resize "${r}x${r}" "$pkgdir/usr/share/icons/hicolor/${r}x${r}/apps/yazi.png"
   done

-  cd "$_pkgname-config/completions"
+  cd "$srcdir/$_pkgname/$_pkgname-boot/completions"
   install -Dm644 "$_pkgname.bash" "$pkgdir/usr/share/bash-completion/completions/$_pkgname"
   install -Dm644 "$_pkgname.fish" -t "$pkgdir/usr/share/fish/vendor_completions.d/"
   install -Dm644 "_$_pkgname" -t "$pkgdir/usr/share/zsh/site-functions/"

Getting an error when trying to install, any idea what might be causing the folder to not get generated?:

/home/rolv/.cache/paru/clone/yazi-git/PKGBUILD: line 62: cd: yazi-config/completions: No such file or directory
==> ERROR: A failure occurred in package().
    Aborting...
error: failed to build 'yazi-git-0.2.3.r30.g0cb572a-1':
error: packages failed to build: yazi-git-0.2.3.r30.g0cb572a-1

Now that convert(1) is called by package() please include imagemagick in makedepends array so it can be built in a clean chroot.

I update fail. The problem read:

/usr/include/c++/13.2.1/optional:477: constexpr _Tp& std::_Optional_base_impl<_Tp, _Dp>::_M_get() [with _Tp = llvm::DIExpression::FragmentInfo; _Dp = std::_Optional_base<llvm::DIExpression::FragmentInfo, true, true>]: Assertion 'this->_M_is_engaged()' failed.
error: could not compile `yazi-fm` (bin "yazi")

Thanks for accepting the patch!

However, the license is still installed in a wrong folder. It should be /usr/share/licenses/yazi-git/ and not /usr/share/licenses/yazi/.

The package is still broken if lto is enabled in makepkg settings. It needs to be overriden in PKGBUILD.

git is still missing from makedepends.

So does conflicts=(yazi).

pkgver() funciton is still broken and returns an empty string.

Moreover, it still doesn't strip the "v" prefix. And no, https://aur.archlinux.org/cgit/aur.git/commit/?h=yazi-git&id=f1365b01ed9b7ca6078d4daffd0bfa552e73bce8 is not how you do it. Not to mention you reverted this meaningless change in the next commit anyway. https://aur.archlinux.org/cgit/aur.git/commit/?h=yazi-git&id=5fa63da3634d5af5375ad42972697da6bf3f6366

Also, the license is installed into a wrong folder.

Here's a proper patch to PKGBUILD. Hopefully, it will be helpful.

diff --git a/PKGBUILD b/PKGBUILD
index f65d232..a1eeab8 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,8 +2,8 @@

 _pkgname=yazi
 pkgname=yazi-git
-pkgver=v0.1.4.r57.gcb13de9
-pkgrel=2
+pkgver=0.1.4.r57.gcb13de9
+pkgrel=1
 pkgdesc="Blazing fast terminal file manager written in Rust, based on async I/O."
 url="https://github.com/sxyazi/yazi"
 arch=("x86_64")
@@ -18,14 +18,16 @@ optdepends=(
     'fzf: for directory jumping'
     'poppler: for PDF preview'
     'zoxide: for directory jumping')
-makedepends=(cargo)
+makedepends=(cargo git)
+options=(!lto)
 provides=(yazi)
+conflicts=(yazi)
 source=("git+https://github.com/sxyazi/$_pkgname.git")
 sha256sums=('SKIP')

 pkgver() {
   cd "$_pkgname"
-  git describe --long --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
+  git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/^v//'
 }

 prepare() {
@@ -45,7 +47,7 @@ check() {

 package() {
   cd "$srcdir/$_pkgname"
-  install -Dm644 "LICENSE" "$pkgdir/usr/share/licenses/$_pkgname/LICENSE"
+  install -Dm644 "LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
   install -Dm755 "target/release/$_pkgname" "$pkgdir/usr/bin/$_pkgname"
 }

build is failing at the moment because of pkgver(): fatal: No annotated tags can describe '8e72ae90c1ef56e50191cfa1a8db30beb68065f6'. However, there were unannotated tags: try --tags.

I had to delete yazi-git first, to install yazi package.