Package Details: ytdlp-gui 1.0.2-1

Git Clone URL: https://aur.archlinux.org/ytdlp-gui.git (read-only, click to copy)
Package Base: ytdlp-gui
Description: a GUI for yt-dlp written in Rust
Upstream URL: https://github.com/BKSalman/ytdlp-gui
Keywords: downloader video
Licenses: GPL3
Submitter: bksalman
Maintainer: bksalman
Last Packager: bksalman
Votes: 4
Popularity: 0.35
First Submitted: 2023-01-18 23:11 (UTC)
Last Updated: 2024-02-26 21:46 (UTC)

Latest Comments

1 2 Next › Last »

bksalman commented on 2023-07-28 07:17 (UTC) (edited on 2023-07-28 07:20 (UTC) by bksalman)

@sqfreak I have a symlink to the PKGBUILD on my machine, and I just edit that, but for some reason the sha256sum update didn't get passed? I'm really not sure what happened, anyways sorry for how messy this package is, I'm stupid

(will update it soon)

sqfreak commented on 2023-07-27 23:21 (UTC)

I think you may have missed updating the sha256sum for 0.3.0. The one I get from the file on Github is dee55b85f303b10dd9a3d922a9ec757a3b7c6c953da447e7e5effb2857f51d3f and the package has b7e1a8350dc69f583122df4bc43c6968ab1f11a3282472f1fc52b47630387f0c, which is the sha256sum for version 0.2.5 on Github.

bksalman commented on 2023-07-27 15:50 (UTC)

@JisuWoniu oops, thanks for spotting it for me! will push a fix soon

JisuWoniu commented on 2023-07-27 15:16 (UTC)

You made a typo in build function. Should be --frozen instead of --forzen.

bksalman commented on 2023-07-27 06:25 (UTC) (edited on 2023-07-27 07:09 (UTC) by bksalman)

so how about this? @eclairevoyant

pkgname=ytdlp-gui
pkgver=0.3.0
pkgrel=1
pkgdesc="a GUI for yt-dlp written in Rust"
url="https://github.com/BKSalman"
license=("GPL3")
arch=("x86_64")
makedepends=( "cargo" "pkgconf" "git" )
depends=("ffmpeg" "yt-dlp")

source=("$pkgname-$pkgver.tar.gz::${url}/ytdlp-gui/archive/refs/tags/v${pkgver}.tar.gz")
sha256sums=("b7e1a8350dc69f583122df4bc43c6968ab1f11a3282472f1fc52b47630387f0c")

prepare() {
    cd "$pkgname-${pkgver}"
    export RUSTUP_TOOLCHAIN=stable
    cargo fetch --locked --target "$CARCH-unknown-linux-gnu"
}

build() {
    cd "$pkgname-${pkgver}"
    export RUSTUP_TOOLCHAIN=stable
    export CARGO_TARGET_DIR=target
    cargo build --forzen --release
}

package() {
    cd "$pkgname-${pkgver}"

    install -Dm755 "${CARGO_TARGET_DIR:-target}/release/ytdlp-gui" "$pkgdir/usr/bin/ytdlp-gui"
    install -Dm755 "data/applications/ytdlp-gui.desktop" "$pkgdir/usr/share/applications/ytdlp-gui.desktop"
    for _size in "16x16" "32x32" "48x48" "64x64" "128x128" "256x256"; do
        install -Dm644 "data/icons/$_size/apps/ytdlp-gui.png" "$pkgdir/usr/share/icons/hicolor/$_size/apps/ytdlp-gui.png"
    done

    install -Dm644 LICENSE "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
}

does it address the points you mentioned? (I'm bumping the version, that's why it's 0.3.0)

eclairevoyant commented on 2023-06-10 11:07 (UTC) (edited on 2023-06-10 11:09 (UTC) by eclairevoyant)

Please update this package to conform to Rust package guidelines, most notably:

  • Using cargo as a build dependency instead of rust directly

  • separation of fetching dependencies into prepare()

  • using the --frozen flag in build() so that build() runs offline

  • exporting rust-related envvars at the top of prepare() and build() (technically optional, but helps avoid a lot of issues when users build from AUR)

EDIT: also couple of other points:

bksalman commented on 2023-03-29 19:44 (UTC)

@je-vv sorry for not replying friend :), Hope you're doing well, just fixed it now!

Thank you very much for showing care about this package, I'm not an Arch user so these things could happen because I'm not actually using the package

je-vv commented on 2023-03-04 23:33 (UTC) (edited on 2023-03-04 23:36 (UTC) by je-vv)

Actually @bksalman, you can totally remove rustup and cargo altogether. Not sure why they were added, :(

% pacman -Qi rust
Provides        : cargo  rustfmt
% pacman -Si rustup
Provides        : rust  cargo  rust-nightly  cargo-nightly  rustfmt  rust-src  lib32-rust-libs  rust-musl  rust-wasm

As you can see, both rust and rustup provide cargo, so no need to have it as a dep, though it doesn't harm. And both rustup and rust provide rust, so you should remove rustup as a dep. If you have it installed, it's fine, it won't prompt you to install rust because rustup already provides it, and if you have installed rust, that's it. Just notice rustup and rust are in conflict, so as things are right now you're forcing users to de-install rust and install rustup, which doesn't make any sense.

je-vv commented on 2023-03-03 02:00 (UTC)

why force the dependency on rustup now? it should depend on a rust provided only. It was building fine when having rust installed instead of rustup. Besides, I don't see a dependency on any nightly toolchain or similar. Can you make it depend on rust, and then rustup users will be fine, since it provides rust?

bksalman commented on 2023-03-02 17:32 (UTC)

@JisuWoniu sorry for not replying :) I fixed it now