Arch Linux User Repository

@RAMChYLD ouch it looks like their main branch was force-pushed, changing the context of that pull request and hence the patch contents that are downloaded: https://github.com/GPUOpen-Drivers/pal/pull/94#event-9326017384

Guess I'll use an immediate hash to the commit the next time around, or check the patch in to this package repo for simplicity. For now you can replace the source link with https://github.com/GPUOpen-Drivers/pal/commit/935599d77310f1b6968d69c229301fb43f38e11d.patch, I'll push a fix for that soon.

Getting a build error:

==> Making package: amdvlk-git 2023.Q2.2.r0.ec40bda-1 (Thu 25 May 2023 11:20:34 PM +08)
==> Retrieving sources...
  -> Found 94.patch
==> Validating source files with sha256sums...
    94.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!
 -> error downloading sources: /home/leecy/.cache/yay/amdvlk-git 
         context: exit status 1 


:: (1/1) Parsing SRCINFO: amdvlk-git
==> Making package: amdvlk-git 2023.Q2.2.r0.ec40bda-1 (Thu 25 May 2023 11:20:36 PM +08)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found 94.patch
==> Validating source files with sha256sums...
    94.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!
 -> error making: amdvlk-git-exit status 1
 -> Failed to install the following packages. Manual intervention is required:
amdvlk-git - exit status 1

@bio3c thanks for reporting! I've ran into the same error here and in other codebases after upgrading to gcc-13. This requires the following upstream fix to the PAL repository:

https://github.com/GPUOpen-Drivers/pal/pull/94

If necessary I can push a temporary workaround to the PKGBUILD that applies this patch before commencing the build.

i'm having errors building it, pretty much all errors are as such:

[59/2700] Building CXX object pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o
FAILED: pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o
/usr/bin/c++ -DRDF_BUILD_LIBRARY -DRDF_BUILD_STATIC=1 -DRDF_PLATFORM_UNIX=1 -I/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/inc -I/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/imported/zstd/inc -march=x86-64 -mtune=generic -O2 -pipe  -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -O3 -DNDEBUG -std=c++11 -fPIC   -flto -fuse-linker-plugin -Wno-odr -fPIC -MD -MT pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o -MF pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o.d -o pal/src/core/imported/rdf/rdf/CMakeFiles/amdrdf.dir/src/amdrdf.cpp.o -c /var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/src/amdrdf.cpp
In file included from /var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/src/amdrdf.cpp:25:
/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/inc/amdrdf.h:112:39: error: ‘int64_t’ in namespace ‘std’ does not name a type
  112 |     int (*Read)(void* ctx, const std::int64_t count, void* buffer, std::int64_t* bytesRead);
      |                                       ^~~~~~~
/var/tmp/pamac-build-ian/amdvlk-git/src/drivers/pal/src/core/imported/rdf/rdf/inc/amdrdf.h:112:73: error: ‘std::int64_t’ has not been declared
  112 |     int (*Read)(void* ctx, const std::int64_t count, void* buffer, std::int64_t* bytesRead);
      |                                                                         ^~~~~~~

@marijns - if there's no need to bump then it's okay. I still do not really understand how the git thing works and thought it will still pull the 2022.Q4.4 tree only.

Thanks, and sorry.

@RAMChYLD this is a git package and the latest source is automatically fetched on build: pkgver() also updates the version in PKGBUILD. I just built the package with Q1.3 and see the extension in vulkaninfo for this device/driver, without making any manual changes to PKGBUILD. Can you clarify what "refactor" you are expecting, is there a specific build/runtime error?

Consequently pushing new PKGBUILD just to bump pkgver is uncommon for git/vcs packages, pkgver() is supposed to prevent such churn. Unless there's a request to bump it on tagged releases just to show compatibility with the latest version here on the AUR?

AMDVLK 2023.Q1.3 is out and the biggest feature is it now supports VK_EXT_physical_device_drm which is needed by gamescope. Can we have a refactor to that version?

amdvlk-git/src/drivers/pal/shared/gpuopen/cmake/AMD.cmake should be changed to amdvlk-git/src/drivers/pal/shared/devdriver/cmake/AMD.cmake right?

The package has issues with replacing amdvlk so I made a light change in it and checked if the latest git release works.

# Maintainer: haagch
# Contributor: TheK0tYaRa

pkgname=amdvlk-git
pkgver=v.2021.Q1.1.r7.e77387b
pkgrel=1
pkgdesc="AMD's standalone Vulkan driver"
arch=(x86_64)
url="https://github.com/GPUOpen-Drivers"
license=('MIT')
depends=('vulkan-icd-loader')
provides=('vulkan-amdvlk' 'vulkan-driver')
conflicts=('vulkan-amdvlk' 'amdvlk')
replaces=('amdvlk')
makedepends=('xorgproto' 'xorg-server-devel' 'libxrandr' 'cmake' 'python' 'libxml2' 'wayland' 'libdrm' 'git' 'ninja' 'repo')
source=()
sha512sums=()

pkgver() {
  pushd drivers/AMDVLK > /dev/null
  AMDVLK_VER=$(printf "%s" "$(git describe --long | sed 's/\([^-]*-\)g/r\1/;s/-/./g')")
  popd > /dev/null
  if [ -z "$AMDVLK_VER" ]; then
    pushd drivers/xgl > /dev/null
    XGL_VER=$(printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)")
    popd > /dev/null
  else
    XGL_VER=$AMDVLK_VER
  fi
  #PAL_VER=$(cd pal; printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)")
  echo "$XGL_VER"
}

prepare() {
  cd "$srcdir"
  repo init -u 'https://github.com/GPUOpen-Drivers/AMDVLK.git' -b master
  repo sync
  # fix building with commit f609020
  # sed -i "s/<drm/<libdrm/g" pal/src/core/os/lnx/display/displayWindowSystem.h
  # pushd "$srcdir/pal"
  # patch -p1 < ../0001-pal-clang.patch
  # popd
  # pushd "$srcdir/xgl"
  # patch -p1 < ../0002-xgl-clang.patch
  # popd

  # Don't turn Werror on for people will build with more recent compilers than you have. Just don't.
  for i in drivers/pal/shared/gpuopen/cmake/AMD.cmake #drivers/llpc/llpc/CMakeLists.txt
  do
    #sed -i "s/-Werror=unused-variable//g" "$srcdir"/$i
    #sed -i "s/-Werror=unused-function//g" "$srcdir"/$i
    sed -i "s/-Werror//g" "$srcdir"/$i
  done

  msg 'No patches to apply...'
}

build() {
  # /usr/lib/amdvlk64.so: undefined symbol: _ZN3Pal5Linux19DisplayWindowSystem30DeterminePresentationSupportedEPNS0_6DeviceEPvl
  # msg "Changing flags..."
  # msg2 "before: CFLAGS=$CFLAGS"
  export CFLAGS=${CFLAGS/-fno-plt}
  # msg2 "after: CFLAGS=$CFLAGS"
  # msg2 "before: CXXFLAGS=$CXXFLAGS"
  export CXXFLAGS="${CXXFLAGS/-fno-plt}"
  # msg2 "after: CXXFLAGS=${CXXFLAGS}"
  # msg2 "before: LDFLAGS=$LDFLAGS"
  export LDFLAGS=${LDFLAGS/,-z,now}
  # msg2 "after: LDFLAGS=${LDFLAGS}"
  # export CPPFLAGS="$CXXFLAGS"

  msg "building xgl..."
  pushd drivers/xgl > /dev/null
  cmake \
    -G Ninja \
    -H. \
    -B builds/Release64 \
    -DBUILD_WAYLAND_SUPPORT=On \
    -DCMAKE_BUILD_TYPE=Release
    -DBUILD_XLIB_XRANDR_SUPPORT=On \
    || true

  cd builds/Release64
  ninja
  msg "building xgl finished!"

  msg "building spvgen"
  pushd ../../../spvgen/external > /dev/null
  python2 fetch_external_sources.py
  popd > /dev/null
  ninja spvgen
  msg "building spvgen finished!"
  popd > /dev/null

  #msg "building spvgen"
  #pushd drivers/spvgen > /dev/null
  #cmake \
  #  -G Ninja \
  #  -B builds/Release64 \
  #  -DCMAKE_BUILD_TYPE=Release \
  #  .
  #cd builds/Release64
  #ninja
  #msg "building spvgen finished!"
}

package() {
  install -m755 -d "${pkgdir}"/usr/lib
  install -m755 -d "${pkgdir}"/usr/share/licenses/amdvlk-git
  install -m755 -d "${pkgdir}"/etc/amd

  install -D -t "$pkgdir/usr/lib" drivers/xgl/builds/Release64/icd/amdvlk64.so drivers/xgl/builds/Release64/spvgen/spvgen.so
  install -D -m644 -t "${pkgdir}/usr/share/vulkan/icd.d" drivers/AMDVLK/json/Redhat/amd_icd64.json
  install -D -m644 -t "${pkgdir}/usr/share/licenses/amdvlk-git" drivers/AMDVLK/LICENSE.txt

  sed -i "s/\/lib64/\/lib/g" "${pkgdir}"/usr/share/vulkan/icd.d/amd_icd64.json
}

Weirdly, this git version is older than repo's.