Arch Linux User Repository

Hi,

I encounter a compile error using "pamac update gtkhash-thunar" or manually compiling package after cloning and adding "export PKG_CONFIG_PATH=/usr/lib/nettle3/pkgconfig" line in Build() section of PKGBUILD

INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /home/olivier/aur/gtkhash-thunar/src/build
ninja: Entering directory `/home/olivier/aur/gtkhash-thunar/src/build'
[1/65] Compiling C object src/hash/libhash.a.p/hash-lib-nettle.c.o
FAILED: [code=1] src/hash/libhash.a.p/hash-lib-nettle.c.o
cc -Isrc/hash/libhash.a.p -Isrc/hash -I../gtkhash-1.5/src/hash -I. -I../gtkhash-1.5 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -fno-common -fvisibility=hidden -pedantic -Waggregate-return -Wbad-function-cast -Wcast-align -Werror=implicit-function-declaration -Wfloat-equal -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wformat -Wlogical-op -Wmissing-declarations -Wmissing-noreturn -Wredundant-decls -Wshadow -Wswitch-default -Wundef -Wwrite-strings -DHAVE_CONFIG_H -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -flto=auto -fPIC -pthread -DIN_HASH_LIB -MD -MQ src/hash/libhash.a.p/hash-lib-nettle.c.o -MF src/hash/libhash.a.p/hash-lib-nettle.c.o.d -o src/hash/libhash.a.p/hash-lib-nettle.c.o -c ../gtkhash-1.5/src/hash/hash-lib-nettle.c
../gtkhash-1.5/src/hash/hash-lib-nettle.c: In function 'gtkhash_hash_lib_nettle_finish':
../gtkhash-1.5/src/hash/hash-lib-nettle.c:106:47: error: passing argument 2 of '((struct hash_lib_nettle_s *)func->lib_data)->meta->digest' makes pointer from integer without a cast [-Wint-conversion]
  106 |         LIB_DATA->meta->digest(LIB_DATA->ctx, *size, digest);
      |                                               ^~~~~
      |                                               |
      |                                               size_t {aka long unsigned int}
../gtkhash-1.5/src/hash/hash-lib-nettle.c:106:47: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'size_t' {aka 'long unsigned int'}
../gtkhash-1.5/src/hash/hash-lib-nettle.c:36:19: error: too many arguments to function '((struct hash_lib_nettle_s *)func->lib_data)->meta->digest'; expected 2, have 3
   36 | #define LIB_DATA ((struct hash_lib_nettle_s *)func->lib_data)
      |                  ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../gtkhash-1.5/src/hash/hash-lib-nettle.c:106:9: note: in expansion of macro 'LIB_DATA'
  106 |         LIB_DATA->meta->digest(LIB_DATA->ctx, *size, digest);
      |         ^~~~~~~~
In file included from ../gtkhash-1.5/src/hash/hash-lib-nettle.c:28:
/usr/include/nettle/nettle-meta.h:109:28: note: declared here
  109 |   nettle_hash_digest_func *digest;
      |                            ^~~~~~
[6/65] Compiling C object src/gtkhash.p/list.c.o
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...

Thanks for your work

Hi there, sorry but adding nettle3 to the "depends" is not enough.

As nettle version 4 is probably already installed in recent system, this is the one picked for building.

The export PKG_CONFIG_PATH=/usr/lib/nettle3/pkgconfig line in build() function given by @jihem in the previous comment is really mandatory.
(as I just did by editing the PKGBUILD before building)

Thanks

The project is not compatible with nettle4 and should be built with nettle3:

--- a/PKGBUILD
+++ b/PKGBUILD
@@ -16,7 +16,7 @@ depends=(
     'gtk3'
     'libb2'
     'libgcrypt'
-    'nettle'
+    'nettle3'
     'thunar'
 )

@@ -45,6 +45,8 @@ prepare() {
 }

 build() {
+  export PKG_CONFIG_PATH=/usr/lib/nettle3/pkgconfig
+
   arch-meson "gtkhash-$pkgver" build \
     -Dglib-checksums='true' \
     -Dlinux-crypto='true' \

I can also confirm it now installs and works great :)

Thx again @Sam-Burgos for your time.

Thanks for the update again @Sam-Burgos. Heh, we post at the same time.

Checking the upstream repo, I was wondering why you opted for mbedtls when libgcrypt and libb2 are the default. Must have been an older version thing. Anyway, I can confirm that it now builds successfully and it works in Thunar as well. Thank you!

Thanks for the update @Sam-Burgos.

Same issue as hvcr again. The new issue seems to be that mbedtls2 is designed to co-exist with the other mbedtls (latest version) package. They do not conflict and can both be installed at the same time. However, the way that's achieved is:

• mbedtls headers and libraries are installed into:
  • /usr/include/mbedtls/
  • /usr/lib/
• mbedtls2 headers and libraries are installed into:
  • /usr/include/mbedtls2/mbedtls/
  • /usr/lib/mbedtls2/

But Meson is looking for the headers at /usr/include/mbedtls/ and cannot find them if mbedtls is not installed (and mbedtls2 is installed instead).

Doing a sed -i 's|mbedtls/md.h|mbedtls2/mbedtls/md.h|' meson.build will fix the "mbedtls/md.h not found" error, but then it still won't be able to find the mbedcrypto library and will fail with the following error:

gtkhash-1.5/meson.build:128:7: ERROR: C shared or static library 'mbedcrypto' not found

Since this is a library, a simple sed like above won't fix that. So I'm not sure what the best solution here is at the moment. May have to configure Meson to include these mbedtls2 directories when searching headers and libraries.

@hvcr @porcaror can you please check now if it works? It took me a while since I was also checking if I need to remove, change or add additional dependencies and also it seems that mbedtls its no longer used, again and as usual, please clean the cache of your AUR helper and please try once again

EDIT: @Saduff (and also others affected): please clean your AUR helper cache, this version no longer requires mbedtls and as mentioned before, I have removed it from the dependencies and should no longer need it (unless you have a conflict on another package)

It doesn't work. This is the error:

NFO: autodetecting backend as ninja INFO: calculating backend command to run: /usr/bin/ninja -C /home/porcaror/.cache/yay/gtkhash-thunar/src/build ninja: Entering directory `/home/porcaror/.cache/yay/gtkhash-thunar/src/build' [58/98] Compiling C object src/hash/libhash.a.p/hash-lib-mbedtls.c.o FAILED: src/hash/libhash.a.p/hash-lib-mbedtls.c.o cc -Isrc/hash/libhash.a.p -Isrc/hash -I../gtkhash-1.5/src/hash -I. -I../gtkhash-1.5 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/libmount -I/usr/include/blkid -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -fno-common -fvisibility=hidden -pedantic -Waggregate-return -Wbad-function-cast -Wcast-align -Werror=implicit-function-declaration -Wfloat-equal -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wformat -Wlogical-op -Wmissing-declarations -Wmissing-noreturn -Wredundant-decls -Wshadow -Wswitch-default -Wundef -Wwrite-strings -DHAVE_CONFIG_H -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fPIC -pthread -DIN_HASH_LIB -MD -MQ src/hash/libhash.a.p/hash-lib-mbedtls.c.o -MF src/hash/libhash.a.p/hash-lib-mbedtls.c.o.d -o src/hash/libhash.a.p/hash-lib-mbedtls.c.o -c ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c: In function ‘gtkhash_hash_lib_mbedtls_set_type’: ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c:46:33: error: ‘MBEDTLS_MD_MD2’ undeclared (first use in this function); did you mean ‘MBEDTLS_MD_MD5’? 46 | type = MBEDTLS_MD_MD2; | ^~~~~~~~~~~~~~ | MBEDTLS_MD_MD5 ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c:46:33: note: each undeclared identifier is reported only once for each function it appears in ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c:49:33: error: ‘MBEDTLS_MD_MD4’ undeclared (first use in this function); did you mean ‘MBEDTLS_MD_MD5’? 49 | type = MBEDTLS_MD_MD4; | ^~~~~~~~~~~~~~ | MBEDTLS_MD_MD5 ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c: In function ‘gtkhash_hash_lib_mbedtls_finish’: ../gtkhash-1.5/src/hash/hash-lib-mbedtls.c:132:50: error: ‘mbedtls_md_context_t’ has no member named ‘md_info’ 132 | *size = mbedtls_md_get_size(LIB_DATA->ctx.md_info); | ^ [63/98] Compiling C object src/hash/libhash.a.p/hash-lib-zlib.c.o ninja: build stopped: subcommand failed. ==> ERROR: A failure occurred in build(). Aborting... -> error making: gtkhash-thunar-exit status 4 -> Failed to install the following packages. Manual intervention is required: gtkhash-thunar - exit status 4

Can you help me? Thanks in advance. Roberto

Thx a lot @Sam-Burgos for your time.

Most unfortunately I'm still getting an error, it's a different one this time though

"gtkhash-1.5/meson.build:128:7: ERROR: C header 'mbedtls/md.h' not found"

Here's the full output in case it helps https://pastebin.com/9raxK7TR

This is what I did:

• uninstalled mbedtls
• cleared pacman cache (pacman -Sc)
• cleared yay cache (yay -Sc), yeah I know this also cleans pacman, but just to be sure
• installed mbedtls2
• tried installing gtkhash-thunar (yay -Sy gtkhash-thunar)

I could upload the meson-log if it's of any use too, or maybe I just did something wrong, I'm relatively new to linux, specially arch based

@Saduff @hvcr my apologies for delay on answer, I have been really busy IRL and also I had some issues with the VM I use for AUR and other tests, I have upgraded the package to use mbedtls2 (as it appears on upstream) so there should be no more issues (just clean cache of pacman and your AUR helper)