Arch Linux User Repository

@Givo isn't it solved by -fno-char8_t in CFLAGS?

I'm having a problem building this package and it's being built when I install monado as it is a dependency with the output:

/home/will/.cache/yay/librealsense/src/librealsense-2.56.5/third-party/rsutils/include/rsutils/string/from.h:38:13: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, const char8_t*) [with _Traits = char_traits<char>]’
   38 |         _ss << val;
      |         ~~~~^~~~~~
In file included from /usr/include/c++/16.1.1/bits/unique_ptr.h:42,
                 from /usr/include/c++/16.1.1/memory:80,
                 from /home/will/.cache/yay/librealsense/src/librealsense-2.56.5/include/librealsense2/hpp/rs_types.hpp:18,
                 from /home/will/.cache/yay/librealsense/src/librealsense-2.56.5/include/librealsense2/rs.hpp:8,
                 from /home/will/.cache/yay/librealsense/src/librealsense-2.56.5/common/model-views.cpp:10:
/usr/include/c++/16.1.1/bits/ostream.h:767:5: note: declared here
  767 |     operator<<(basic_ostream<char, _Traits>&, const char8_t*) = delete;
      |     ^~~~~~~~
/home/will/.cache/yay/librealsense/src/librealsense-2.56.5/third-party/rsutils/include/rsutils/string/from.h:38:13: note: use ‘-fdiagnostics-all-candidates’ to display considered candidates
   38 |         _ss << val;
      |         ~~~~^~~~~~
make[2]: *** [tools/depth-quality/CMakeFiles/rs-depth-quality.dir/build.make:93: tools/depth-quality/CMakeFiles/rs-depth-quality.dir/__/__/common/model-views.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2204: tools/depth-quality/CMakeFiles/rs-depth-quality.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: librealsense-exit status 4

I'm not quite sure how to go about fixing this as it seems to be a problem with the package itself and while I feel like I should report this to upstream they don't seem to have instructions for building on arch so I don't know if they'd be inclined to fix it

Hi. I just hit 2 issues.

1. Same issue as cnmatrix (OpenBLAS). Same fix (below).

AFAIU -I flags introduced by pkgconf would run as a fallback only, and solve for any cblas alternative, not only OpenBLAS.

1. Had to also -fno-char8_t.

With this one, I'm not sure if it can be safely added to PKGBUILD for everyone... GCC 7 or earlier doesn't know what char8_t is, though modern systems use GCC 11+ (or Clang 13+).

Obviously, in perfect world it should be solved upstream, but I don't believe it will, hence, a humble request to fix in the PKGBUILD here. Can be combined in one fix at the beginning of build():

_CFLAGSADDITIONS="$(pkgconf --cflags cblas)"
export CFLAGS+=" ${_CFLAGSADDITIONS} -fno-char8_t"
export CXXFLAGS+=" ${_CFLAGSADDITIONS} -fno-char8_t"

Was failing to build with GCC 16. Fix is to modify the start of the build() function:

1. Move "unset HOME" before the CFLAGS/CXXFLAGS lines
2. Add -fno-char8_t to CXXFLAGS

  build() {
    cd "${srcdir}/${pkgname}-${pkgver}"
    mkdir -p build && cd build
    unset HOME
    CFLAGS="${CFLAGS} -Wformat -pthread" \
    CXXFLAGS="${CXXFLAGS} -Wformat -pthread -fno-char8_t" \
    cmake .. \

Package fails to build because of a missing include in the 'master' branch. 'Development' branch has the missing "#include <cstdint>" necessary to resolve the following error:

[ 12%] Building CXX object CMakeFiles/realsense2.dir/src/core/matcher-factory.cpp.o
In file included from /var/cache/private/pamac/librealsense/src/librealsense-2.55.1/src/core/frame-holder.h:5,
                 from /var/cache/private/pamac/librealsense/src/librealsense-2.55.1/src/core/matcher-factory.cpp:5:
/var/cache/private/pamac/librealsense/src/librealsense-2.55.1/src/core/frame-interface.h:27:19: error: ‘uint8_t’ does not name a type
   27 |     virtual const uint8_t * get_frame_data() const = 0;
      |                   ^~~~~~~
/var/cache/private/pamac/librealsense/src/librealsense-2.55.1/src/core/frame-interface.h:6:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include <cstdint>’
    5 | #include <librealsense2/h/rs_frame.h>
  +++ |+#include <cstdint>
    6 | #include <memory>
[ 12%] Built target rs-embed
[ 12%] Building CXX object CMakeFiles/realsense2.dir/src/core/notification.cpp.o
make[2]: *** [CMakeFiles/realsense2.dir/build.make:79: CMakeFiles/realsense2.dir/src/core/matcher-factory.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1023: CMakeFiles/realsense2.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
Finished with result: exit-code

@aminiallight Lifesaver, thanks!

@aminiallight Thank you so much!

@PreciousPika Hi, sorry about the delay. The command I added to the prepare() function is as follows:

patch --directory="${srcdir}/${pkgname}-${pkgver}" --strip=1 < ../add-cstdint.patch

I placed that after the first command (cd) and before the second command (mkdir). There's probably a better way to phrase this but it gets the job done.

Building this package in a clean chroot environment fails as follows:

-- Fetching nlohmann/json...
[...output omitted...]
CMake Error at /usr/share/cmake/Modules/ExternalProject/shared_internal_commands.cmake:943 (message):
  error: could not find git for clone of nlohmann_json
Call Stack (most recent call first):
  /usr/share/cmake/Modules/ExternalProject.cmake:3076 (_ep_add_download_command)
  CMakeLists.txt:5 (ExternalProject_Add)


make: Makefile: No such file or directory
make: *** No rule to make target 'Makefile'.  Stop.
CMake Error at CMake/external_json.cmake:34 (message):
  Failed to download nlohmann/json
Call Stack (most recent call first):
  CMake/external_json.cmake:50 (get_nlohmann_json)
  third-party/CMakeLists.txt:3 (include)
  CMakeLists.txt:58 (include)

Adding git to makedepends fixes this problem.

@aminiallight Hey, I'm a linux beginner after having switched from Windows due to the inclusion of "features" I don't like, how would I use this patch file to fix the build step? I experimented with the steps found on the ArchLinux's wiki, and managed to add the patch file to the source array, but am stumped on the step after adding the Patch file to the prepare() function, since the provided patch file text uses directories 'a' and 'b', and I am unsure what changes to make so that the prepare function properly reads the file's locations and makes the changes needed. If anyone else knows how to do this as well, I'm all ears. Thank you for your time!