Package Details: linphone-desktop-all-git 4.1.1.r663.4a43f00e-1

Git Clone URL: https://aur.archlinux.org/linphone-desktop-all-git.git (read-only, click to copy)
Package Base: linphone-desktop-all-git
Description: A free VoIP and video softphone based on the SIP protocol (Installed in /opt with all deps included).
Upstream URL: https://www.linphone.org/
Licenses: GPL2
Conflicts: linphone, linphone-desktop, linphone-desktop-all
Provides: linphone-desktop, linphone-desktop-all
Submitter: frealgagu
Maintainer: None
Last Packager: frealgagu
Votes: 5
Popularity: 0.000000
First Submitted: 2018-06-26 21:12 (UTC)
Last Updated: 2019-07-20 18:15 (UTC)

Dependencies (23)

Required by (0)

Sources (50)

Latest Comments

« First ‹ Previous 1 2 3 4 5 Next › Last »

frealgagu commented on 2018-08-11 23:58 (UTC)

I've done the changes mentioned. It compiles and works for me.

Do you think I should add the submodules to sources?

https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git_Submodules

Maniaxx commented on 2018-08-11 19:29 (UTC) (edited on 2018-08-11 19:30 (UTC) by Maniaxx)

Uninstall the package first (/opt/linphone-desktop) and then re-build. The wrong rpaths point there. That's why it works for you.

Do not use the python script to pass the parameter. Its unreliable and doesn't work. Make it the official CMake way i linked below. I've tested it and it does work properly. Beside that, the other parameters you pass are useless as well. --list-cmake-variables is just user info and -DENABLE_RELATIVE_PREFIX=YES is already included in the desktop profile (that is default), see prepare.py.

You might want to enable the non-free codecs (AMR, SILK, G729 and H264). So the final build parameter looks like this:

./prepare.py --all-codecs

frealgagu commented on 2018-08-11 02:17 (UTC)

Why do you say that it's not compiling properly? I've installed it in two machines and I'm able to do calls normally.

Maniaxx commented on 2018-08-11 01:49 (UTC)

It doesn't compile properly. Later on, rpaths are wrong in the linker phase. Just a guess, but i think the python script doesn't pass the option properly to all scripts.

frealgagu commented on 2018-08-10 23:04 (UTC)

@Maniaxx Awesome, it works as expected.

I've upgraded the PKGBUILD, but I've left the desktop file with just

Exec=/opt/linphone-desktop/bin/linphone %u

Please confirm that you don't have issues with icons or something else.

Maniaxx commented on 2018-08-10 21:24 (UTC) (edited on 2018-08-10 22:51 (UTC) by Maniaxx)

It might go like this: https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/RPATH-handling

Edit: Seems to work. Set this in the top-level CMakeLists.txt:

# the RPATH to be used when installing
SET(CMAKE_INSTALL_RPATH "/opt/linphone-desktop/lib:/opt/linphone-desktop/lib64")

Edit2: You can check the final rpath e.g. with:

objdump -x /opt/linphone-desktop/bin/linphone |grep RPATH

linphone.desktop can be set to this as well now:

Exec=/opt/linphone-desktop/bin/linphone %u

frealgagu commented on 2018-08-10 21:01 (UTC)

I've not found a way to build the application using relative paths, even passing arguments of RELATIVE_PREFIX_PATH and others, always exists a dependency with the build directory (that's the reason I build in /tmp/linphone-desktop).

I've created the issue https://github.com/BelledonneCommunications/linphone-desktop/issues/194 to see if there is an alternative. But the trouble here must be some of its dependencies (submodules) which establishes absolute paths. If you find a solution please let me know and I'll implement it.

Maniaxx commented on 2018-08-10 20:26 (UTC) (edited on 2018-08-10 20:48 (UTC) by Maniaxx)

Yes, that's correct.

Edit: There is a typo in PKGBUILD

conflicts=("linphone-dekstop")

I'm wondering if its even necessary to link it to the build directory (/tmp/linphone-desktop) in the first place. There should be a build option to set rpath/sysroot independently to /opt/linphone-desktop. On GNU make its possible so CMake should do it as well i think. I will take a look. If i stumble upon something i'll let you know.

frealgagu commented on 2018-08-10 19:50 (UTC) (edited on 2018-08-10 19:50 (UTC) by frealgagu)

The wrapping in sh -c "..." was to solve the starter icon?

Then you mean leave the desktop file as follows:

Type=Application
Exec=sh -c "rm -rf /tmp/linphone-desktop && mkdir -p /tmp/linphone-desktop/OUTPUT && ln -s /opt/linphone-desktop /tmp/linphone-desktop/OUTPUT/desktop && /opt/linphone-desktop/bin/linphone %u"
Icon=linphone

I'll fix it in the next build.

Maniaxx commented on 2018-08-10 19:06 (UTC) (edited on 2018-08-10 19:29 (UTC) by Maniaxx)

Build has finished successfully. Thanks!

But there seems to be a bug in the starter icon. I wrapped the line below into a sh -c "..." and it worked. I'm on XFCE/Thunar.

rm -rf /tmp/linphone-desktop && mkdir -p /tmp/linphone-desktop/OUTPUT && ln -s /opt/linphone-desktop /tmp/linphone-desktop/OUTPUT/desktop && /opt/linphone-desktop/bin/linphone %u