Arch Linux User Repository

To solve these issues once and for all I created this PR here: https://github.com/lawl/NoiseTorch/pull/129

With it we can now define version and distribution build-time, as well as disable the updater similarly.

Fine with me. Version seems to be set just fine if referenced by commit. But I don't think we need pkgver(), I expect this to be bumped manually.

Not to piss on anyones work here. I don't think that you should use git tags as build source, since they can be manipulated by enforcing a new commit to be this and that tag. (correct me if I'm wrong here)

I'd suggest using the commit hash directly. In case of 0.10.1 it's this one: https://github.com/lawl/NoiseTorch/commit/ee91fea993138624dce47b4c0b626a99db25f656 so -> ee91fea993138624dce47b4c0b626a99db25f656

Here the example pkgbuild

# Maintainer:  Travis Collins <erbrecht at pobox dot com>
# Contributor: Justin Kromlinger <hashworks@archlinux.org>

# Note: The upstream maintainer does not allow ANY modifications
# to the source code. Please refrain from doing so.
# https://lists.archlinux.org/pipermail/aur-general/2021-May/036230.html

pkgname=noisetorch
pkgver=0.10.1
pkgrel=5
pkgdesc='Real-time microphone noise suppression on Linux.'
arch=('x86_64')
url=https://github.com/lawl/NoiseTorch
license=('GPL3')
depends=('pulseaudio' 'polkit')
makedepends=('go' 'cmake' 'git')
provides=('noisetorch')
install="${pkgname}.install"
_commit=ee91fea993138624dce47b4c0b626a99db25f656
source=("git+${url}#commit=${_commit}"
        "${pkgname}.install")
sha256sums=('SKIP'
            '171a4179c7e0f3a018a314893e81e598c02cfee274c90d715a302660af920eba')

pkgver() {
  cd NoiseTorch
  git describe --tags | sed 's/-/+/g'
}

build() {
    export GOPATH="$srcdir/go"
    cd NoiseTorch/c/ladspa
    make
    cd ${srcdir}/NoiseTorch
    export CGO_CPPFLAGS="${CPPFLAGS}"
    export CGO_CFLAGS="${CFLAGS}"
    export CGO_CXXFLAGS="${CXXFLAGS}"
    export CGO_LDFLAGS="${LDFLAGS}"
    export GOFLAGS="-buildmode=pie -trimpath -ldflags=-linkmode=external -mod=readonly -modcacherw"
    go generate
    go build -o bin/noisetorch
    go clean -modcache
}

package() {
    cd NoiseTorch
    install -D -m755 bin/noisetorch "${pkgdir}/usr/bin/noisetorch"
    install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
    install -D -m644 assets/noisetorch.desktop "${pkgdir}/usr/share/applications/noisetorch.desktop"
    install -D -m644 assets/icon/LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/icon-LICENSE"
    install -D -m644 assets/icon/noisetorch.png "${pkgdir}/usr/share/icons/hicolor/256x256/apps/noisetorch.png"
}

The changes are

_commit=ee91fea993138624dce47b4c0b626a99db25f656
source=("git+${url}#commit=${_commit}"

To get the source by commit as well as

pkgver() {
  cd NoiseTorch
  git describe --tags | sed 's/-/+/g'
}

To generate the pkgver by the git tag of that commit.

@Fumon thanks, i updated the package this this updated patch, now noisetorch can be installed normaly

If you're running into the same error as @foxite @karthikjayd and @mnqn on version 0.10.1-3, the patch file needs an update.

If you're doing a manual build, change main.patch to,

--- main.go     2021-05-16 15:53:15.287331017 -0400
+++ src/NoiseTorch-0.10.1/main.go       2021-05-16 15:53:21.954164782 -0400
@@ -25,7 +25,6 @@
        "github.com/aarzilli/nucular/style"
 )

-//go:generate go run scripts/embedversion.go
 //go:generate go run scripts/embedlicenses.go

 //go:embed c/ladspa/rnnoise_ladspa.so

Then run updpkgsums and the package should build properly.

I'm facing the same Issue as @karthikjayd and @foxite. Package broken.

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error making: noisetorch

I am facing the same issue that @foxite has pointed out.

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
:: Packages failed to build: noisetorch-0.10.1-3

Hi, thanks for adopting this package. Unfortunately with the latest release I can no longer build this package -- I'm using yay, and this is the output:

==> Starting prepare()...
patching file main.go
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file main.go.rej
==> ERROR: A failure occurred in prepare().
    Aborting...
error making: noisetorch

This is the contents of main.go.rej:

--- main.go 2021-01-31 01:57:33.000000000 -0500
+++ main.go.1   2021-02-01 09:09:20.817150966 -0500
@@ -25,7 +25,6 @@

 //go:generate go run scripts/embedbinary.go c/ladspa/rnnoise_ladspa.so librnnoise.go libRNNoise
 //go:generate go run scripts/embedbinary.go assets/patreon.png patreon.go patreonPNG
-//go:generate go run scripts/embedversion.go
 //go:generate go run scripts/embedlicenses.go

 type device struct {

I checked main.go and line 23 to 26 look like this:

//go:generate go run scripts/embedversion.go
//go:generate go run scripts/embedlicenses.go

//go:embed c/ladspa/rnnoise_ladspa.so

I'm not an expert on any of this but is that trying to remove a line which has already been made blank?

It seems likely that I'm the only person experiencing this, because the update was 5 days ago and nobody else has mentioned it. But it seems weird that I am getting an error which seems to be unrelated to anything on my machine.

We've actually been making an effort to move this into the official repos. I think I 100% agree with you though.

What I'm arguing is that it doesn't matter what the license says. The license could explicitly say "arch linux users can never use this package" but that doesn't mean anything because this is a build script, not the program itself. We're doing nothing but providing the recipe for users to build/install locally on their machines. The author is mistakenly thinking that they have control over what users do with source that is made available to the public. It doesn't matter if it's GPL, proprietary, or ultra-illegal-you-cannot-change-anything-because-i-said-so license.

Again, if this were in the official repos with pre-built packages then it'd be a different story.

You may be right, but it's a little unclear. Section 7c states that a GPLv3 licensor can apply additional terms:

Prohibiting misrepresentation of the origin of that material, or requiring that modified versions of such material be marked in reasonable ways as different from the original version.

It doesn't really say this is a requirement only for redistribution or packaged versions, so I'm not really sure if it's enforceable.

Either way, I think I'm pretty much done maintaining this. I thought it would be an interesting foray into building packages, but it has been a bad experience. Normally this kind of thing is right up my alley, and I love that I've been able to contribute a bit to Arch.

If someone wants to take over I'd be glad to help transition. I actually started a bit of work to create a new make target for distros that use go build tags to selectively include go source instead of patching things (https://github.com/erbrecht/NoiseTorch/tree/distro-build). If upstream accepts this method, which they stated they would, they wouldn't be asking us to rename the package. I just don't want to maintain this package since it's basically been an uphill battle from the start.

I do not believe that we are under any obligation to change the name so long as this is in the AUR. This is not distribution of pre-built software, this is a build script for users to create binaries for themselves. It's why the AUR is able to have myriad proprietary softwares in the repository. If Arch were to include noisetorch in the official repositories then I imagine Arch would then need to solicit a fork.

Unless there's going to be serious potential ramifications (legal threats, pushing the dev into going open-code in some misguided attempt to "fix" the situation, etc.) it seems like the package can just continue to live, patched, in the AUR alongside countless other softwares that upstream authors do not bless.

The author has demonstrated a lack of tact that ensures a barrier to mutuality; I propose we just continue doing our thing in the AUR and make software that's proper in accordance to sane packaging.

Or noiseflashlight

Can't it be like "noisetorch-patched" or something?

I'm not really sure where this hostility from upstream is coming from. I suppose you can just rename it to not-noisetorch and move on with this. :p what a silly upstream move.

I was notified by the owner of the repo that starting with the next release, they will be adding a restriction to modified versions of the application:

https://github.com/lawl/NoiseTorch/issues/2#issuecomment-785262068

Addition to the license is here:

https://github.com/lawl/NoiseTorch/commit/8b054c20a909c9cc459e87ee8b56226c0428201b

We'll need to either change the name of this package, or stop distributing it this way. I'm open to naming suggestions, but with this latest change we can't push this into [community] as-is.

It looks like their own implementation. They mentioned in the release notes that it's their own, and the repo doesn't seem to contain any submodules or links to other repos.

I created a PKGBUILD for their ladspa implementation:

https://gist.github.com/erbrecht/e35aad169e046cb05fe859cecb554598

I also updated my experimental PKGBUILD to properly link the library:

https://github.com/erbrecht/noisetorch-aur-package

Everything seems to work fine.

Are you sure it's their own implementation or that it's just copied into there from somewhere? I'd ideally like to devendor it entirely (and build the C stuff in (a) separate package(s)) and then just link to it. Think that's doable?

Ok, after looking at this for just a bit, here is what I see. Initially, noisetorch was using the ladspa plugin provided by https://github.com/werman/noise-suppression-for-voice (which in turn uses xiph's rnnoise library. It was embedding the binary, and I modified it to make use of the actual shared library.

Now, noisetorch has its own implementation of the ladspa plugin, again based on xiph's rnnoise library (provides librnnoise.so). I think what we need is the rnnoise_ladspa.so that is built here https://github.com/lawl/NoiseTorch/tree/master/c/ladspa. I have a PKGBUILD available here https://github.com/erbrecht/noisetorch-aur-package. It tries to rely on the rnnoise.so shared library, but it doesn't work since it's not the ladspa plugin (I think).

Sorry it took a while. I'm now setting the capability directly on the binary in the install file. Thanks for that suggestion.

I took a look at your changes and I implemented most of them except the dependency 2. I'm also working on linking rnnoise. It should be pretty straight forward. I'll try to get to that as soon as I can.

I originally had hicolor-icon-theme as a dependency but removed it after this feedback (https://bbs.archlinux.org/viewtopic.php?pid=1917440#p1917440). It seems to make sense.

Also, export GOPATH="$srcdir/go" is there so that the go build dependencies don't end up in the user's system. go clean -modcache cleans the source directory after the build so all those dependencies don't take up space. I'd be inclined to leave those unless there is a pressing reason to remove them. I did remove the go clean command from the prepare function since it's not really necessary before the build.

Yeah, that sounds like a sound idea. Also, take a look at my changes and perhaps adopt most of them.

Is it the desired behaviour that the noisetorch binary sets the capabilities for itself? As noisetorch is no longer usable without the capability cap_sys_resource I would assume that the best place to set it is the install file (like it is done for e.g. ping).

Ideally I'd want to separately package the C dependencies and dynamically link them in. As a start, I packaged rnnoise. Can you try linking that dynamically instead of the weird soname embedding that's going on?

Apart from that, this would be my current PKGBUILD: https://gitlab.archlinux.org/-/snippets/5

I did some minor cleanup on the PKGBUILD. It follows the go packaging guidelines as far as I can tell, and I believe it is reproducible. Updating the pkgver in the PKGBUILD is all I have been doing for the past couple releases, otherwise the current version builds no problem without intervention.

Make sure to clean up the package and make it reproducible/make it comply with go package guidelines.

@Svenstaro Absolutely not, go right ahead! Is there anything you need me to do?

@znoble360 The readme is indeed incorrect, but if the application prompts for creds to set the capability, it appears to operates on itself instead of a fixed path 1 and 2.

That executable function might have problems dealing with symlinks, but if the package is installed as-is, it should work. I haven't touched the setcap command on my system and I see:

$ getcap /usr/bin/noisetorch
/usr/bin/noisetorch cap_sys_resource=eip

You mind me pulling this into [community]?

After a bit of futzing around, I figured out why the CAP_SYS_RESOURCE authorization was failing for me. It looks like since you install noisetorch in /bin instead of home and the original attempts to authorize noisetorch in the user home, the user can't use the autofix for CAP_SYS_RESOURCE. The official command in the git sudo setcap 'CAP_SYS_RESOURCE=+ep' ~/.local/bin/noisetorch also doesnt work for the same reason, so one must instead replace ~/.local/bin/noisetorch with the new location of the binary.

for the package conflicts, should the -bin -git variants still conflict with this one? so basically this package conflicts with nothing, while the other -git -bin variants contain all the conflicts?

Hello, thanks for this package! Version 0.9.0 is went out three days ago :)

Hey, thanks for the package. A note: Regular packages should not conflict with their non-regular (-git, -bin) variants. However, conversely, those odd packages should conflict with the regular one. The idea is that the regular packages should be ignorant of the irregular ones.